Bug 106669 - Android build fails to link: undefined reference to 'tiled_to_linear'
Summary: Android build fails to link: undefined reference to 'tiled_to_linear'
Status: RESOLVED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Drivers/DRI/i965 (show other bugs)
Version: git
Hardware: Other All
: medium normal
Assignee: Scott D Phillips
QA Contact: Intel 3D Bugs Mailing List
URL:
Whiteboard:
Keywords: bisected, regression
Depends on:
Blocks:
 
Reported: 2018-05-26 16:44 UTC by Mark Janes
Modified: 2018-05-26 23:28 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Janes 2018-05-26 16:44:42 UTC
drivers/dri/i965/intel_mipmap_tree.c:3194: error: undefined reference to 'tiled_to_linear'

Bisected to:
d21c086d819d78fb3f6abcbb14aa492970f442aa
Author:     Scott D Phillips <scott.d.phillips@intel.com>
i965/tiled_memcpy: inline movntdqa loads in tiled_to_linear

The reference for MOVNTDQA says:

    For WC memory type, the nontemporal hint may be implemented by
    loading a temporary internal buffer with the equivalent of an
    aligned cache line without filling this data to the cache.
    [...] Subsequent MOVNTDQA reads to unread portions of the WC
    cache line will receive data from the temporary internal
    buffer if data is available.

This hidden cache line sized temporary buffer can improve the
read performance from wc maps.
Comment 1 Kenneth Graunke 2018-05-26 23:28:22 UTC
Fixed temporarily by:

commit 58fb613a51994d111ee77a65bc7f3d60b155c687
Author: Kenneth Graunke <kenneth@whitecape.org>
Date:   Sat May 26 16:25:34 2018 -0700

    i965: Revert recent tiled memcpy changes.
    
    This reverts commit 79fe00efb474b3f3f0ba4c88826ff67c53a02aef.
    This reverts commit f5e8b13f78a085bc95a1c0895e4a38ff6b87b375.
    This reverts commit d21c086d819d78fb3f6abcbb14aa492970f442aa.
    
    They broke the Android build and I'd rather not leave it broken
    for the long holiday weekend.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.