Mesa performance with SynMark v7 DrvState performance dropped by 2-3% between following Mesa commits:
2018-05-21 11:57:46 73df16dcee: radv: fix centroid interpolation
2018-05-22 17:02:28 92f01fc5f9: i965: Emit VF cache invalidates for 48-bit addressing bugs with softpin.
This performance drop is clearly visible on SKL GT2, GT3e, GT4e, KBL GT2, GT3e and GKL B0. On BXT devices there's too much variance in this test to be sure whether they're affected.
In the same interval there's even larger drop in SynMark v7 Multithread test on the same machines. That drop isn't visible on BXT.
These regressions are GEN9+ specific, they aren't visible on GEN6-8 machines.
Only commits in that range which could have impact on these machines are:
92f01fc5f9 i965: Emit VF cache invalidates for 48-bit addressing bugs with softpin.
c7259259d4 i965: Introduce a "memory zone" concept on BO allocation.
417b9e5770 intel/eu: Set EXECUTE_1 when setting the rounding mode in cr0
fe2edb25dd dri3: Stricter SBC wraparound handling
First one affects GEN8+, next two are more generic ones, and last one is X hang fix. None of them is GEN9+ specific, so somebody would need to bisect these two regressions further.
From inspection, 92f01fc5f914fd500497d0c3aed75f3ac8dc054d:
+vf_invalidate_for_vb_48bit_transitions(struct brw_context *brw)
+#if GEN_GEN >= 8
+ bool need_invalidate = true;
+ unsigned i;
that need_invalidate should be initialised to false
Should be fixed by:
Author: Chris Wilson <email@example.com>
Date: Tue May 29 17:28:07 2018 +0100
i965: Only emit VF cache invalidations when the high bits changes
Commit 92f01fc5f914 ("i965: Emit VF cache invalidates for 48-bit
addressing bugs with softpin.") tried to only emit the VF invalidate if
the high bits changed, but it accidentally always set need_invalidate to
true; causing it to emit unconditionally emit the pipe control before
Fixes: 92f01fc5f914 ("i965: Emit VF cache invalidates for 48-bit addressing bugs with softpin.")
Reviewed-by: Kenneth Graunke <firstname.lastname@example.org>
Verified. Both performance regressions go away with Mesa git.