The following files are missing from the 18.1.0 and 18.1.1 tarballs: src/intel/tools/intel_sanitize_gpu.in src/intel/tools/intel_sanitize_gpu.c Notes: src/intel/tools/meson.build lists these files, but they're inside an if statement, so I suspect they're not being parsed when the tarball is being built (eg: using `ninja dist` ?). Specifically, they're listed behind: if with_tools.contains('intel') Wasn't sure of the best way to fix this, hence this bug.
(In reply to Stuart Young from comment #0) > src/intel/tools/meson.build lists these files, but they're inside an if > statement, so I suspect they're not being parsed when the tarball is being > built (eg: using `ninja dist` ?). The tarballs are generated with autotools for now (see https://mesa3d.org/releasing.html#release), and the issue here is that these files are only used to build a program meson builds, not autotools. Kevin, can you either add the build instructions to src/intel/Makefile.tools.am, or add the two files to EXTRA_DIST (in that same makefile)? Either way, please add this line to allow the scripts to pick it up: Fixes: cc41603d6da4552f0aaf "intel/tools: new intel_sanitize_gpu tool" Thanks :)
Hi, I am no longer involved with Mesa development; I suggest assigning the bug to whoever the git log lists as the author for the git commit that added those files.
Scott, you worked on bringing this code in to the mesa tree (based on the commit log). Are you able to update src/intel/Makefile.tools.am with the necessary build instructions so it can be built using Autotools? If so, please add this line to allow the scripts to pick it up: Fixes: cc41603d6da4552f0aaf "intel/tools: new intel_sanitize_gpu tool" If not, I'll submit a patch that simply adds these files to the EXTRA_DIST field in src/intel/Makefile.tools.am to solve this for the moment.
(In reply to Kevin Rogovin from comment #2) > I suggest assigning the bug to whoever the git log lists as the > author for the git commit that added those files. That would be why I assigned it to you :P commit cc41603d6da4552f0aaf32325a8f019c44c3d9c8 Author: Kevin Rogovin <kevin.rogovin@intel.com> Date: Thu Feb 8 17:11:25 2018 -0800 intel/tools: new intel_sanitize_gpu tool ... but I did fail to notice Scott was the one who rebased and landed your patch; sorry :)
pushed: commit a6446ce3957cb5f5552cac7269f3a7d3af631b77 Author: Scott D Phillips <scott.d.phillips@intel.com> Date: Tue Jun 5 09:33:49 2018 -0700 intel/tools: add intel_sanitize_gpu to EXTRA_DIST Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106778 Fixes: cc41603d6d ("intel/tools: new intel_sanitize_gpu tool") Reviewed-by: Dylan Baker <dylan@pnwbakers.com>
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.