Bug 106778 - Files missing from tarball - intel_sanitize_gpu.*
Summary: Files missing from tarball - intel_sanitize_gpu.*
Status: RESOLVED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Other (show other bugs)
Version: git
Hardware: All All
: medium normal
Assignee: Scott D Phillips
QA Contact: mesa-dev
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-06-02 03:29 UTC by Stuart Young
Modified: 2018-06-05 17:35 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description Stuart Young 2018-06-02 03:29:10 UTC
The following files are missing from the 18.1.0 and 18.1.1 tarballs:

 src/intel/tools/intel_sanitize_gpu.in
 src/intel/tools/intel_sanitize_gpu.c

Notes:

 src/intel/tools/meson.build lists these files, but they're inside an if statement, so I suspect they're not being parsed when the tarball is being built (eg: using `ninja dist` ?).

Specifically, they're listed behind: if with_tools.contains('intel')

Wasn't sure of the best way to fix this, hence this bug.
Comment 1 Eric Engestrom 2018-06-04 17:35:04 UTC
(In reply to Stuart Young from comment #0)
>  src/intel/tools/meson.build lists these files, but they're inside an if
> statement, so I suspect they're not being parsed when the tarball is being
> built (eg: using `ninja dist` ?).

The tarballs are generated with autotools for now (see https://mesa3d.org/releasing.html#release), and the issue here is that these files are only used to build a program meson builds, not autotools.

Kevin, can you either add the build instructions to src/intel/Makefile.tools.am, or add the two files to EXTRA_DIST (in that same makefile)?
Either way, please add this line to allow the scripts to pick it up:
Fixes: cc41603d6da4552f0aaf "intel/tools: new intel_sanitize_gpu tool"

Thanks :)
Comment 2 Kevin Rogovin 2018-06-04 20:28:15 UTC
Hi,

 I am no longer involved with Mesa development; I suggest assigning the bug to whoever the git log lists as the author for the git commit that added those files.
Comment 3 Stuart Young 2018-06-04 23:42:35 UTC
Scott, you worked on bringing this code in to the mesa tree (based on the commit log). Are you able to update src/intel/Makefile.tools.am with the necessary build instructions so it can be built using Autotools?

If so, please add this line to allow the scripts to pick it up:
Fixes: cc41603d6da4552f0aaf "intel/tools: new intel_sanitize_gpu tool"

If not, I'll submit a patch that simply adds these files to the EXTRA_DIST field in src/intel/Makefile.tools.am to solve this for the moment.
Comment 4 Eric Engestrom 2018-06-05 10:24:03 UTC
(In reply to Kevin Rogovin from comment #2)
> I suggest assigning the bug to whoever the git log lists as the
> author for the git commit that added those files.

That would be why I assigned it to you :P

commit cc41603d6da4552f0aaf32325a8f019c44c3d9c8
Author: Kevin Rogovin <kevin.rogovin@intel.com>
Date:   Thu Feb 8 17:11:25 2018 -0800

    intel/tools: new intel_sanitize_gpu tool

... but I did fail to notice Scott was the one who rebased and landed your patch; sorry :)
Comment 5 Scott D Phillips 2018-06-05 17:35:22 UTC
pushed:

commit a6446ce3957cb5f5552cac7269f3a7d3af631b77
Author: Scott D Phillips <scott.d.phillips@intel.com>
Date:   Tue Jun 5 09:33:49 2018 -0700

    intel/tools: add intel_sanitize_gpu to EXTRA_DIST
    
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106778
    Fixes: cc41603d6d ("intel/tools: new intel_sanitize_gpu tool")
    Reviewed-by: Dylan Baker <dylan@pnwbakers.com>


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.