Bug 106783 - pdfsig does not build on Darwin
Summary: pdfsig does not build on Darwin
Status: RESOLVED FIXED
Alias: None
Product: poppler
Classification: Unclassified
Component: utils (show other bugs)
Version: unspecified
Hardware: Other Mac OS X (All)
: medium normal
Assignee: poppler-bugs
QA Contact:
URL: https://github.com/NixOS/nixpkgs/issu...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-06-02 13:05 UTC by Jan Tojnar
Modified: 2018-06-24 16:47 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments

Description Jan Tojnar 2018-06-02 13:05:59 UTC 
When building poppler-utils on Darwin, we are getting the following error:

../utils/pdfsig.cc:107:63: error: use of undeclared identifier 'basename'
    GooString *path = GooString::format(format->getCString(), basename(filename), sig_num);
                                                              ^

The feature was introduced in https://cgit.freedesktop.org/poppler/poppler/commit/?id=bdece3bb0c115576d23e76dc29ee43f04aafdee0

Possibly libgen.h should be included?
Comment 1 Albert Astals Cid 2018-06-03 21:08:32 UTC 
hmmm, i just realized we seem to depend on the GNU version of basename that is part of string.h and takes a const char * instead of a char *. i guess not part of Darwin?
Comment 2 Jan Tojnar 2018-06-03 21:12:07 UTC 
Right, we use LLVM’s libc++ (https://libcxx.llvm.org/).

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.