Bug 106965 - File name with diacritical character are created with UTF-8 charset on Windows environment instead of UTF-16
Summary: File name with diacritical character are created with UTF-8 charset on Window...
Status: RESOLVED INVALID
Alias: None
Product: poppler
Classification: Unclassified
Component: pdftohtml (show other bugs)
Version: unspecified
Hardware: x86 (IA32) Windows (All)
: medium major
Assignee: poppler-bugs
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-06-19 17:13 UTC by Thibaut
Modified: 2018-06-19 17:59 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
Utils: use openFile instead of fopen for _WIN32 environment compatibility (UTF-16 file name) (9.03 KB, patch)
2018-06-19 17:13 UTC, Thibaut
Details | Splinter Review

Description Thibaut 2018-06-19 17:13:43 UTC
Created attachment 140233 [details] [review]
Utils: use openFile instead of fopen for _WIN32 environment compatibility (UTF-16 file name)

When using pdftohtml (and probably other tools from /utils), I faced a problem with file naming using diacritical char in Windows environment.

ie: when expected "file_é.xml" we obtain "file_é.xml"

The problem is that in many place in the code the function 'fopen' is used to create files instead of the fileOpen function (from goo/gfile.h).
The fileOpen method is already dealing with that problem. Please find in attachment a patch to fix that issue in every .cc file from utils.
Comment 1 Albert Astals Cid 2018-06-19 17:59:04 UTC
I'm not strict with where to send patches, you can decide where to send them either the mailing list or bugzilla, but not both since then the discussion happens in both places and it's very hard to follow.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.