Bug 10698 - shared-mime-info.pc belongs in libdir, not in datadir
Summary: shared-mime-info.pc belongs in libdir, not in datadir
Status: RESOLVED INVALID
Alias: None
Product: shared-mime-info
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Jonathan Blandford
QA Contact:
URL:
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2007-04-21 02:35 UTC by Tilman Sauerbeck
Modified: 2007-07-25 06:46 UTC (History)
3 users (show)

See Also:
i915 platform:
i915 features:


Attachments
Patch (515 bytes, patch)
2007-04-21 02:35 UTC, Tilman Sauerbeck
Details | Splinter Review

Description Tilman Sauerbeck 2007-04-21 02:35:01 UTC
shared-mime-info.pc is installed to $datadir/pkgconfig, but it should be in $libdir/pkgconfig.
Comment 1 Tilman Sauerbeck 2007-04-21 02:35:38 UTC
Created attachment 9666 [details] [review]
Patch
Comment 2 Christian - Manny Calavera - Neumair 2007-06-27 11:16:59 UTC
Thanks, good catch! Fixed.
Comment 3 Ville Skyttä 2007-06-27 12:36:32 UTC
I'm wondering what the rationale for this change is.  The file doesn't appear to contain anything architecture specific, so $datadir/pkgconfig sounds correct to me.  (Reopening for comments.)
Comment 4 Christian - Manny Calavera - Neumair 2007-06-27 13:00:01 UTC
I've observed that GNOME packages like Nautilus and gnome-vfs also install their .pc files to $libdir/pkgconfig.
Comment 5 Ville Skyttä 2007-06-28 08:14:18 UTC
Yes, but unlike shared-mime-info's, their *.pc files contain architecture specific things such as $libdir, Cflags etc.  $libdir/pkgconfig is correct for them.
Comment 6 Bastien Nocera 2007-07-22 09:10:08 UTC
It reverts the patch from bug 9789 I committed. What's the reasoning behind installing it in $(libdir)? It shouldn't be there if it doesn't contain any arch specific data, which it doesn't.

2007-02-02  Bastien Nocera  <hadess@hadess.net>

        * Makefile.am:
        * shared-mime-info.pc.in: Patch from Ville Skyttä <ville.skytta@iki.fi>
        to move the shared-mime-info pkgconfig file to $(datadir), as it doesn't
        contain any arch-specific data (Closes: #9789)


Unless you have a good reason for moving it, please revert this commit.
Comment 7 Christian - Manny Calavera - Neumair 2007-07-25 06:46:33 UTC
OK, reverted.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.