Bug 107011 - allowMultipleSelection is wrong in korean data
Summary: allowMultipleSelection is wrong in korean data
Status: RESOLVED FIXED
Alias: None
Product: xkeyboard-config
Classification: Unclassified
Component: General (show other bugs)
Version: unspecified
Hardware: All All
: medium minor
Assignee: xkb
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-06-23 16:22 UTC by Hodong Kim
Modified: 2018-09-26 22:49 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description Hodong Kim 2018-06-23 16:22:27 UTC
Hello.
I am a Korean user.

The allowMultipleSelection is wrong in korean data.
allowMultipleSelection should be "false".

hodong@debian:~/Downloads/xkeyboard-config-2.24/xkeyboard-config-2.24$ git diff
diff --git a/rules/base.xml.in b/rules/base.xml.in
index 3608b60..fae781a 100644
--- a/rules/base.xml.in
+++ b/rules/base.xml.in
@@ -7250,7 +7250,7 @@
        </configItem>
       </option>
     </group>
-    <group allowMultipleSelection="true">
+    <group allowMultipleSelection="false">
       <configItem>
         <name>korean</name>
         <_description>Korean Hangul/Hanja keys</_description>
diff --git a/rules/evdev.xml.in b/rules/evdev.xml.in
index 3608b60..fae781a 100644
--- a/rules/evdev.xml.in
+++ b/rules/evdev.xml.in
@@ -7250,7 +7250,7 @@
        </configItem>
       </option>
     </group>
-    <group allowMultipleSelection="true">
+    <group allowMultipleSelection="false">
       <configItem>
         <name>korean</name>
         <_description>Korean Hangul/Hanja keys</_description>
Comment 1 Changwoo Ryu 2018-07-25 07:39:42 UTC
I wrote this and I confirm it was my mistake. allowMultipleSelection should be false.

I wrote allowMultipleSection=true because first I thought of making independent options for Hangul and Hanja keys and then I found out gnome-tweak-tool doesn't support multiple option select so changed the code like the current version.
Comment 2 Sergey V. Udaltsov 2018-09-26 22:49:23 UTC
thank you, fixed and committed!


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.