Bug 107048 - [PATCH] Fix details view interaction with systemd and details logging
Summary: [PATCH] Fix details view interaction with systemd and details logging
Status: RESOLVED FIXED
Alias: None
Product: plymouth
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Ray Strode [halfline]
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-06-26 19:02 UTC by Hans de Goede
Modified: 2018-07-10 19:45 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
[PATCH 1/2] main: Fix getting detailed logs from systemd (2.52 KB, patch)
2018-06-26 19:02 UTC, Hans de Goede
Details | Splinter Review
[PATCH 2/2] ply-logger: Truncate log files instead of appending (1.27 KB, patch)
2018-06-26 19:06 UTC, Hans de Goede
Details | Splinter Review
[PATCH 1/2] main: Fix getting detailed logs from systemd (v2) (3.28 KB, patch)
2018-07-03 07:26 UTC, Hans de Goede
Details | Splinter Review

Description Hans de Goede 2018-06-26 19:02:29 UTC
Created attachment 140351 [details] [review]
[PATCH 1/2] main: Fix getting detailed logs from systemd

Hi,

Here are 2 patches:

1) Fixes systemd sometimes not being in detailed-logging mode, breaking details view and causing the details to not end up in /var/log/boot.log

2) Truncate /var/log/boot.log on each boot

See the commit msgs of both patches for detals.

Regards,

Hans
Comment 1 Hans de Goede 2018-06-26 19:06:05 UTC
Created attachment 140352 [details] [review]
[PATCH 2/2] ply-logger: Truncate log files instead of appending
Comment 2 Hans de Goede 2018-07-03 07:26:49 UTC
Created attachment 140445 [details] [review]
[PATCH 1/2] main: Fix getting detailed logs from systemd (v2)

New version of "[PATCH 1/2] main: Fix getting detailed logs from systemd" changes in this version:

-Tell systemd to stop printing details when we detach from the session, so
 that we don't break the smooth transition from no-splash-shown-yet to gdm
Comment 3 Ray Strode [halfline] 2018-07-10 19:45:34 UTC
I've pushed your first patch.

To ssh://git.freedesktop.org/git/plymouth
   129b4a5..6a1fdab  master -> master


I'm a little reluctant to do your second patch. we've already switched it once:


    Revert "Recreate boot log at each boot instead of appending"
    
    This reverts commit 9abbd88835a181cda1427d61d92ef5685ad8a81b.
    
    I'm getting requests to keep old boot logs around.  If anyone
    wants to carve up boot.log, they can just use logrotate.d

So i don't really want to naively switch it back. Maybe we could do something more sophisticated, not sure. 

i also wouldn't be opposed to shipping a logrotate.d file upstream.  downstream in rhel we use this one:

/var/log/boot.log
{
    missingok
    daily
    copytruncate
    rotate 7
    notifempty
}

If you want to go that route, let's do it in a new bug.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.