Created attachment 140361 [details] [review] [PATCH] build: support building with elogind elogind is a drop-in replacement for systemd's logind and as such can be used here without big changes.
I think the patch should fulfil the following requirements: input: --enable-systemd-login --enable-elogind-login installed: libsystemd, libelogind output: error, can't enable both input: --enable-systemd-login installed: libsystemd, libelogind output: use libsystemd input: --enable-elogind-login installed: libsystemd, libelogind output: use libelogind input: --enable-systemd-login installed: libelogind output: error, systemd requested but not installed input: --enable-elogind-login installed: libsystemd output: error, elogind requested but not installed input: no configure args installed: libsystemd, libelogind output: use libsystemd input: no configure args installed: libsystemd output: use libsystemd input: no configure args installed: libelogind output: use libelogind Currently the patch doesn't handle all cases correctly. For example, if both libsystemd and libelogind are installed, but only --enable-systemd-login is passed to configure, the patch produces an error. Can you send a revised patch to the mailing list? I find it easier to comment on the details of the code that way. Subscribe here: https://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss Here are instructions for using git send-email, in case you find that useful: https://www.freedesktop.org/wiki/Software/PulseAudio/HowToUseGitSendEmail/
(In reply to Tanu Kaskinen from comment #1) > Currently the patch doesn't handle all cases correctly. For example, if both > libsystemd and libelogind are installed, but only --enable-systemd-login is > passed to configure, the patch produces an error. What behavior would you suggest if both of them are installed? Tell the user to explicitly choose one? > Can you send a revised patch to the mailing list? I find it easier to > comment on the details of the code that way. Subscribe here: > https://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss Hm, ok, I don't like MLs much, but sure > Here are instructions for using git send-email, in case you find that useful: > https://www.freedesktop.org/wiki/Software/PulseAudio/HowToUseGitSendEmail/
(In reply to Rasmus Thomsen from comment #2) > What behavior would you suggest if both of them are installed? Tell the user > to explicitly choose one? I guess you're talking about the case where no configure args are given? I tried to answer this in my previous message: input: no configure args installed: libsystemd, libelogind output: use libsystemd I chose libsystemd, because it's the "normal" option. One could argue that if libelogind is installed, that's a pretty strong indication that the user actually wants to use libelogind, so maybe libelogind should be the default choice. Or maybe it's indeed best to force the user to tell his preference by throwing an error. I'm ok with any of these alternatives.
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/issues/222.
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.