Very similar to https://bugs.freedesktop.org/show_bug.cgi?id=106194 but still happens in 4.18-rc3

Right before this in journalctl:

[  268.322916] hades-media /usr/lib/gdm3/gdm-x-session[896]: (--) AMDGPU(0): HDMI max TMDS frequency 300000KHz
[  268.324908] hades-media /usr/lib/gdm3/gdm-x-session[896]: (II) AMDGPU(0): Allocate new frame buffer 4096x2160
[  268.324976] hades-media /usr/lib/gdm3/gdm-x-session[896]: (II) AMDGPU(0):  => pitch 16384 bytes

Also present in dmesg now after leaving the system on:

[44775.903197] [drm] amdgpu_dm_irq_schedule_work FAILED src 6
[44777.523222] [drm] amdgpu_dm_irq_schedule_work FAILED src 6
[44778.253228] [drm] amdgpu_dm_irq_schedule_work FAILED src 6
[44779.433248] [drm] amdgpu_dm_irq_schedule_work FAILED src 6
[44838.184045] [drm] amdgpu_dm_irq_schedule_work FAILED src 6

Same with 4.18-rc4:

[   44.170327] [drm] fb mappable at 0x2000A28000
[   44.170328] [drm] vram apper at 0x2000000000
[   44.170329] [drm] size 35389440
[   44.170329] [drm] fb depth is 24
[   44.170329] [drm]    pitch is 16384
[   44.170388] fbcon: amdgpudrmfb (fb0) is primary device
[   44.366023] Console: switching to colour frame buffer device 512x135
[   44.392795] amdgpu 0000:01:00.0: fb0: amdgpudrmfb frame buffer device
[   44.399041] ------------[ cut here ]------------
[   44.399042] kernel BUG at /home/kernel/COD/linux/drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:4829!
[   44.399046] invalid opcode: 0000 [#1] SMP PTI
[   44.399047] CPU: 4 PID: 949 Comm: Xorg Tainted: G        W         4.18.0-041800rc4-generic #201807082030
[   44.399048] Hardware name: Intel Corporation NUC8i7HVK/NUC8i7HVB, BIOS HNKBLi70.86A.0044.2018.0615.1726 06/15/2018
[   44.399081] RIP: 0010:dm_update_crtcs_state+0x41e/0x4a0 [amdgpu]
[   44.399082] Code: e9 8f fd ff ff 8b 45 c0 48 8d 65 d8 5b 41 5c 41 5d 41 5e 41 5f 5d c3 48 83 bb 08 0d 00 00 00 0f 85 08 ff ff ff e9 fc fe ff ff <0f> 0b b8 ea ff ff ff e9 ca fc ff ff 41 8b 4e 60 48 c7 c2 30 1b 81 
[   44.399094] RSP: 0018:ffffa1f042bfba18 EFLAGS: 00010246
[   44.399095] RAX: ffff916f25b0a401 RBX: 0000000000000000 RCX: 000000000000131a
[   44.399095] RDX: 0000000000001319 RSI: ffff916f3ed27160 RDI: ffff916f2e002f00
[   44.399096] RBP: ffffa1f042bfba78 R08: 0000000000027160 R09: ffffffffc07c6836
[   44.399096] R10: ffffce861196c200 R11: 00000000f0000080 R12: ffff916f270c0200
[   44.399096] R13: 0000000000000000 R14: ffff916f1fd75800 R15: ffff916f25b0f800
[   44.399097] FS:  00007f6116645600(0000) GS:ffff916f3ed00000(0000) knlGS:0000000000000000
[   44.399098] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[   44.399098] CR2: 000055f131e14480 CR3: 0000000468a2a006 CR4: 00000000003606e0
[   44.399099] Call Trace:
[   44.399124]  amdgpu_dm_atomic_check+0x18e/0x3d0 [amdgpu]
[   44.399126]  ? radix_tree_lookup+0xd/0x10
[   44.399136]  drm_atomic_check_only+0x33b/0x510 [drm]
[   44.399141]  drm_atomic_commit+0x18/0x50 [drm]
[   44.399146]  drm_atomic_helper_set_config+0x7c/0x90 [drm_kms_helper]
[   44.399151]  __drm_mode_set_config_internal+0x6b/0x120 [drm]
[   44.399156]  drm_mode_setcrtc+0x4b0/0x6a0 [drm]
[   44.399160]  ? drm_mode_getcrtc+0x1a0/0x1a0 [drm]
[   44.399164]  drm_ioctl_kernel+0xa4/0xf0 [drm]
[   44.399168]  drm_ioctl+0x37b/0x440 [drm]
[   44.399172]  ? drm_mode_getcrtc+0x1a0/0x1a0 [drm]
[   44.399185]  amdgpu_drm_ioctl+0x4f/0x90 [amdgpu]
[   44.399187]  do_vfs_ioctl+0xa8/0x630
[   44.399189]  ? recalc_sigpending+0x1b/0x50
[   44.399190]  ? _copy_from_user+0x3e/0x60
[   44.399191]  ksys_ioctl+0x75/0x80
[   44.399192]  __x64_sys_ioctl+0x1a/0x20
[   44.399194]  do_syscall_64+0x5a/0x120
[   44.399195]  entry_SYSCALL_64_after_hwframe+0x44/0xa9
[   44.399196] RIP: 0033:0x7f6113a3a5d7
[   44.399196] Code: b3 66 90 48 8b 05 b1 48 2d 00 64 c7 00 26 00 00 00 48 c7 c0 ff ff ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 b8 10 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 81 48 2d 00 f7 d8 64 89 01 48 
[   44.399208] RSP: 002b:00007fff4f70d328 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
[   44.399209] RAX: ffffffffffffffda RBX: 00007fff4f70d360 RCX: 00007f6113a3a5d7
[   44.399210] RDX: 00007fff4f70d360 RSI: 00000000c06864a2 RDI: 000000000000000c
[   44.399210] RBP: 00007fff4f70d360 R08: 0000000000000000 R09: 000055f131e07380
[   44.399210] R10: 00007fff4f70d420 R11: 0000000000000246 R12: 00000000c06864a2
[   44.399211] R13: 000000000000000c R14: 0000000000000000 R15: 000055f131e07380
[   44.399212] Modules linked in: ccm thunderbolt rfcomm cmac bnep nls_iso8859_1 arc4 intel_rapl x86_pkg_temp_thermal intel_powerclamp coretemp kvm_intel kvm irqbypass morus1280_avx2 8250_dw morus1280_sse2 morus1280_glue morus640_sse2 morus640_glue aegis256_aesni aegis128l_aesni aegis128_aesni crct10dif_pclmul crc32_pclmul ghash_clmulni_intel pcbc iwlmvm snd_hda_codec_realtek snd_hda_codec_generic snd_seq_midi mac80211 snd_seq_midi_event snd_hda_codec_hdmi snd_rawmidi snd_hda_intel btusb snd_hda_codec btrtl btbcm aesni_intel snd_hda_core btintel snd_hwdep iwlwifi aes_x86_64 crypto_simd cryptd glue_helper snd_seq input_leds bluetooth snd_pcm intel_cstate snd_seq_device intel_rapl_perf ir_rc6_decoder cfg80211 serio_raw intel_wmi_thunderbolt wmi_bmof snd_timer ecdh_generic idma64 snd virt_dma mei_me soundcore
[   44.399229]  intel_lpss_pci mei intel_pch_thermal intel_lpss rc_rc6_mce ite_cir rc_core tps6598x typec acpi_pad mac_hid sch_fq_codel parport_pc ppdev lp parport ip_tables x_tables autofs4 amdkfd amd_iommu_v2 amdgpu chash gpu_sched ttm drm_kms_helper syscopyarea sysfillrect igb sysimgblt psmouse fb_sys_fops e1000e drm sdhci_pci dca cqhci i2c_algo_bit sdhci wmi pinctrl_sunrisepoint pinctrl_intel video
[   44.399240] ---[ end trace 8a687bbe699300d5 ]---
[   44.399264] RIP: 0010:dm_update_crtcs_state+0x41e/0x4a0 [amdgpu]
[   44.399264] Code: e9 8f fd ff ff 8b 45 c0 48 8d 65 d8 5b 41 5c 41 5d 41 5e 41 5f 5d c3 48 83 bb 08 0d 00 00 00 0f 85 08 ff ff ff e9 fc fe ff ff <0f> 0b b8 ea ff ff ff e9 ca fc ff ff 41 8b 4e 60 48 c7 c2 30 1b 81 
[   44.399276] RSP: 0018:ffffa1f042bfba18 EFLAGS: 00010246
[   44.399277] RAX: ffff916f25b0a401 RBX: 0000000000000000 RCX: 000000000000131a
[   44.399277] RDX: 0000000000001319 RSI: ffff916f3ed27160 RDI: ffff916f2e002f00
[   44.399278] RBP: ffffa1f042bfba78 R08: 0000000000027160 R09: ffffffffc07c6836
[   44.399278] R10: ffffce861196c200 R11: 00000000f0000080 R12: ffff916f270c0200
[   44.399279] R13: 0000000000000000 R14: ffff916f1fd75800 R15: ffff916f25b0f800
[   44.399279] FS:  00007f6116645600(0000) GS:ffff916f3ed00000(0000) knlGS:0000000000000000
[   44.399280] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[   44.399280] CR2: 000055f131e14480 CR3: 0000000468a2a006 CR4: 00000000003606e0
[   48.452335] xhci_hcd 0000:3d:00.0: remove, state 4
[   48.452362] usb usb6: USB disconnect, device number 1
[   48.452659] xhci_hcd 0000:3d:00.0: USB bus 6 deregistered
[   48.452691] xhci_hcd 0000:3d:00.0: xHCI host controller not responding, assume dead
[   48.452736] xhci_hcd 0000:3d:00.0: remove, state 4
[   48.452760] usb usb5: USB disconnect, device number 1
[   48.453027] xhci_hcd 0000:3d:00.0: Host halt failed, -19
[   48.453066] xhci_hcd 0000:3d:00.0: Host not accessible, reset failed.
[   48.453153] xhci_hcd 0000:3d:00.0: USB bus 5 deregistered
[   48.972206] thunderbolt 0000:09:00.0: stopping RX ring 0
[   48.972242] thunderbolt 0000:09:00.0: disabling interrupt at register 0x38200 bit 12 (0xffffffff -> 0xffffefff)
[   48.972295] thunderbolt 0000:09:00.0: stopping TX ring 0
[   48.972326] thunderbolt 0000:09:00.0: disabling interrupt at register 0x38200 bit 0 (0xffffffff -> 0xfffffffe)
[   48.972374] thunderbolt 0000:09:00.0: control channel stopped
[   48.972454] thunderbolt 0000:09:00.0: freeing RX ring 0
[   48.972485] thunderbolt 0000:09:00.0: freeing TX ring 0
[   48.972516] thunderbolt 0000:09:00.0: shutdown
[   49.012348] pci_bus 0000:08: Allocating resources
[   49.012417] pcieport 0000:08:01.0: bridge window [io  0x1000-0x0fff] to [bus 0a-3c] add_size 1000
[   49.012470] pcieport 0000:08:02.0: bridge window [io  0x1000-0x0fff] to [bus 3d] add_size 1000
[   49.012511] pcieport 0000:08:02.0: bridge window [mem 0x00100000-0x000fffff 64bit pref] to [bus 3d] add_size 200000 add_align 100000
[   49.012576] pcieport 0000:08:04.0: bridge window [io  0x1000-0x0fff] to [bus 3e-71] add_size 1000
[   49.012629] pcieport 0000:07:00.0: bridge window [io  0x1000-0x0fff] to [bus 08-71] add_size 3000
[   49.012673] pcieport 0000:07:00.0: BAR 13: no space for [io  size 0x3000]
[   49.012704] pcieport 0000:07:00.0: BAR 13: failed to assign [io  size 0x3000]
[   49.012738] pcieport 0000:07:00.0: BAR 13: no space for [io  size 0x3000]
[   49.012770] pcieport 0000:07:00.0: BAR 13: failed to assign [io  size 0x3000]
[   49.012809] pcieport 0000:08:02.0: BAR 15: no space for [mem size 0x00200000 64bit pref]
[   49.012847] pcieport 0000:08:02.0: BAR 15: failed to assign [mem size 0x00200000 64bit pref]
[   49.012886] pcieport 0000:08:01.0: BAR 13: no space for [io  size 0x1000]
[   49.012917] pcieport 0000:08:01.0: BAR 13: failed to assign [io  size 0x1000]
[   49.012951] pcieport 0000:08:02.0: BAR 13: no space for [io  size 0x1000]
[   49.012982] pcieport 0000:08:02.0: BAR 13: failed to assign [io  size 0x1000]
[   49.013015] pcieport 0000:08:04.0: BAR 13: no space for [io  size 0x1000]
[   49.013047] pcieport 0000:08:04.0: BAR 13: failed to assign [io  size 0x1000]
[   49.013080] pcieport 0000:08:04.0: BAR 13: no space for [io  size 0x1000]
[   49.013112] pcieport 0000:08:04.0: BAR 13: failed to assign [io  size 0x1000]
[   49.013147] pcieport 0000:08:02.0: BAR 15: no space for [mem size 0x00200000 64bit pref]
[   49.013184] pcieport 0000:08:02.0: BAR 15: failed to assign [mem size 0x00200000 64bit pref]
[   49.013223] pcieport 0000:08:02.0: BAR 13: no space for [io  size 0x1000]
[   49.013255] pcieport 0000:08:02.0: BAR 13: failed to assign [io  size 0x1000]
[   49.013288] pcieport 0000:08:01.0: BAR 13: no space for [io  size 0x1000]
[   49.013319] pcieport 0000:08:01.0: BAR 13: failed to assign [io  size 0x1000]

For reference, they seem to reference the same line and is vanilla compared to Ubuntu-kernels:

https://github.com/torvalds/linux/blob/v4.18-rc3/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c#L4784
https://github.com/torvalds/linux/blob/v4.18-rc4/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c#L4829

(According to the bug line references)

Created attachment 140613 [details] [review]
Patch 1/2

Created attachment 140614 [details] [review]
Patch 2/2

Thanks for filing the ticket Patrik, can you please give the attached two patches a shot? I cp'ed them over 4.18-rc3 and they seem to fix it for me.

That's amazing! I'll try it out in a few hours! Thanks!

These two were already in rc4 (in fact, the only changes since rc3):

$ git log --oneline v4.18-rc3..v4.18-rc4 drivers/gpu/drm/amd/display/amdgpu_dm
413ff0b94248 drm/amd/display: add a check for display depth validity
a6311be8f062 drm/amd/display: adding ycbcr420 pixel encoding for hdmi

So issue is still present :(

No updates in rc5 looking at "git log v4.18-rc4..v4.18-rc5 drivers/gpu/drm/amd/", but I'll try it out anyway once it's available at http://kernel.ubuntu.com/~kernel-ppa/mainline/v4.18-rc5/

I'm running 4.18-rc4 on Slackware and I seem to have the same problem. My system boots fine, but if I run startx with HDMI connected the system freezes with a black screen and I get the bug in my kernel log.

I can start KDE and then connect HDMI and that seems to work fine. I even get HDMI audio. If I close KDE, I then get the black screen and bug.

My system is a Ryzen 2700x, ASUS Prime x470-Pro motherboard, Radeon RX 470 video card. I have a monitor connected with DisplayPort and an AV receiver connected with HDMI for sound. There is a TV connected to the receiver's output, which is usually switched off.

Interestingly, I'm also using an Onkyo AV receiver. Mine's a TX-NR515AE. If I unplug the receiver, unplug my monitor from DisplayPort and connect the monitor with HDMI, my system starts KDE fine and HDMI audio plays from the monitor's speakers.

I spent some time crashing and rebooting my system to find the combination that didn't work. Turning everything off between attempts and starting with everything turned off:

Leave AV receiver off. Turn on computer. Start KDE. Bug.

Turn on AV receiver. Turn on computer. Start KDE. Bug.

Turn on AV receiver. Turn on TV. Turn on computer. Start KDE. No bug. Monitor and TV both work as expected. HDMI audio works.

Turn on AV receiver. Turn on TV. Turn *off* TV. Turn on computer. Start KDE. No bug. Monitor works as expected. HDMI audio works.

I have a hunch that the AV receiver gets HDMI data from the TV. If the TV hasn't been on, the receiver feeds odd data to the PC and hits this bug. I don't know how to troubleshoot this further.

I also get two warnings in my kernel log on boot before starting KDE that disappear if I unplug the AV receiver. I don't know if they're relevant.


Bug:

[   37.762733] kernel BUG at drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:4829!
[   37.762742] invalid opcode: 0000 [#1] SMP NOPTI
[   37.762746] CPU: 7 PID: 1477 Comm: Xorg Tainted: G        W         4.18.0-rc4 #1
[   37.762747] Hardware name: System manufacturer System Product Name/PRIME X470-PRO, BIOS 4011 04/19/2018
[   37.762804] RIP: 0010:dm_update_crtcs_state+0x458/0x4d0 [amdgpu]
[   37.762805] Code: ff ff 48 85 db 0f 84 d9 fd ff ff 48 c7 44 24 18 00 00 00 00 48 c7 44 24 08 00 00 00 00 48 c7 04 24 00 00 00 00 e9 91 fe ff ff <0f> 0b 48 83 c4 30 b8 ea ff ff ff 5b 5d 41 5c 41 5d 41 5e 41 5f c3 
[   37.762828] RSP: 0018:ffffb04c0083baa0 EFLAGS: 00010246
[   37.762831] RAX: ffff925fca3ea401 RBX: 0000000000000000 RCX: 00000000000002f7
[   37.762832] RDX: 00000000000002f6 RSI: ffff925fdede4160 RDI: ffff925fde806e80
[   37.762834] RBP: ffff925fca3a1880 R08: 0000000000024160 R09: ffffffffc095be2e
[   37.762836] R10: ffffdf2c9028fa00 R11: 00000000f0000080 R12: 0000000000000001
[   37.762837] R13: ffff925fca3ea000 R14: ffff925fca3ecc00 R15: ffff925fc8965000
[   37.762839] FS:  00007fbb6af6fd40(0000) GS:ffff925fdedc0000(0000) knlGS:0000000000000000
[   37.762841] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[   37.762842] CR2: 00007ffc9f29bfa8 CR3: 00000003fa86a000 CR4: 00000000003406e0
[   37.762844] Call Trace:
[   37.762901]  amdgpu_dm_atomic_check+0x1bc/0x3a0 [amdgpu]
[   37.762919]  drm_atomic_check_only+0x360/0x510 [drm]
[   37.762935]  drm_atomic_commit+0x13/0x50 [drm]
[   37.762944]  drm_atomic_helper_set_config+0x75/0x80 [drm_kms_helper]
[   37.762959]  __drm_mode_set_config_internal+0x67/0x120 [drm]
[   37.762974]  drm_mode_setcrtc+0x412/0x610 [drm]
[   37.762988]  ? drm_mode_getcrtc+0x180/0x180 [drm]
[   37.763001]  drm_ioctl_kernel+0xa1/0xf0 [drm]
[   37.763014]  drm_ioctl+0x1fc/0x390 [drm]
[   37.763028]  ? drm_mode_getcrtc+0x180/0x180 [drm]
[   37.763066]  amdgpu_drm_ioctl+0x49/0x80 [amdgpu]
[   37.763071]  do_vfs_ioctl+0xa4/0x620
[   37.763075]  ? __x64_sys_futex+0x143/0x180
[   37.763078]  ksys_ioctl+0x60/0x90
[   37.763080]  __x64_sys_ioctl+0x16/0x20
[   37.763084]  do_syscall_64+0x55/0x100
[   37.763088]  entry_SYSCALL_64_after_hwframe+0x44/0xa9
[   37.763091] RIP: 0033:0x7fbb68da2297
[   37.763092] Code: b3 66 90 48 8b 05 f1 1b 2d 00 64 c7 00 26 00 00 00 48 c7 c0 ff ff ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 b8 10 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d c1 1b 2d 00 f7 d8 64 89 01 48 
[   37.763114] RSP: 002b:00007fffe459de58 EFLAGS: 00003246 ORIG_RAX: 0000000000000010
[   37.763116] RAX: ffffffffffffffda RBX: 00007fffe459de90 RCX: 00007fbb68da2297
[   37.763117] RDX: 00007fffe459de90 RSI: 00000000c06864a2 RDI: 0000000000000016
[   37.763119] RBP: 00007fffe459de90 R08: 0000000000000000 R09: 00000000028314f0
[   37.763120] R10: 00007fffe459df50 R11: 0000000000003246 R12: 00000000c06864a2
[   37.763122] R13: 0000000000000016 R14: 0000000000000000 R15: 00000000028314f0
[   37.763124] Modules linked in: ipv6 cfg80211 8021q garp mrp stp llc nls_iso8859_1 nls_cp437 vfat fat fuse joydev hid_generic usbhid hid amdkfd amd_iommu_v2 snd_hda_codec_realtek snd_hda_codec_generic snd_hda_codec_hdmi amdgpu chash snd_hda_intel gpu_sched ttm eeepc_wmi snd_hda_codec drm_kms_helper asus_wmi snd_hda_core kvm_amd sparse_keymap snd_hwdep igb rfkill drm kvm snd_pcm i2c_dev video wmi_bmof mxm_wmi evdev agpgart irqbypass fb_sys_fops dca efi_pstore snd_timer syscopyarea xhci_pci sysfillrect crct10dif_pclmul i2c_piix4 i2c_algo_bit sysimgblt crc32_pclmul snd k10temp crc32c_intel ghash_clmulni_intel efivars i2c_core hwmon soundcore ccp xhci_hcd gpio_amdpt gpio_generic wmi button acpi_cpufreq loop ext4 mbcache jbd2
[   37.763169] ---[ end trace 1fcb5eff24c7c5a4 ]---
[   37.763223] RIP: 0010:dm_update_crtcs_state+0x458/0x4d0 [amdgpu]
[   37.763224] Code: ff ff 48 85 db 0f 84 d9 fd ff ff 48 c7 44 24 18 00 00 00 00 48 c7 44 24 08 00 00 00 00 48 c7 04 24 00 00 00 00 e9 91 fe ff ff <0f> 0b 48 83 c4 30 b8 ea ff ff ff 5b 5d 41 5c 41 5d 41 5e 41 5f c3 
[   37.763246] RSP: 0018:ffffb04c0083baa0 EFLAGS: 00010246
[   37.763248] RAX: ffff925fca3ea401 RBX: 0000000000000000 RCX: 00000000000002f7
[   37.763249] RDX: 00000000000002f6 RSI: ffff925fdede4160 RDI: ffff925fde806e80
[   37.763251] RBP: ffff925fca3a1880 R08: 0000000000024160 R09: ffffffffc095be2e
[   37.763252] R10: ffffdf2c9028fa00 R11: 00000000f0000080 R12: 0000000000000001
[   37.763253] R13: ffff925fca3ea000 R14: ffff925fca3ecc00 R15: ffff925fc8965000
[   37.763255] FS:  00007fbb6af6fd40(0000) GS:ffff925fdedc0000(0000) knlGS:0000000000000000
[   37.763257] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[   37.763258] CR2: 00007ffc9f29bfa8 CR3: 00000003fa86a000 CR4: 00000000003406e0



Warnings:

[    9.711692] [drm] Initialized amdgpu 3.26.0 20150101 for 0000:09:00.0 on minor 0
[    9.764335] WARNING: CPU: 1 PID: 912 at drivers/gpu/drm/amd/amdgpu/../display/dc/gpio/gpio_base.c:64 dal_gpio_open_ex+0xc/0x30 [amdgpu]
[    9.764403] Modules linked in: amdkfd amd_iommu_v2 snd_hda_codec_realtek snd_hda_codec_generic snd_hda_codec_hdmi amdgpu chash snd_hda_intel gpu_sched ttm eeepc_wmi snd_hda_codec drm_kms_helper asus_wmi snd_hda_core kvm_amd sparse_keymap snd_hwdep igb rfkill drm kvm snd_pcm i2c_dev video wmi_bmof mxm_wmi evdev agpgart irqbypass fb_sys_fops dca efi_pstore snd_timer syscopyarea xhci_pci sysfillrect crct10dif_pclmul i2c_piix4 i2c_algo_bit sysimgblt crc32_pclmul snd k10temp crc32c_intel ghash_clmulni_intel efivars i2c_core hwmon soundcore ccp xhci_hcd gpio_amdpt gpio_generic wmi button acpi_cpufreq loop ext4 mbcache jbd2
[    9.764704] CPU: 1 PID: 912 Comm: xcmddc Not tainted 4.18.0-rc4 #1
[    9.764737] Hardware name: System manufacturer System Product Name/PRIME X470-PRO, BIOS 4011 04/19/2018
[    9.764851] RIP: 0010:dal_gpio_open_ex+0xc/0x30 [amdgpu]
[    9.764879] Code: 44 00 00 53 48 89 fb 48 8b 3f e8 0f 4b 8a c8 48 c7 03 00 00 00 00 5b c3 66 0f 1f 44 00 00 0f 1f 44 00 00 48 83 7f 08 00 74 08 <0f> 0b b8 05 00 00 00 c3 89 77 18 8b 57 14 4c 8d 47 08 89 f1 8b 77 
[    9.764998] RSP: 0018:ffffb04c0058fbb0 EFLAGS: 00010282
[    9.765034] RAX: 0000000000000000 RBX: ffff925fccb66a40 RCX: 0000000000000050
[    9.765072] RDX: 0000000000000000 RSI: 0000000000000003 RDI: ffff925fccb66180
[    9.765104] RBP: 0000000000000003 R08: 0000000000000000 R09: 0000000000000000
[    9.765135] R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000000000
[    9.765166] R13: 0000000000000000 R14: 0000000000000000 R15: ffffffffc07c8cd4
[    9.765199] FS:  00007f4739064bc0(0000) GS:ffff925fdec40000(0000) knlGS:0000000000000000
[    9.765234] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[    9.765260] CR2: 00007f47385f3850 CR3: 000000040303c000 CR4: 00000000003406e0
[    9.765294] Call Trace:
[    9.765371]  dal_ddc_open+0x2d/0xe0 [amdgpu]
[    9.765393]  ? vsnprintf+0x380/0x4d0
[    9.765461]  dal_aux_engine_acquire+0x32/0x70 [amdgpu]
[    9.765535]  dal_i2caux_acquire_aux_engine+0x56/0x80 [amdgpu]
[    9.765611]  dal_i2caux_submit_aux_command+0x44/0x1b0 [amdgpu]
[    9.765637]  ? i2cdev_open+0x38/0x90 [i2c_dev]
[    9.765705]  dal_ddc_service_write_dpcd_data+0x65/0xa0 [amdgpu]
[    9.765783]  dm_dp_aux_transfer+0xae/0x110 [amdgpu]
[    9.765811]  drm_dp_i2c_do_msg+0x90/0x290 [drm_kms_helper]
[    9.765836]  ? terminate_walk+0x8a/0x100
[    9.765859]  drm_dp_i2c_xfer+0xc7/0x250 [drm_kms_helper]
[    9.765886]  __i2c_transfer+0x123/0x410 [i2c_core]
[    9.765910]  i2c_transfer+0x55/0xa0 [i2c_core]
[    9.765932]  i2c_transfer_buffer_flags+0x4c/0x70 [i2c_core]
[    9.765958]  i2cdev_write+0x48/0x60 [i2c_dev]
[    9.765979]  __vfs_write+0x36/0x190
[    9.765997]  ? hrtimer_nanosleep+0xc6/0x1c0
[    9.766016]  vfs_write+0xa5/0x1a0
[    9.766033]  ksys_write+0x4f/0xb0
[    9.766050]  do_syscall_64+0x55/0x100
[    9.767432]  entry_SYSCALL_64_after_hwframe+0x44/0xa9
[    9.768801] RIP: 0033:0x7f473861e414
[    9.770171] Code: 89 02 48 c7 c0 ff ff ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 66 90 48 8d 05 51 d5 2d 00 8b 00 85 c0 75 13 b8 01 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 54 f3 c3 66 90 41 54 55 49 89 d4 53 48 89 f5 
[    9.771642] RSP: 002b:00007ffe23011468 EFLAGS: 00000246 ORIG_RAX: 0000000000000001
[    9.773099] RAX: ffffffffffffffda RBX: 0000000000000003 RCX: 00007f473861e414
[    9.774546] RDX: 0000000000000001 RSI: 00007ffe23011470 RDI: 0000000000000003
[    9.776004] RBP: 00007f4738ea0258 R08: 00007ffe23012f24 R09: 00007f47388f7d80
[    9.777526] R10: 0000000000000011 R11: 0000000000000246 R12: 00007ffe23011470
[    9.778980] R13: 00007ffe23011568 R14: 00007ffe23011570 R15: 00007ffe23012f2f
[    9.780435] ---[ end trace 1fcb5eff24c7c5a2 ]---
[    9.781957] WARNING: CPU: 1 PID: 912 at drivers/gpu/drm/amd/amdgpu/../display/dc/gpio/gpio_service.c:488 dal_ddc_open+0x31/0xe0 [amdgpu]
[    9.783459] Modules linked in: amdkfd amd_iommu_v2 snd_hda_codec_realtek snd_hda_codec_generic snd_hda_codec_hdmi amdgpu chash snd_hda_intel gpu_sched ttm eeepc_wmi snd_hda_codec drm_kms_helper asus_wmi snd_hda_core kvm_amd sparse_keymap snd_hwdep igb rfkill drm kvm snd_pcm i2c_dev video wmi_bmof mxm_wmi evdev agpgart irqbypass fb_sys_fops dca efi_pstore snd_timer syscopyarea xhci_pci sysfillrect crct10dif_pclmul i2c_piix4 i2c_algo_bit sysimgblt crc32_pclmul snd k10temp crc32c_intel ghash_clmulni_intel efivars i2c_core hwmon soundcore ccp xhci_hcd gpio_amdpt gpio_generic wmi button acpi_cpufreq loop ext4 mbcache jbd2
[    9.788386] CPU: 1 PID: 912 Comm: xcmddc Tainted: G        W         4.18.0-rc4 #1
[    9.790075] Hardware name: System manufacturer System Product Name/PRIME X470-PRO, BIOS 4011 04/19/2018
[    9.791847] RIP: 0010:dal_ddc_open+0x31/0xe0 [amdgpu]
[    9.793564] Code: 41 89 d4 55 89 f5 53 48 89 fb 48 83 ec 20 48 8b 3f 65 48 8b 04 25 28 00 00 00 48 89 44 24 18 31 c0 e8 23 f6 ff ff 85 c0 74 1f <0f> 0b 48 8b 4c 24 18 65 48 33 0c 25 28 00 00 00 0f 85 89 00 00 00 
[    9.795399] RSP: 0018:ffffb04c0058fbb8 EFLAGS: 00010206
[    9.797201] RAX: 0000000000000005 RBX: ffff925fccb66a40 RCX: 0000000000000050
[    9.799033] RDX: 0000000000000000 RSI: 0000000000000003 RDI: ffff925fccb66180
[    9.800862] RBP: 0000000000000003 R08: 0000000000000000 R09: 0000000000000000
[    9.802697] R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000000000
[    9.804533] R13: 0000000000000000 R14: 0000000000000000 R15: ffffffffc07c8cd4
[    9.806364] FS:  00007f4739064bc0(0000) GS:ffff925fdec40000(0000) knlGS:0000000000000000
[    9.808203] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[    9.810039] CR2: 00007f47385f3850 CR3: 000000040303c000 CR4: 00000000003406e0
[    9.811878] Call Trace:
[    9.813701]  ? vsnprintf+0x380/0x4d0
[    9.815551]  dal_aux_engine_acquire+0x32/0x70 [amdgpu]
[    9.817340]  dal_i2caux_acquire_aux_engine+0x56/0x80 [amdgpu]
[    9.819106]  dal_i2caux_submit_aux_command+0x44/0x1b0 [amdgpu]
[    9.820731]  ? i2cdev_open+0x38/0x90 [i2c_dev]
[    9.822402]  dal_ddc_service_write_dpcd_data+0x65/0xa0 [amdgpu]
[    9.824047]  dm_dp_aux_transfer+0xae/0x110 [amdgpu]
[    9.825652]  drm_dp_i2c_do_msg+0x90/0x290 [drm_kms_helper]
[    9.827188]  ? terminate_walk+0x8a/0x100
[    9.828682]  drm_dp_i2c_xfer+0xc7/0x250 [drm_kms_helper]
[    9.830205]  __i2c_transfer+0x123/0x410 [i2c_core]
[    9.831700]  i2c_transfer+0x55/0xa0 [i2c_core]
[    9.833189]  i2c_transfer_buffer_flags+0x4c/0x70 [i2c_core]
[    9.834723]  i2cdev_write+0x48/0x60 [i2c_dev]
[    9.836239]  __vfs_write+0x36/0x190
[    9.837764]  ? hrtimer_nanosleep+0xc6/0x1c0
[    9.839253]  vfs_write+0xa5/0x1a0
[    9.840722]  ksys_write+0x4f/0xb0
[    9.842213]  do_syscall_64+0x55/0x100
[    9.843678]  entry_SYSCALL_64_after_hwframe+0x44/0xa9
[    9.844491] usb 5-1: New USB device found, idVendor=046d, idProduct=c24a, bcdDevice=77.02
[    9.845143] RIP: 0033:0x7f473861e414
[    9.845143] Code: 89 02 48 c7 
[    9.846845] usb 5-1: New USB device strings: Mfr=1, Product=2, SerialNumber=3
[    9.848334] c0 ff ff ff ff c3 66 2e 0f 1f 
[    9.849953] usb 5-1: Product: Gaming Mouse G600
[    9.851455] 84 00 00 00 00 00 66 90 
[    9.853016] usb 5-1: Manufacturer: Logitech
[    9.854530] 48 8d 05 51 d5 2d 00 
[    9.856156] usb 5-1: SerialNumber: 7F8669D752180017
[    9.857658] 8b 00 85 c0 75 13 b8 01 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 54 f3 c3 66 90 41 54 55 49 89 d4 53 48 89 f5 
[    9.862335] RSP: 002b:00007ffe23011468 EFLAGS: 00000246 ORIG_RAX: 0000000000000001
[    9.863869] RAX: ffffffffffffffda RBX: 0000000000000003 RCX: 00007f473861e414
[    9.865405] RDX: 0000000000000001 RSI: 00007ffe23011470 RDI: 0000000000000003
[    9.866978] RBP: 00007f4738ea0258 R08: 00007ffe23012f24 R09: 00007f47388f7d80
[    9.868528] R10: 0000000000000011 R11: 0000000000000246 R12: 00007ffe23011470
[    9.870124] R13: 00007ffe23011568 R14: 00007ffe23011570 R15: 00007ffe23012f2f
[    9.871681] ---[ end trace 1fcb5eff24c7c5a3 ]---

Interesting, thanks Peter!
I don't quite have the same combos, booting with receiver and TV on still crashes the driver. I'll try some with this as well.

I have now tried rc5 and bug is still present.

Another detail is that after booting and connecting the HDMI, the driver crashes. Subsequent disconnect/connects gives:

 [drm] amdgpu_dm_irq_schedule_work FAILED src 6

Created attachment 140677 [details] [review]
[Patch] BUG_ON debug prints

I'm having trouble reproducing this issue, probably because I don't have access to a newer Onkyo receiver. It seems that's the common factor thus far.

Could you help me gather some debug info? I've attached a patch that dumps some data to dmesg. Once it reproduces, please upload the entire dmesg log.

Created attachment 140678 [details] [review]
[Patch] BUG_ON debug prints

Created attachment 140681 [details]
Dmesg with patch minus freesync

The kernel wouldn't build with that patch. It doesn't seem to recognize the freesync_enable part. Is that in 4.18?

I removed the three Freesync lines from the patch and built 4.18-rc5. I've attached its dmesg output.


Build error:

drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c: In function ‘dm_update_crtcs_state’:
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:4832:29: error: ‘struct dm_crtc_state’ has no member named ‘freesync_enabled’; did you mean ‘crc_enabled’?
          dm_old_crtc_state->freesync_enabled,
                             ^~~~~~~~~~~~~~~~
                             crc_enabled
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:4833:29: error: ‘struct dm_crtc_state’ has no member named ‘freesync_enabled’; did you mean ‘crc_enabled’?
          dm_new_crtc_state->freesync_enabled);
                             ^~~~~~~~~~~~~~~~
                             crc_enabled

Created attachment 140685 [details]
4.18-rc5 dmesg with debug (-freesync)

Could also not build with freesync.

Mine seem to crash a lot faster.

Created attachment 140711 [details] [review]
[PATCH] drm/amd/display: Consider HDMI aspect ratio when comparing streams

(In reply to Patrik Kullman from comment #17)
> Created attachment 140685 [details]
> 4.18-rc5 dmesg with debug (-freesync)
> 
> Could also not build with freesync.
> 
> Mine seem to crash a lot faster.

Ah, I got lazy and did not rebase onto the stable tree, thank you both for fixing it :)

I've attached a new patch, should fix it - given what I can tell from the logs.

Yes this actually fixes the crash and I do get picture on the TV!

Not sure if related but I can't interact with the system/desktop with keyboard or mouse. Either it's a separate input issue (although it works perfectly when connected to a monitor on HDMI) or it's related to the custom kernel build, or there is some issue with the screen update rather than the input devices.

Don't have more time to investigate right now but will keep you posted.

Thanks for the patch!

Nope, the dead input devices does not seem to be connected to the patch, I can draw stuff by starting apps remotely, and connecting a regular monitor makes no difference.

Very weird how the input devices stopped working though, either something weird with my build (make -j8 bindeb-pkg) or some change with input devices (regular USB keyboard and mouse, different USB ports..)

Gonna try the patch on rc3 to see if it's a regression in rc5.

Oh, I guess we can close this issue if the patch will make it to the kernel?
Would it be possible that it could land in 4.18-rc6 ?

Ok so it seems the custom kernel build is at fault, for some reason hid/usbhid are not built(?). Sorry for spamming the issue and thanks a lot for the great work!

Seems fixed to me. I can't reproduce the bug any more on 4.18-rc5 with that patch.

Thanks for the help.

Any idea when this will go upstream?
Anywhere to track it?

I still have the same problem (I think) with a vanilla 4.18.3 kernel with patch applied. The setup is similar too: TV attached to AV receiver connected via HDMI.



kernel BUG at drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:4829!
invalid opcode: 0000 [#1] PREEMPT SMP PTI
CPU: 3 PID: 1075 Comm: X Not tainted 4.18.3 #146
Hardware name: System manufacturer System Product Name/P6T DELUXE V2, BIOS 1108    09/21/2010
RIP: 0010:dm_update_crtcs_state+0x408/0x490
Code: 9a fd ff ff 8b 44 24 08 48 83 c4 30 5b 5d 41 5c 41 5d 41 5e 41 5f c3 48 83 bb 00 0d 00 00 00 0f 85 0a ff ff ff e9 fe fe ff ff <0f> 0b b8 ea ff ff ff e9 d4 fc ff ff 41 8b 4e 60 48 c7 c2 70 08 ec 
RSP: 0018:ffffc90002507a78 EFLAGS: 00010246
RAX: ffff880321259401 RBX: ffff88032cb81000 RCX: 000000000002dc73
RDX: 0000000000000000 RSI: ffff8803332e2dc0 RDI: ffff88032125ec00
RBP: ffff88032b6b4300 R08: 0000000000022dc0 R09: ffffffff816863e5
R10: ffffea000c849600 R11: ffff880332c06e80 R12: 0000000000000000
R13: ffff88032125b000 R14: ffff88032cb8b000 R15: ffff880322731800
FS:  00007f156911c9c0(0000) GS:ffff8803332c0000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007f2e579ff024 CR3: 000000031e3b4000 CR4: 00000000000026e0
Call Trace:
 amdgpu_dm_atomic_check+0x18c/0x3e0
 drm_atomic_check_only+0x335/0x500
 drm_atomic_commit+0xe/0x50
 drm_atomic_helper_set_config+0x7b/0x90
 __drm_mode_set_config_internal+0x62/0x120
 drm_mode_setcrtc+0x40f/0x5e0
 ? amdgpu_cs_wait_ioctl+0xd3/0x150
 ? drm_mode_getcrtc+0x180/0x180
 drm_ioctl_kernel+0x7c/0xe0
 ? try_to_wake_up+0x202/0x3a0
 drm_ioctl+0x2cb/0x380
 ? drm_mode_getcrtc+0x180/0x180
 amdgpu_drm_ioctl+0x44/0x80
 do_vfs_ioctl+0x9f/0x630
 ksys_ioctl+0x35/0x60
 __x64_sys_ioctl+0x11/0x20
 do_syscall_64+0x43/0xf0
 entry_SYSCALL_64_after_hwframe+0x44/0xa9
RIP: 0033:0x7f15668e70e7
Code: 00 00 00 75 0c 48 c7 c0 ff ff ff ff 48 83 c4 18 c3 e8 5d df 01 00 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 00 b8 10 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 71 5d 2c 00 f7 d8 64 89 01 48 
RSP: 002b:00007ffe455bbaa8 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 00007ffe455bbafc RCX: 00007f15668e70e7
RDX: 00007ffe455bbae0 RSI: 00000000c06864a2 RDI: 000000000000000c
RBP: 00007ffe455bbae0 R08: 0000000000000000 R09: 000055b58ec77b70
R10: 00007ffe455bbba0 R11: 0000000000000246 R12: 00000000c06864a2
R13: 000000000000000c R14: 0000000000000000 R15: 000055b58ec77b70
Modules linked in: devlink ebtable_filter ebtables ip6table_filter ip6_tables xt_recent ipt_REJECT nf_reject_ipv4 xt_comment xt_multiport xt_hashlimit xt_addrtype xt_mark ipt_MASQUERADE xt_NFLOG nf_log_ipv4 nf_log_common xt_LOG nf_conntrack_netlink nf_nat_sip nf_nat_irc nf_nat_ftp nf_conntrack_sip nf_conntrack_irc nf_conntrack_ftp xt_conntrack iptable_mangle iptable_nat nf_conntrack_ipv4 nf_defrag_ipv4 nf_nat_ipv4 nf_nat nf_conntrack iptable_raw iptable_filter ip_tables bpfilter tun cfg80211 rfkill 8021q hid_roccat_koneplus hid_roccat hid_roccat_common input_leds led_class hid_steam snd_usb_audio joydev snd_usbmidi_lib snd_rawmidi snd_seq_device snd_hda_codec_analog snd_hda_codec_generic pktcdvd uhci_hcd intel_powerclamp coretemp kvm_intel snd_hda_codec_hdmi kvm irqbypass snd_hda_intel
 crc32c_intel snd_hda_codec pcspkr snd_hwdep snd_hda_core snd_pcm xhci_pci i2c_i801 snd_timer snd xhci_hcd ehci_pci sky2 lpc_ich soundcore ehci_hcd i7core_edac asus_atk0110 button acpi_cpufreq sch_fq_codel
---[ end trace b9ac78ef0a693ba7 ]---
RIP: 0010:dm_update_crtcs_state+0x408/0x490
Code: 9a fd ff ff 8b 44 24 08 48 83 c4 30 5b 5d 41 5c 41 5d 41 5e 41 5f c3 48 83 bb 00 0d 00 00 00 0f 85 0a ff ff ff e9 fe fe ff ff <0f> 0b b8 ea ff ff ff e9 d4 fc ff ff 41 8b 4e 60 48 c7 c2 70 08 ec 
RSP: 0018:ffffc90002507a78 EFLAGS: 00010246
RAX: ffff880321259401 RBX: ffff88032cb81000 RCX: 000000000002dc73
RDX: 0000000000000000 RSI: ffff8803332e2dc0 RDI: ffff88032125ec00
RBP: ffff88032b6b4300 R08: 0000000000022dc0 R09: ffffffff816863e5
R10: ffffea000c849600 R11: ffff880332c06e80 R12: 0000000000000000
R13: ffff88032125b000 R14: ffff88032cb8b000 R15: ffff880322731800
FS:  00007f156911c9c0(0000) GS:ffff8803332c0000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007f2e579ff024 CR3: 000000031e3b4000 CR4: 00000000000026e0

Patch seems to be included in 4.19-rc1, so this can be closed.

Sadly no Reported-by or Tested-by signature :/