Bug 107322 - Add MIME type for Maven
Summary: Add MIME type for Maven
Status: RESOLVED FIXED
Alias: None
Product: shared-mime-info
Classification: Unclassified
Component: freedesktop.org.xml (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Shared Mime Info group
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-07-21 10:55 UTC by Alberto Fanjul Alonso
Modified: 2018-07-25 11:08 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
MIME type info for Maven (5.64 KB, patch)
2018-07-21 11:02 UTC, Alberto Fanjul Alonso
Details | Splinter Review
MIME type info for Maven (5.50 KB, patch)
2018-07-22 05:49 UTC, Alberto Fanjul Alonso
Details | Splinter Review
MIME type info for Maven (5.44 KB, patch)
2018-07-23 05:55 UTC, Alberto Fanjul Alonso
Details | Splinter Review

Description Alberto Fanjul Alonso 2018-07-21 10:55:42 UTC
Maven is a project management tool for java.

Adding it to MIME database will allow IDEs to provide specific syntax highlight, autocomplete and linters
Comment 1 Alberto Fanjul Alonso 2018-07-21 11:02:22 UTC
Created attachment 140754 [details] [review]
MIME type info for Maven

As seen in test files, settings do not have the <project tag, so don't know exactly how to proceed with magic tag here, maybe splitting pom.xml and settings.xml in two MIME type definitions? By pattern, they will be recognized without doubt.
Comment 2 Bastien Nocera 2018-07-21 11:26:12 UTC
(In reply to Alberto Fanjul Alonso from comment #1)
> Created attachment 140754 [details] [review] [review]
> MIME type info for Maven
> 
> As seen in test files, settings do not have the <project tag, so don't know
> exactly how to proceed with magic tag here, maybe splitting pom.xml and
> settings.xml in two MIME type definitions? By pattern, they will be
> recognized without doubt.

It's too generic, I would just remove it.

As for the mime-type and aliases, you need to show where you got those from. We prefer text/x-... for text based file formats, rather than application/x-, so unless application/x-... is already used somewhere else, please use text/x- instead.
Comment 3 Alberto Fanjul Alonso 2018-07-22 05:49:45 UTC
Created attachment 140757 [details] [review]
MIME type info for Maven

suggestions applied
Comment 4 Bastien Nocera 2018-07-22 12:22:48 UTC
(In reply to Alberto Fanjul Alonso from comment #3)
> Created attachment 140757 [details] [review] [review]
> MIME type info for Maven
> 
> suggestions applied

The tests don't pass:

./freedesktop.org.xml:37257: element root-XML: validity error : Element root-XML does not carry attribute localName
    <root-XML namespaceURI="http://maven.apache.org/POM/4.0.0"/>

See the HACKING file for info on how to run the test suite.
Comment 5 Alberto Fanjul Alonso 2018-07-23 05:55:34 UTC
Created attachment 140774 [details] [review]
MIME type info for Maven

Fixed the test suite for maven


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.