https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_4539/fi-cnl-psr/igt@kms_psr@primary_mmap_gtt.html https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_4539/fi-cnl-psr/igt@kms_psr@cursor_plane_move.html https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_4539/fi-cnl-psr/igt@kms_psr@primary_page_flip.html [ 473.103275] [drm:intel_pipe_update_start [i915]] *ERROR* PSR idle timed out, atomic update may fail
With the below patch, this should now be a test assertion failure instead of dmesg-fail drm/i915/psr: Remove wait_for_idle() for PSR2 CI runs show PSR2 does not go to IDLE with selective update enabled on all PSR exit triggers. Specifically, logs indicate the hardware enters "SLEEP Selective Update" and not "IDLE Reset state', like the kernel expects, when vblank interrupts are enabled. This check was added for PSR1 but incorrectly extended to PSR2, remove the check as it breaks tests and prints out misleading error messages. v2: Split out non-code changes (Rodrigo) Cc: Tarun Vyas <tarun.vyas@intel.com> Cc: José Roberto de Souza <jose.souza@intel.com> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> Fixes: c43dbcbbcc8c ("drm/i915/psr: Lockless version of psr_wait_for_idle") Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20180824230844.12428-1-dhinakaran.pandiyan@intel.com
This indeed fixed it. Thanks!
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.