Bug 107409 - [CI][SHARDS] igt@kms_cursor_legacy@2x-nonblocking-modeset-vs-cursor-atomic - fail - Test assertion failure function igt_display_commit_atomic, Failed assertion: ret == 0, Last errno: 16, Device or resource busy
Summary: [CI][SHARDS] igt@kms_cursor_legacy@2x-nonblocking-modeset-vs-cursor-atomic - ...
Status: NEW
Alias: None
Product: DRI
Classification: Unclassified
Component: DRM/Intel (show other bugs)
Version: XOrg git
Hardware: Other All
: low normal
Assignee: Intel GFX Bugs mailing list
QA Contact: Intel GFX Bugs mailing list
URL:
Whiteboard: ReadyForDev
Keywords:
Depends on:
Blocks:
 
Reported: 2018-07-27 13:55 UTC by Martin Peres
Modified: 2019-08-26 08:28 UTC (History)
1 user (show)

See Also:
i915 platform: GLK, KBL
i915 features: display/atomic


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Peres 2018-07-27 13:55:41 UTC
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_4555/shard-glk9/igt@kms_cursor_legacy@2x-nonblocking-modeset-vs-cursor-atomic.html

https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_4554/shard-glk9/igt@kms_cursor_legacy@2x-nonblocking-modeset-vs-cursor-atomic.html

(kms_cursor_legacy:2302) igt_kms-CRITICAL: Test assertion failure function igt_display_commit_atomic, file ../lib/igt_kms.c:3325:
(kms_cursor_legacy:2302) igt_kms-CRITICAL: Failed assertion: ret == 0
(kms_cursor_legacy:2302) igt_kms-CRITICAL: Last errno: 16, Device or resource busy
(kms_cursor_legacy:2302) igt_kms-CRITICAL: error: -16 != 0
Subtest 2x-nonblocking-modeset-vs-cursor-atomic failed.(km
Comment 1 Martin Peres 2018-08-07 11:34:42 UTC
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_4624/shard-glk9/igt@kms_atomic_transition@1x-modeset-transitions-nonblocking-fencing.html

	
(kms_atomic_transition:1240) igt_kms-CRITICAL: Test assertion failure function igt_display_commit_atomic, file ../lib/igt_kms.c:3325:
(kms_atomic_transition:1240) igt_kms-CRITICAL: Failed assertion: ret == 0
(kms_atomic_transition:1240) igt_kms-CRITICAL: Last errno: 16, Device or resource busy
(kms_atomic_transition:1240) igt_kms-CRITICAL: error: -16 != 0
Subtest 1x-modeset-transitions-nonblocking-fencing failed.
Comment 2 Lakshmi 2018-12-10 09:58:09 UTC
Also seen on ICL
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_158/fi-icl-u2/igt@kms_cursor_legacy@2x-nonblocking-modeset-vs-cursor-atomic.html

	
Starting subtest: 2x-nonblocking-modeset-vs-cursor-atomic
(kms_cursor_legacy:1066) igt_kms-CRITICAL: Test assertion failure function igt_display_commit_atomic, file ../lib/igt_kms.c:3395:
(kms_cursor_legacy:1066) igt_kms-CRITICAL: Failed assertion: ret == 0
(kms_cursor_legacy:1066) igt_kms-CRITICAL: Last errno: 16, Device or resource busy
(kms_cursor_legacy:1066) igt_kms-CRITICAL: error: -16 != 0
Subtest 2x-nonblocking-modeset-vs-cursor-atomic failed.
Comment 3 Lakshmi 2019-04-12 11:45:03 UTC
Comments from Maarten:
Impact: cursor on crtc 1 might be lagging when a nonblocking modeset happens on crtc2. However the most common situation is that a modeset is done blockingly, in which case cursor hangs anyway, so low impact.
Comment 4 CI Bug Log 2019-04-12 11:49:18 UTC
A CI Bug Log filter associated to this bug has been updated:

{- GLK ICL: igt@*nonblocking-modeset* - fail - Failed assertion: ret == 0, Last errno: 16, Device or resource busy -}
{+ GLK: igt@*nonblocking-modeset* - fail - Failed assertion: ret == 0, Last errno: 16, Device or resource busy +}

 No new failures caught with the new filter
Comment 5 Martin Peres 2019-04-12 12:03:29 UTC
(In reply to CI Bug Log from comment #4)
> A CI Bug Log filter associated to this bug has been updated:
> 
> {- GLK ICL: igt@*nonblocking-modeset* - fail - Failed assertion: ret == 0,
> Last errno: 16, Device or resource busy -}
> {+ GLK: igt@*nonblocking-modeset* - fail - Failed assertion: ret == 0, Last
> errno: 16, Device or resource busy +}
> 
>  No new failures caught with the new filter

Dropping ICL since it was seen only once, 4 months ago, and the hardware and firmware versions have significantly changed since then.

As for the reproduction rate on GLK, this is only seen on shards, and multiple times per week (on average once every 12-15 runs) except for 2 weeks where it was not seen. The two affected tests are equally impacted, so nothing too interesting here.
Comment 6 Petri Latvala 2019-04-12 12:19:06 UTC
What the test is doing is nonblocking modesets on one crtc and nonblocking page flips on the cursor plane on another crtc. This can happen when we're moving the mouse around the screen and changing the image to react to the mouse context (text selection etc), and at the same time changing the resolution of another screen, hotplugging another monitor, ....

The failure here is getting EBUSY from the atomic commit, meaning the kernel had an earlier update pending.
Comment 7 Martin Peres 2019-04-12 12:23:06 UTC
(In reply to Petri Latvala from comment #6)
> What the test is doing is nonblocking modesets on one crtc and nonblocking
> page flips on the cursor plane on another crtc. This can happen when we're
> moving the mouse around the screen and changing the image to react to the
> mouse context (text selection etc), and at the same time changing the
> resolution of another screen, hotplugging another monitor, ....
> 
> The failure here is getting EBUSY from the atomic commit, meaning the kernel
> had an earlier update pending.

Thanks, based on this and Maarten's assessment, I think we can agree that this is a low priority, especially since this is happening ONLY on GLK which is a low power device usually used only by tablets, IVI systems, ... which do not use a cursor :D

NUCs are the exception, but one does not usually change resolutions in a desktop PC.
Comment 8 CI Bug Log 2019-08-26 08:27:34 UTC
A CI Bug Log filter associated to this bug has been updated:

{- GLK igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic fail - Test assertion failure Last errno: 16, Device or resource busy -}
{+ GLK KBL: igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic fail - Test assertion failure Last errno: 16, Device or resource busy +}

New failures caught by the filter:

  * https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_349/fi-kbl-7500u/igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic.html


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.