Bug 107487 - [intel] [tools] intel gpu tools don't honor -D tools=[]
Summary: [intel] [tools] intel gpu tools don't honor -D tools=[]
Status: RESOLVED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Other (show other bugs)
Version: git
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: mesa-dev
QA Contact: mesa-dev
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-08-04 18:06 UTC by LoneVVolf
Modified: 2018-08-07 10:59 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description LoneVVolf 2018-08-04 18:06:35 UTC
Since https://cgit.freedesktop.org/mesa/mesa/commit/?id=4334196ab325c6a19d618a392cddcc9f03adeb18

intel-gpu-tools builds /usr/bin/intel_dump_gpu & /usr/bin/intel_sanitize_gpu when intel drivers are build.

Even disabling tools completely by using -D tools=[] doesn't stop this.

If this change is intentional, build documentation and options should make very clear intel tools don't use the tools setting and use their own logic to determine  whether building intel tools is needed.
Comment 1 Lionel Landwerlin 2018-08-04 22:56:07 UTC
I guess we might need to revert that patch.
build_by_default doesn't apply to configure_file().
Comment 2 Lionel Landwerlin 2018-08-07 10:59:57 UTC
Should be fixed in :

commit 303e7b39b5df982b0870b2d09d52fbf36ff9a087
Author: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Date:   Tue Aug 7 11:38:59 2018 +0100

    intel: don't build tools without -Dtools=intel


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.