Bug 107617 - [Patch] Fix various memory issues in GfxImageColorMap copy ctor
Summary: [Patch] Fix various memory issues in GfxImageColorMap copy ctor
Status: RESOLVED MOVED
Alias: None
Product: poppler
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: poppler-bugs
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-08-19 07:49 UTC by Volker Krause
Modified: 2018-08-20 21:59 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
[Patch] Fix memory issues in GfxImageColorMap copy ctor (2.15 KB, patch)
2018-08-19 07:49 UTC, Volker Krause 		Details | Splinter Review
View All

Description Volker Krause 2018-08-19 07:49:00 UTC 
Created attachment 141194 [details] [review]
[Patch] Fix memory issues in GfxImageColorMap copy ctor

- byte_lookup and lookup2 could contain uninitialized memory
- lookup2 was not copied at all
- lookup could be copied with the wrong size
Comment 1 Albert Astals Cid 2018-08-20 21:33:43 UTC 
Do you need to use this function?

Otherwise i'd suggest we just remove it, since at least noone in poppler is using it, and it was totally broken so i guess noone else was using it?
Comment 2 GitLab Migration User 2018-08-20 21:59:26 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/poppler/poppler/issues/145.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.