No PSR issues seen in CI across any of devices this was originally reported against.

(In reply to James Ausmus from comment #1)
> No PSR issues seen in CI across any of devices this was originally reported
> against.

I guess you checked the wrong links as it is seen 100% of the time: https://intel-gfx-ci.01.org/tree/drm-tip/drmtip.html and https://intel-gfx-ci.01.org/tree/drm-tip/shards.html

https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5131/shard-skl4/igt@kms_fbcon_fbt@psr-suspend.html

https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5131/shard-skl3/igt@kms_fbcon_fbt@psr.html

Starting subtest: psr
(kms_fbcon_fbt:1106) CRITICAL: Test assertion failure function subtest, file ../tests/kms_fbcon_fbt.c:282:
(kms_fbcon_fbt:1106) CRITICAL: Failed assertion: !feature->wait_until_enabled(drm.debugfs_fd)
Subtest psr failed.

Also on ICL:https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_150/fi-icl-u3/igt@kms_fbcon_fbt@psr-suspend.html

https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_151/fi-icl-u3/igt@kms_fbcon_fbt@psr-suspend.html

https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_152/fi-icl-u3/igt@kms_fbcon_fbt@psr-suspend.html

https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_153/fi-icl-u3/igt@kms_fbcon_fbt@psr-suspend.html

Starting subtest: psr-suspend
(kms_fbcon_fbt:1029) CRITICAL: Test assertion failure function subtest, file ../tests/kms_fbcon_fbt.c:282:
(kms_fbcon_fbt:1029) CRITICAL: Failed assertion: !feature->wait_until_enabled(drm.debugfs_fd)
Subtest psr-suspend failed.

code from: kms_fbcon_fbt.c static void subtest(struct feature *feature, bool suspend)
...
kmstest_unset_all_crtcs(drm.fd, drm.res);
wait_user("Modes unset.");
igt_assert(!feature->wait_until_enabled(drm.debugfs_fd));
...
wait_user("Back to fbcon.");
igt_assert(!feature->wait_until_enabled(drm.debugfs_fd));

So this asserts are expecting that PSR is not enabled when fbcon is active, my understanding is should check if PSR is not active as the cursor blinking will disable PSR1, for PSR2 it could go to PSR2 active and update the cursor with SU.

What do you think DK?

We might(In reply to Jose Roberto de Souza from comment #4)
> code from: kms_fbcon_fbt.c static void subtest(struct feature *feature, bool
> suspend)
> ...
> kmstest_unset_all_crtcs(drm.fd, drm.res);
> wait_user("Modes unset.");
> igt_assert(!feature->wait_until_enabled(drm.debugfs_fd));
> ...
> wait_user("Back to fbcon.");
> igt_assert(!feature->wait_until_enabled(drm.debugfs_fd));
> 
> So this asserts are expecting that PSR is not enabled when fbcon is active,
> my understanding is should check if PSR is not active as the cursor blinking
> will disable PSR1, for PSR2 it could go to PSR2 active and update the cursor
> with SU.
> 
> What do you think DK?

Yes. We'll have to fix this for PSR1 too, since psr_flush() does not disable PSR anymore and the test checks for that.

https://patchwork.freedesktop.org/series/54837/ should fix this

Any update here?

Is this fixed now? It hasn't been seen in over 2 months.

Looks pretty red: https://intel-gfx-ci.01.org/tree/drm-tip/igt@kms_fbcon_fbt@psr.html

Patches fixing it rebased and set to mail list recently but no reviews yet: https://patchwork.freedesktop.org/series/58652/

Fix merged.

Closing this issue.

The CI Bug Log issue associated to this bug has been archived.

New failures matching the above filters will not be associated to this bug anymore.