Bug 107882 - [CI][DRMTIP] igt@kms_fbcon_fbt@psr(-suspend) - fail - Failed assertion: !feature->wait_until_enabled(drm.debugfs_fd)
Summary: [CI][DRMTIP] igt@kms_fbcon_fbt@psr(-suspend) - fail - Failed assertion: !feat...
Status: ASSIGNED
Alias: None
Product: DRI
Classification: Unclassified
Component: DRM/Intel (show other bugs)
Version: XOrg git
Hardware: Other All
: high normal
Assignee: Jose Roberto de Souza
QA Contact: Intel GFX Bugs mailing list
URL:
Whiteboard: ReadyForDev
Keywords:
Depends on:
Blocks:
 
Reported: 2018-09-10 08:35 UTC by Martin Peres
Modified: 2018-12-04 23:01 UTC (History)
4 users (show)

See Also:
i915 platform: ALL
i915 features: display/PSR


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 James Ausmus 2018-10-26 00:22:14 UTC
No PSR issues seen in CI across any of devices this was originally reported against.
Comment 2 Martin Peres 2018-11-13 16:07:00 UTC
(In reply to James Ausmus from comment #1)
> No PSR issues seen in CI across any of devices this was originally reported
> against.

I guess you checked the wrong links as it is seen 100% of the time: https://intel-gfx-ci.01.org/tree/drm-tip/drmtip.html and https://intel-gfx-ci.01.org/tree/drm-tip/shards.html

https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5131/shard-skl4/igt@kms_fbcon_fbt@psr-suspend.html

https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5131/shard-skl3/igt@kms_fbcon_fbt@psr.html

Starting subtest: psr
(kms_fbcon_fbt:1106) CRITICAL: Test assertion failure function subtest, file ../tests/kms_fbcon_fbt.c:282:
(kms_fbcon_fbt:1106) CRITICAL: Failed assertion: !feature->wait_until_enabled(drm.debugfs_fd)
Subtest psr failed.
Comment 3 Martin Peres 2018-12-03 17:08:03 UTC
Also on ICL:https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_150/fi-icl-u3/igt@kms_fbcon_fbt@psr-suspend.html

https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_151/fi-icl-u3/igt@kms_fbcon_fbt@psr-suspend.html

https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_152/fi-icl-u3/igt@kms_fbcon_fbt@psr-suspend.html

https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_153/fi-icl-u3/igt@kms_fbcon_fbt@psr-suspend.html

Starting subtest: psr-suspend
(kms_fbcon_fbt:1029) CRITICAL: Test assertion failure function subtest, file ../tests/kms_fbcon_fbt.c:282:
(kms_fbcon_fbt:1029) CRITICAL: Failed assertion: !feature->wait_until_enabled(drm.debugfs_fd)
Subtest psr-suspend failed.
Comment 4 Jose Roberto de Souza 2018-12-04 02:29:30 UTC
code from: kms_fbcon_fbt.c static void subtest(struct feature *feature, bool suspend)
...
kmstest_unset_all_crtcs(drm.fd, drm.res);
wait_user("Modes unset.");
igt_assert(!feature->wait_until_enabled(drm.debugfs_fd));
...
wait_user("Back to fbcon.");
igt_assert(!feature->wait_until_enabled(drm.debugfs_fd));

So this asserts are expecting that PSR is not enabled when fbcon is active, my understanding is should check if PSR is not active as the cursor blinking will disable PSR1, for PSR2 it could go to PSR2 active and update the cursor with SU.

What do you think DK?
Comment 5 Dhinakaran Pandiyan 2018-12-04 23:01:20 UTC
We might(In reply to Jose Roberto de Souza from comment #4)
> code from: kms_fbcon_fbt.c static void subtest(struct feature *feature, bool
> suspend)
> ...
> kmstest_unset_all_crtcs(drm.fd, drm.res);
> wait_user("Modes unset.");
> igt_assert(!feature->wait_until_enabled(drm.debugfs_fd));
> ...
> wait_user("Back to fbcon.");
> igt_assert(!feature->wait_until_enabled(drm.debugfs_fd));
> 
> So this asserts are expecting that PSR is not enabled when fbcon is active,
> my understanding is should check if PSR is not active as the cursor blinking
> will disable PSR1, for PSR2 it could go to PSR2 active and update the cursor
> with SU.
> 
> What do you think DK?

Yes. We'll have to fix this for PSR1 too, since psr_flush() does not disable PSR anymore and the test checks for that.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.