Bug 1079 - wrong symbolnames in MESA assembler with cygwin
Summary: wrong symbolnames in MESA assembler with cygwin
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Server/Ext/GLX (show other bugs)
Version: git
Hardware: x86 (IA32) Windows (All)
: high normal
Assignee: Xorg Project Team
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-08-14 10:26 UTC by Alexander Gottwald
Modified: 2007-01-23 17:34 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
[FIXED_X11R68x] proposed patch (997 bytes, patch)
2004-08-14 10:29 UTC, Alexander Gottwald
roland.mainz: 6.8-branch+
Details | Splinter Review

Description Alexander Gottwald 2004-08-14 10:26:39 UTC
On windows all symbol names are prepended with an underscore. The wrapper in
Mesa/src/mesa/tnl/t_vtx_x86_gcc.S is missing a test for cygwin.
Comment 1 Alexander Gottwald 2004-08-14 10:29:28 UTC
Created attachment 636 [details] [review]
[FIXED_X11R68x] proposed patch

patch for extras/Mesa/src/mesa/tnl/t_vtx_x86_gcc.S. Can this go directly into
the xorg tree or should that patch first get passed to the mesa guys?
Comment 2 Eric Anholt 2004-09-16 22:21:22 UTC
Committed upstream and merged.
Comment 3 Roland Mainz 2004-11-19 07:29:30 UTC
Comment on attachment 636 [details] [review]
[FIXED_X11R68x] proposed patch

Approved for the X11R6.8.x branch in the 2004-11-17 release-wranglers phone
call.
Please don't commit it yourself, I'll handle that once the CVS service is
available again.
Comment 4 Roland Mainz 2004-12-13 05:43:52 UTC
Comment on attachment 636 [details] [review]
[FIXED_X11R68x] proposed patch

Patch checked-in into X11R6.8.x stable branch:

/cvs/xorg/xc/ChangeLog,v  <--  ChangeLog
new revision: 1.365.2.54; previous revision: 1.365.2.53
cvs commit: Using deprecated info format strings.  Convert your scripts to use
the new argument format and remove '1's from your info file format strings.
/cvs/xorg/xc/extras/Mesa/src/mesa/tnl/t_vtx_x86_gcc.S,v  <--  t_vtx_x86_gcc.S
new revision: 1.1.1.1.4.1; previous revision: 1.1.1.1
cvs commit: Using deprecated info format strings.  Convert your scripts to use
the new argument format and remove '1's from your info file format strings.
Mailing the commit message to xorg-commit@lists.freedesktop.org...


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.