Bug 10823 - osname confusion in configure.ac
Summary: osname confusion in configure.ac
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Server/General (show other bugs)
Version: git
Hardware: Other All
: medium normal
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-05-01 03:48 UTC by Tilman Sauerbeck
Modified: 2007-05-02 08:21 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments
Fix OSNAME value (1.71 KB, patch)
2007-05-01 04:01 UTC, Tilman Sauerbeck 		no flags Details | Splinter Review
View All

Description Tilman Sauerbeck 2007-05-01 03:48:18 UTC 
The OS' name that was used to build the server can be set by --with-osname=foo. If it's not set, "UNKNOWN" is used.

Then came c83772fef7ea0379db9bab1120f064b80b74f377, which doesn't do anything AFAICS, since the default value for with-osname will kick in later anyway.

I think the default value for with-osname should be `uname ...`. If that evaluates to an empty string, it should be set to UNKNOWN.
Comment 1 Tilman Sauerbeck 2007-05-01 03:50:24 UTC 
Alan, you committed c83772 -- objections?
Comment 2 Tilman Sauerbeck 2007-05-01 04:01:13 UTC 
Created attachment 9823 [details] [review]
Fix OSNAME value

Proposed patch.
Comment 3 Alan Coopersmith 2007-05-01 17:48:31 UTC 
I don't remember why it was added that way - probably just parallel development
we didn't notice the conflict when merging in during the original modularization.

Patch looks fine to me.
Comment 4 Tilman Sauerbeck 2007-05-02 08:21:13 UTC 
Alright. Committed in bd0abb2844ef9faf28703e592cfebb886004234c.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.