Bug 108491 - Commit baa38c14 causes output issues on my VEGA with RADV
Summary: Commit baa38c14 causes output issues on my VEGA with RADV
Status: RESOLVED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Drivers/Vulkan/radeon (show other bugs)
Version: git
Hardware: Other All
: medium normal
Assignee: mesa-dev
QA Contact: mesa-dev
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-19 09:23 UTC by Karl
Modified: 2018-10-19 17:53 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
Tomb Raider (968.57 KB, image/jpeg)
2018-10-19 09:23 UTC, Karl
Details
DXVK (1.54 MB, image/jpeg)
2018-10-19 09:23 UTC, Karl
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Karl 2018-10-19 09:23:01 UTC
Created attachment 142089 [details]
Tomb Raider

With commit https://gitlab.freedesktop.org/mesa/mesa/commit/baa38c144f6ab544bccabff3739631bab33e4cd7 the frame outbut is glitched on my VEGA56
Comment 1 Karl 2018-10-19 09:23:45 UTC
Created attachment 142090 [details]
DXVK
Comment 2 Andre Heider 2018-10-19 09:35:47 UTC
Same here with wine/dxvk/radv on tonga.

The fps seems unaffected, but it looks like every n'th displayed frame is an older one.

Reverting the commit on master fixes the issue.
Comment 3 Bas Nieuwenhuizen 2018-10-19 09:37:01 UTC
Are any of you using a different GPU to display vs running the game? (e.g. prime)
Comment 4 Andre Heider 2018-10-19 09:42:40 UTC
Not here, just one gpu and one display
Comment 5 Bas Nieuwenhuizen 2018-10-19 09:56:24 UTC
Okay it looks like this fails for radv, because the wsi gets initialized before the PCI bus info.

This should be fixed by 

https://lists.freedesktop.org/archives/mesa-dev/2018-October/207311.html

(sorry, no patchwork link as patchwork seems to be down for me)
Comment 6 Bas Nieuwenhuizen 2018-10-19 12:45:36 UTC
Fixed:

commit 68c7833540fabea3d7af8eb470522e6403354e20
Author: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Date:   Fri Oct 19 11:51:47 2018 +0200

    radv: Fix WSI & PCI bus info initialization order.
    
    Trying to access the bus info before it is initialized is not going
    to work.
    
    Fixes: baa38c144f6 "vulkan/wsi: Use VK_EXT_pci_bus_info for DRM fd matching"
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108491
    Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
    Tested-by: Andre Heider <a.heider@gmail.com>
Comment 7 Karl 2018-10-19 17:53:56 UTC
Thanks for the quick fix


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.