Bug 108523 - [CI][DRMTIP] igt@kms_vblank@pipe-b-ts-continuation-idle - dmesg-warn - WARN_ON((val & icl_dpclka_cfgcr0_clk_off(dev_priv, port)) == 0)
Summary: [CI][DRMTIP] igt@kms_vblank@pipe-b-ts-continuation-idle - dmesg-warn - WARN_O...
Status: CLOSED FIXED
Alias: None
Product: DRI
Classification: Unclassified
Component: DRM/Intel (show other bugs)
Version: XOrg git
Hardware: Other All
: medium normal
Assignee: Intel GFX Bugs mailing list
QA Contact: Intel GFX Bugs mailing list
URL:
Whiteboard: ReadyForDev
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-23 07:52 UTC by Martin Peres
Modified: 2018-12-07 11:47 UTC (History)
1 user (show)

See Also:
i915 platform: ICL
i915 features: display/Other


Attachments

Description Martin Peres 2018-10-23 07:52:52 UTC
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_131/fi-icl-u2/igt@kms_vblank@pipe-b-ts-continuation-idle.html

<4> [28.401218] ------------[ cut here ]------------
<4> [28.401223] WARN_ON((val & icl_dpclka_cfgcr0_clk_off(dev_priv, port)) == 0)
<4> [28.401278] WARNING: CPU: 2 PID: 935 at drivers/gpu/drm/i915/intel_ddi.c:2781 icl_map_plls_to_ports+0x1e6/0x220 [i915]
<4> [28.401283] Modules linked in: snd_hda_codec_hdmi snd_hda_codec_realtek snd_hda_codec_generic i915 snd_hda_intel x86_pkg_temp_thermal coretemp crct10dif_pclmul crc32_pclmul snd_hda_codec ghash_clmulni_intel snd_hwdep snd_hda_core e1000e snd_pcm cdc_ether btusb usbnet btrtl btbcm btintel mii bluetooth ecdh_generic prime_numbers
<4> [28.401356] CPU: 2 PID: 935 Comm: kms_vblank Tainted: G        W         4.19.0-rc8-g53197f72a64b-drmtip_131+ #1
<4> [28.401360] Hardware name: Intel Corporation Ice Lake Client Platform/IceLake U DDR4 SODIMM PD RVP TLC, BIOS ICLSFWR1.R00.2352.A01.1808281852 08/28/2018
<4> [28.401397] RIP: 0010:icl_map_plls_to_ports+0x1e6/0x220 [i915]
<4> [28.401403] Code: ff ff d3 c0 41 21 c4 eb 81 89 ee 48 89 df e8 a1 58 fd ff 84 c0 75 1a 48 c7 c6 90 2a 60 c0 48 c7 c7 45 a0 5d c0 e8 fa 77 b3 cd <0f> 0b e9 d1 fe ff ff 89 ee 48 89 df e8 99 58 fd ff 83 f8 03 ba 00
<4> [28.401408] RSP: 0018:ffffb0150097b978 EFLAGS: 00010286
<4> [28.401414] RAX: 0000000000000000 RBX: ffff8e34d66d0000 RCX: 0000000000000001
<4> [28.401417] RDX: 0000000080000001 RSI: ffffffff8f080d10 RDI: 00000000ffffffff
<4> [28.401420] RBP: 0000000000000000 R08: 00000000faad82a5 R09: 0000000000000000
<4> [28.401423] R10: 0000000000000000 R11: 0000000000000000 R12: 0000000001e17800
<4> [28.401426] R13: ffff8e34d073ae98 R14: ffff8e34e6e1c138 R15: 0000000000000000
<4> [28.401430] FS:  00007fb3874f4980(0000) GS:ffff8e34f0700000(0000) knlGS:0000000000000000
<4> [28.401434] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
<4> [28.401438] CR2: 00007fb21d7c0788 CR3: 0000000497be6005 CR4: 0000000000760ee0
<4> [28.401442] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
<4> [28.401446] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
<4> [28.401450] PKRU: 55555554
<4> [28.401453] Call Trace:
<4> [28.401501]  haswell_crtc_enable+0x44a/0x7f0 [i915]
<4> [28.401556]  intel_update_crtc+0x57/0x2a0 [i915]
<4> [28.401604]  skl_update_crtcs+0x288/0x2e0 [i915]
<4> [28.401655]  intel_atomic_commit_tail+0x1ca/0xd20 [i915]
<4> [28.401704]  intel_atomic_commit+0x240/0x320 [i915]
<4> [28.401714]  drm_atomic_helper_set_config+0x7b/0x90
<4> [28.401721]  drm_mode_setcrtc+0x195/0x6b0
<4> [28.401746]  ? drm_mode_getcrtc+0x180/0x180
<4> [28.401751]  drm_ioctl_kernel+0x81/0xf0
<4> [28.401759]  drm_ioctl+0x2e6/0x3a0
<4> [28.401767]  ? drm_mode_getcrtc+0x180/0x180
<4> [28.401778]  ? lockdep_hardirqs_on+0xe0/0x1b0
<4> [28.401785]  do_vfs_ioctl+0xa0/0x6d0
<4> [28.401790]  ? __task_pid_nr_ns+0xb9/0x1f0
<4> [28.401796]  ksys_ioctl+0x35/0x60
<4> [28.401801]  __x64_sys_ioctl+0x11/0x20
<4> [28.401805]  do_syscall_64+0x55/0x190
<4> [28.401809]  entry_SYSCALL_64_after_hwframe+0x49/0xbe
<4> [28.401812] RIP: 0033:0x7fb3867805d7
<4> [28.401815] Code: b3 66 90 48 8b 05 b1 48 2d 00 64 c7 00 26 00 00 00 48 c7 c0 ff ff ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 b8 10 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 81 48 2d 00 f7 d8 64 89 01 48
<4> [28.401817] RSP: 002b:00007fff31852438 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
<4> [28.401821] RAX: ffffffffffffffda RBX: 00007fff31852470 RCX: 00007fb3867805d7
<4> [28.401823] RDX: 00007fff31852470 RSI: 00000000c06864a2 RDI: 0000000000000005
<4> [28.401825] RBP: 00007fff31852470 R08: 0000000000000000 R09: 000056021b45c4f8
<4> [28.401827] R10: 000056021b45c518 R11: 0000000000000246 R12: 00000000c06864a2
<4> [28.401829] R13: 0000000000000005 R14: 0000000000000000 R15: 0000000000000000
<4> [28.401838] irq event stamp: 123376
<4> [28.401842] hardirqs last  enabled at (123375): [<ffffffff8e0fc05a>] console_unlock+0x3fa/0x5f0
<4> [28.401844] hardirqs last disabled at (123376): [<ffffffff8e001930>] trace_hardirqs_off_thunk+0x1a/0x1c
<4> [28.401847] softirqs last  enabled at (123352): [<ffffffff8ec0031d>] __do_softirq+0x31d/0x483
<4> [28.401850] softirqs last disabled at (123335): [<ffffffff8e090279>] irq_exit+0xa9/0xc0
<4> [28.401886] WARNING: CPU: 2 PID: 935 at drivers/gpu/drm/i915/intel_ddi.c:2781 icl_map_plls_to_ports+0x1e6/0x220 [i915]
<4> [28.401889] ---[ end trace 34a5131bb20c2f41 ]---
Comment 1 Martin Peres 2018-10-23 08:12:04 UTC
Bumping the priority to high because it has the potential to affect any modeset (acked by Danvet). I will bump it again if necessary.
Comment 2 Jani Saarinen 2018-10-23 13:57:33 UTC
Need to see with newer than BIOS ICLSFWR1.R00.2352
Comment 3 Jani Saarinen 2018-12-07 09:27:21 UTC
Not seen lately: last time 1 month, 2 weeks / 1155 runs ago
Comment 4 Jani Saarinen 2018-12-07 09:27:47 UTC
Closing.
Comment 5 Martin Peres 2018-12-07 09:44:17 UTC
(In reply to Jani Saarinen from comment #4)
> Closing.

The time it was no seen for is irrelevant without knowing the reproduction rate. Right now, we have one occurrence, in a drmtip run. There has been only 25 runs after this, so it should definitely remain open.
Comment 6 Jani Saarinen 2018-12-07 09:57:26 UTC
This also passes on shards today, and BIOS also was updated.
Comment 7 Martin Peres 2018-12-07 10:10:45 UTC
(In reply to Jani Saarinen from comment #6)
> This also passes on shards today, and BIOS also was updated.

Shards is a fair point. But we got at best 200 runs out of them, and it also "passes" on the same machine on the drmtip_ runs... Does not mean it is fixed though!

Right now, we could have a bug with a reproduction rate of 1%. It's ok to drop the priority (just did it), but it does not warrant closing it...

Please at least evaluate how bad this WARN is, and if it really is not too impactful for our users, then we can ignore the bug again for a couple more month and close it.
Comment 8 Imre Deak 2018-12-07 11:25:00 UTC
(In reply to Martin Peres from comment #7)
> (In reply to Jani Saarinen from comment #6)
> > This also passes on shards today, and BIOS also was updated.
> 
> Shards is a fair point. But we got at best 200 runs out of them, and it also
> "passes" on the same machine on the drmtip_ runs... Does not mean it is
> fixed though!
> 
> Right now, we could have a bug with a reproduction rate of 1%. It's ok to
> drop the priority (just did it), but it does not warrant closing it...

This should be fixed by
commit 70332ac539c5c5dffede580fe8986dcfc0751d55
Author: Imre Deak <imre.deak@intel.com>
Date:   Thu Nov 1 16:04:27 2018 +0200

    drm/i915/icl+: Sanitize port to PLL mapping

based on that the bug can be closed.


> 
> Please at least evaluate how bad this WARN is, and if it really is not too
> impactful for our users, then we can ignore the bug again for a couple more
> month and close it.
Comment 9 Martin Peres 2018-12-07 11:47:06 UTC
(In reply to Imre Deak from comment #8)
> (In reply to Martin Peres from comment #7)
> > (In reply to Jani Saarinen from comment #6)
> > > This also passes on shards today, and BIOS also was updated.
> > 
> > Shards is a fair point. But we got at best 200 runs out of them, and it also
> > "passes" on the same machine on the drmtip_ runs... Does not mean it is
> > fixed though!
> > 
> > Right now, we could have a bug with a reproduction rate of 1%. It's ok to
> > drop the priority (just did it), but it does not warrant closing it...
> 
> This should be fixed by
> commit 70332ac539c5c5dffede580fe8986dcfc0751d55
> Author: Imre Deak <imre.deak@intel.com>
> Date:   Thu Nov 1 16:04:27 2018 +0200
> 
>     drm/i915/icl+: Sanitize port to PLL mapping
> 
> based on that the bug can be closed.

Thanks!


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.