Bug 108544 - logic error in file configure.ac
Summary: logic error in file configure.ac
Status: RESOLVED NOTABUG
Alias: None
Product: Mesa
Classification: Unclassified
Component: Other (show other bugs)
Version: 18.1
Hardware: ARM Linux (All)
: medium normal
Assignee: mesa-dev
QA Contact: mesa-dev
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-25 02:00 UTC by Zhaowei Yuan
Modified: 2018-10-26 06:13 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description Zhaowei Yuan 2018-10-25 02:00:40 UTC
Hi,

Following codes can be found from file configure.ac:

    drm)
        test "x$enable_gbm" = "xno" &&
                AC_MSG_ERROR([EGL platform drm needs gbm])
        DEFINES="$DEFINES -DHAVE_DRM_PLATFORM"
        ;;

It doesn't make sense, if enable_gbm is "no", then should output the error message and stop auto-configuring

So, it seems it should be modified as:
    drm)
        if test "x$enable_gbm" = "xno"; then
                AC_MSG_ERROR([EGL platform drm needs gbm])
        fi
        DEFINES="$DEFINES -DHAVE_DRM_PLATFORM"
        ;;

If I'm right, I'd like to commit a patch to fix it

Thanks


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.