Generated ICD (radeon_icd.x86_64.json) looks like this for me (Mesa master):

    "ICD": {
            "api_version": "1.1.70",
            ...

Why do you think it is wrong?

We hardcode it because every version bump we need to see if we have implemented the non-extension API changes+bugfixes in the driver, and apparently the last time we did that we did so for up to 1.1.70.

I still don't understand the reasoning. The version referenced here https://gitlab.freedesktop.org/mesa/mesa/commit/13fd4e601c80b85317feac894c52bd24e4f98c09 for instance is different (1.1.88).

By non-extension you mean just the icd loader?

This is not a bug. We should be able to bump the patch version but that requires to look at the changelog since 1.1.70.

(In reply to Samuel Pitoiset from comment #4)
> This is not a bug. We should be able to bump the patch version but that
> requires to look at the changelog since 1.1.70.

Do you mean it's a review issue, i.e. someone needs to go over it and confirm that all needed features are supported?

Yes, exactly.

For those following this, reported API version should be now at 1.1.90:

https://gitlab.freedesktop.org/mesa/mesa/commit/2ac6d55f38c1665a16d8d02675df2e3a858a7fec

@Samuel Pitoiset Still reports 1.1.70, this function wasn't updated.

line 292 of rad_extensions.py:

uint32_t
radv_physical_device_api_version(struct radv_physical_device *dev)
{
    if (!ANDROID && dev->rad_info.has_syncobj_wait_for_submit)
        return VK_MAKE_VERSION(1, 1, 70);
    return VK_MAKE_VERSION(1, 0, 68);
}
""")