Created attachment 142380 [details]
SSH public key
I would like to request commit access to drm-intel, I have being contributing to it in the past months with patches and reviews and I fill the requirements and I follow the code of conduct.
Created attachment 142381 [details]
GPG pub key
Acked-by: Rodrigo Vivi <firstname.lastname@example.org>
Account created, you can now push to ssh://git.freedesktop.org with dim, and your username is jose.souza. Please double-check you use the correct username when you run SSH. Can you please also create a GitLab user called jose.souza?
And thanks Daniel, I already have a gitlab account with commit rights to IGT, username: zehortigoza
First of all, I'm pretty sure the instructions called for Cc:ing all the maintainers in the request. At least I was not receiving any mails about this.
And secondly, we should probably agree on a reasonable period of time (considering time zone differences) after the request is made to allow discussion on the topic before the commit rights are added.
I think is second occurance like this, so probably needs fixing.
I followed this instructions:
And it only says to ping a maintainer if the request gets stuck.
Right, seems to have fallen through the cracks when the document was added. We'll discuss this and amend the document.
José, zero complaints about what you did here, and zero complaints about you being added as a committer. This is all about the process and us.
"Maintainer acks are required to confirm commit rights." was meant to imply all maintainers need to ack, or at the very least need advance notice about each committer being added. Again, I would have acked José just the same, I just don't want to learn about new committers by looking at git logs.
This is not how I read this and how I understood from our discussions.
If ack from *all* maintainers are needed please change the documentation to make that explicit. Although I also don't agree with this. The rest of rules and requirements are very well written so I would ack and grant access to anyone who meets the criteria.
We cannot be subjective here and ack or nack according to maintainers feelings. If one maintainer checked the status and acked than it should be trusted.