Bug 10877 - xcb-atom gperf m4 madness is buggy
Summary: xcb-atom gperf m4 madness is buggy
Status: RESOLVED FIXED
Alias: None
Product: XCB
Classification: Unclassified
Component: Utils (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Jamey Sharp
QA Contact:
URL:
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2007-05-06 13:31 UTC by Tilman Sauerbeck
Modified: 2007-05-12 18:56 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
Patch that fixes the bug (360 bytes, patch)
2007-05-06 13:32 UTC, Tilman Sauerbeck 		Details | Splinter Review
git commit (571 bytes, patch)
2007-05-06 13:36 UTC, Tilman Sauerbeck 		Details | Splinter Review
Show Obsolete (1) View All

Description Tilman Sauerbeck 2007-05-06 13:31:43 UTC 
When the keyword list is emitted, COUNT isn't re-initialized to zero, which causes wrong values to be written to the hash table.
Comment 1 Tilman Sauerbeck 2007-05-06 13:32:19 UTC 
Created attachment 9890 [details] [review]
Patch that fixes the bug
Comment 2 Tilman Sauerbeck 2007-05-06 13:36:31 UTC 
Created attachment 9891 [details] [review]
git commit

I guess I should provide a full git commit, here it is.
Comment 3 Jamey Sharp 2007-05-12 18:56:09 UTC 
Wow. That was a dumb bug and a clear fix, which I've pushed. Thanks!

For what it's worth, your second attachment still wasn't a commit I could apply with git-am; you want git-format-patch for that.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.