Bug 108865 - xdg-screensaver: Support xss-lock
Summary: xdg-screensaver: Support xss-lock
Alias: None
Product: Portland
Classification: Unclassified
Component: xdg-utils (show other bugs)
Version: unspecified
Hardware: All All
: medium normal
Assignee: Portland Bugs
QA Contact:
Keywords: patch
Depends on:
Reported: 2018-11-26 12:40 UTC by tpikonen
Modified: 2019-02-16 13:40 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Patch to support xss-lock in xdg-screensaver. (925 bytes, patch)
2018-11-26 12:40 UTC, tpikonen
Details | Splinter Review

Description tpikonen 2018-11-26 12:40:24 UTC
Created attachment 142613 [details] [review]
Patch to support xss-lock in xdg-screensaver.

The attached patch adds support for xss-lock to xdg-screensaver.

xss-lock runs a user specified locker in response to X server screen saver events (also some systemd events).

xss-lock would otherwise work fine with the 'screensaver_xserver' code in current xdg-screensaver, but there is no support for the 'lock' subcommand in screensaver_xserver, so some power managers (at least xfce4-power-manager) fail to lock the screen when suspending. Also, the desktop environment detection code could cause xdg-screensaver to use a code path for some other screen saver than screensaver_xserver, while xss-lock is running.

This patch detects a running xss-lock program and runs the appropriate actions, that is, it runs screensaver_xserver and replaces the 'lock' subcommand with 'activate'.
Comment 1 Rex Dieter 2018-11-26 19:33:59 UTC
Thanks for the patch, I'll try to review it when I'm able.
Comment 2 GitLab Migration User 2019-02-16 13:40:47 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/xdg/xdg-utils/issues/139.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.