Bug 109097 - [CI][SHARDS] igt@debugfs_test@read_all_entries_display_on - incomplete - Reading file "i915_dsc_fec_support"
Summary: [CI][SHARDS] igt@debugfs_test@read_all_entries_display_on - incomplete - Read...
Status: CLOSED FIXED
Alias: None
Product: DRI
Classification: Unclassified
Component: DRM/Intel (show other bugs)
Version: XOrg git
Hardware: Other All
: high normal
Assignee: Manasi
QA Contact: Intel GFX Bugs mailing list
URL:
Whiteboard: ReadyForDev
Keywords:
Depends on:
Blocks:
 
Reported: 2018-12-19 09:48 UTC by Martin Peres
Modified: 2018-12-28 08:26 UTC (History)
2 users (show)

See Also:
i915 platform: ICL
i915 features: display/Other


Attachments

Description Martin Peres 2018-12-19 09:48:59 UTC
https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4750/shard-iclb2/igt@debugfs_test@read_all_entries_display_on.html

<7> [1872.098038] [IGT] Reading file "i915_dsc_fec_support"
<7> [1874.949095] [drm:edp_panel_vdd_off_sync [i915]] Turning eDP port A VDD off
<7> [1874.949268] [drm:edp_panel_vdd_off_sync [i915]] PP_STATUS: 0x80000008 PP_CONTROL: 0x00000067
<7> [1874.949305] [drm:intel_power_well_disable [i915]] disabling DC off
<7> [1874.949345] [drm:skl_enable_dc6 [i915]] Enabling DC6
<7> [1874.949381] [drm:gen9_set_dc_state [i915]] Setting DC state from 00 to 02
Comment 1 Jani Saarinen 2018-12-19 11:28:51 UTC
Patches got merged on CI_DRM_5321
Comment 2 James Ausmus 2018-12-19 15:21:57 UTC
Wonder if it's a locking issue?

Maybe also related: http://gfx-ci.fi.intel.com/tree/drm-tip/CI_DRM_5332/shard-iclb4/igt@i915_suspend@debugfs-reader.html


<6> [374.267844] Freezing user space processes ... 
<7> [376.166282] [drm:edp_panel_vdd_off_sync [i915]] Turning eDP port A VDD off
<7> [376.166429] [drm:edp_panel_vdd_off_sync [i915]] PP_STATUS: 0x80000008 PP_CONTROL: 0x00000067
<7> [376.166455] [drm:intel_power_well_disable [i915]] disabling DC off
<7> [376.166483] [drm:skl_enable_dc6 [i915]] Enabling DC6
<7> [376.166507] [drm:gen9_set_dc_state [i915]] Setting DC state from 00 to 02
<3> [394.273585] Freezing of tasks failed after 20.005 seconds (1 tasks refusing to freeze, wq_busy=0):
<6> [394.273668] cat             R  running task    13688  1183   1182 0x00000004
<4> [394.273684] Call Trace:
<4> [394.273691]  ? trace_hardirqs_on_thunk+0x1a/0x1c
<4> [394.273695]  ? lockdep_hardirqs_on+0xe0/0x1b0
<4> [394.273698]  ? trace_hardirqs_on_thunk+0x1a/0x1c
<4> [394.273705]  ? retint_kernel+0x2d/0x2d
<4> [394.273712]  ? __lock_is_held+0x6b/0xb0
<4> [394.273720]  ? ___might_sleep+0x18c/0x250
<4> [394.273726]  ? __ww_mutex_lock.constprop.6+0x56/0xfd0
<4> [394.273729]  ? trace_hardirqs_on_thunk+0x1a/0x1c
<4> [394.273733]  ? __lock_is_held+0x6b/0xb0
<4> [394.273743]  ? ww_mutex_lock_interruptible+0x39/0xa0
<4> [394.273747]  ? ww_mutex_lock_interruptible+0x39/0xa0
<4> [394.273751]  ? drm_modeset_lock+0x3b/0x110
<4> [394.273784]  ? i915_dsc_fec_support_show+0x97/0x1e0 [i915]
<4> [394.273796]  ? seq_read+0xdb/0x3c0
<4> [394.273803]  ? full_proxy_read+0x52/0x90
<4> [394.273809]  ? __vfs_read+0x31/0x170
<4> [394.273815]  ? __se_sys_newfstat+0x3c/0x60
<4> [394.273820]  ? vfs_read+0x9e/0x140
<4> [394.273825]  ? ksys_read+0x50/0xc0
<4> [394.273830]  ? do_syscall_64+0x55/0x190
<4> [394.273834]  ? entry_SYSCALL_64_after_hwframe+0x49/0xbe
<6> [394.273845] OOM killer enabled.
<6> [394.273847] Restarting tasks ... done.
<6> [394.287078] PM: suspend exit
<6> [394.298682] [IGT] i915_suspend: exiting, ret=99
Comment 3 Martin Peres 2018-12-19 15:27:47 UTC
(In reply to James Ausmus from comment #2)
> Wonder if it's a locking issue?
> 

You are not the only one to think so: <ickle> just a mutex deadlock in i915_dsc_fec_support_show
Comment 4 Manasi 2018-12-19 23:13:21 UTC
Yes, working on it, will submit a fixes patch by EOD
Comment 5 Chris Wilson 2018-12-20 08:05:03 UTC
commit 6afe8925a297a0458248e5e8b13dab91e782337e (HEAD -> drm-intel-next-queued, drm-intel/drm-intel-next-queued)
Author: Manasi Navare <manasi.d.navare@intel.com>
Date:   Wed Dec 19 15:51:20 2018 -0800

    drm/i915/dsc: Fix the deadlock in dsc debugfs node
    
    The DSC debugfs node causes a possible deadlock situation. This patch
    resets the try_again at the beginning of loop to fix this.
    
    Fixes: e845f099f1c6 ('drm/i915/dsc: Add Per connector debugfs node for DSC support/enable')
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109097
    Cc: Lyude Paul <lyude@redhat.com>
    Cc: Chris Wilson <chris@chris-wilson.co.uk>
    Signed-off-by: Manasi Navare <manasi.d.navare@intel.com>
    Reviewed-by: Lyude Paul <lyude@redhat.com>
    Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
    Link: https://patchwork.freedesktop.org/patch/msgid/20181219235120.21816-1-manasi.d.navare@intel.com
Comment 6 Francesco Balestrieri 2018-12-28 08:26:17 UTC
Appeared once, then no more after the fix. Closing.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.