Bug 109493 - [CI][DRMTIP] igt@gem_cpu_reloc@forked - fail - igt_skip: Assertion `!test_child' failed.
Summary: [CI][DRMTIP] igt@gem_cpu_reloc@forked - fail - igt_skip: Assertion `!test_chi...
Status: CLOSED FIXED
Alias: None
Product: DRI
Classification: Unclassified
Component: IGT (show other bugs)
Version: XOrg git
Hardware: Other All
: medium normal
Assignee: Default DRI bug account
QA Contact:
URL:
Whiteboard: ReadyForDev
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-29 12:14 UTC by Martin Peres
Modified: 2019-03-06 18:01 UTC (History)
1 user (show)

See Also:
i915 platform: G33, I915G
i915 features: GEM/Other


Attachments

Description Martin Peres 2019-01-29 12:14:16 UTC
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_197/fi-gdg-551/igt@gem_cpu_reloc@forked.html

Starting subtest: forked
gem_cpu_reloc: ../lib/igt_core.c:1030: igt_skip: Assertion `!test_child' failed.
Received signal SIGABRT.
Comment 2 Chris Wilson 2019-01-29 12:16:11 UTC
igt mishandling a igt_skip from inside an igt_fork; usually procedure is to move the skip check before the fork.
Comment 3 Chris Wilson 2019-01-30 11:30:05 UTC
Hmm, there are no skips here, so the test failed and we got no error message from the child. That's quite a nasty igt bug.
Comment 4 Chris Wilson 2019-01-30 16:21:02 UTC
Found the skip, patch sent.
Comment 5 Chris Wilson 2019-01-31 09:44:11 UTC
commit 4049adf01014af077df2174def4fadf7cecb066e (HEAD, upstream/master)
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Wed Jan 30 16:18:58 2019 +0000

    i915/gem_cpu_reloc: Do the can-store-dword check at start
    
    igt doesn't handle skipping from inside igt_fork very gracefully and
    crashes instead of reporting the lack of requirements. One solution
    would be to fix igt, but far easier is to just move the requirement
    checking around to do it before we even fork.
    
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109493
    Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
    Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Comment 6 Martin Peres 2019-03-06 18:01:16 UTC
(In reply to Chris Wilson from comment #5)
> commit 4049adf01014af077df2174def4fadf7cecb066e (HEAD, upstream/master)
> Author: Chris Wilson <chris@chris-wilson.co.uk>
> Date:   Wed Jan 30 16:18:58 2019 +0000
> 
>     i915/gem_cpu_reloc: Do the can-store-dword check at start
>     
>     igt doesn't handle skipping from inside igt_fork very gracefully and
>     crashes instead of reporting the lack of requirements. One solution
>     would be to fix igt, but far easier is to just move the requirement
>     checking around to do it before we even fork.
>     
>     Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109493
>     Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>     Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Thanks, it definitely did the trick as it was seen twice every single run between drmtip_197 and 203, and nothing for 34 runs :)
Comment 7 CI Bug Log 2019-03-06 18:01:26 UTC
The CI Bug Log issue associated to this bug has been archived.

New failures matching the above filters will not be associated to this bug anymore.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.