Bug 109531 - implicit declaration of function ‘ac_nir_get_max_workgroup_size
Summary: implicit declaration of function ‘ac_nir_get_max_workgroup_size
Status: RESOLVED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Drivers/Vulkan/radeon (show other bugs)
Version: git
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: mesa-dev
QA Contact: mesa-dev
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-02-01 12:40 UTC by LoneVVolf
Modified: 2019-02-01 14:35 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments

Description LoneVVolf 2019-02-01 12:40:48 UTC
Looks like https://cgit.freedesktop.org/mesa/mesa/commit/?id=9b9ccee4d64b5e64f6638bca7a87b3f159e3be9c didn't change ac_nir_get_max-workgroup_size to radv_nir_max_workgroup_size in all necessary places.



./mesa/src/amd/vulkan/radv_shader.c: In function ‘generate_shader_stats’:
../mesa/src/amd/vulkan/radv_shader.c:752:5: error: implicit declaration of function ‘ac_nir_get_max_workgroup_size’; did you mean ‘radv_nir_get_max_workgroup_size’? [-Werror=implicit-function-declaration]
     ac_nir_get_max_workgroup_size(chip_class, variant->nir);
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     radv_nir_get_max_workgroup_size

../mesa/src/amd/vulkan/radv_nir_to_llvm.c: In function ‘ac_translate_nir_to_llvm’:
../mesa/src/amd/vulkan/radv_nir_to_llvm.c:3453:33: error: implicit declaration of function ‘ac_nir_get_max_workgroup_size’; did you mean ‘radv_nir_get_max_workgroup_size’? [-Werror=implicit-function-declaration]
                                 ac_nir_get_max_workgroup_size(ctx.options->chip_class,
Comment 1 Mike Lothian 2019-02-01 14:32:48 UTC
I've created a MR to fix this https://gitlab.freedesktop.org/mesa/mesa/merge_requests/193 it gets things building for me locally


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.