Bug 109765 - Incorrect assert in gallium/state_trackers/va/picture_mjpeg.c
Summary: Incorrect assert in gallium/state_trackers/va/picture_mjpeg.c
Status: NEW
Alias: None
Product: Mesa
Classification: Unclassified
Component: Other (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: mesa-dev
QA Contact: mesa-dev
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-02-24 23:41 UTC by Andres
Modified: 2019-02-24 23:41 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andres 2019-02-24 23:41:16 UTC
The assert in vlVaHandleHuffmanTableBufferType() [1] seems incorrect. Based on the pattern of the other functions in the file, it should be:

assert(buf->size >= sizeof(VAHuffmanTableBufferJPEGBaseline) && buf->num_elements == 1);

instead of

assert(buf->size >= sizeof(VASliceParameterBufferJPEGBaseline) && buf->num_elements == 1);

[1] https://gitlab.freedesktop.org/mesa/mesa/blob/master/src/gallium/state_trackers/va/picture_mjpeg.c#L74


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.