Bug 109794 - LLVM not properly shutdown in `si_pipe.c`?
Summary: LLVM not properly shutdown in `si_pipe.c`?
Alias: None
Product: Mesa
Classification: Unclassified
Component: Drivers/Gallium/radeonsi (show other bugs)
Version: git
Hardware: x86-64 (AMD64) Linux (All)
: medium minor
Assignee: Default DRI bug account
QA Contact: Default DRI bug account
Depends on:
Reported: 2019-02-28 06:51 UTC by Hal Gentz
Modified: 2019-09-25 18:49 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Description Hal Gentz 2019-02-28 06:51:08 UTC
tl;dr; Shouldn't we be calling `LLVMShutdown()` somewhere?

I had a program which was calling: 
eglInitialize(disp, &majoir, &minor); 
eglInitialize(disp, &majoir, &minor);

Which lead to mesa outputting the following before continuing on normally during the second call to `eglInitalize`:

mesa: for the -simplifycfg-sink-common option: may only occur zero or one times!
mesa: for the -global-isel-abort option: may only occur zero or one times!

This prompted an investigation me to investigate, and with the aid of @imirkin, I think I got the cause.

You see, in an `eglInitialize` call `radeonsi_dri.so` gets loaded, which also loads in `libLLVM-9svn.so`, and eventually `ac_init_llvm_once()` gets called more than once.

That's OK, for as the name implies, it only happens once.

Issue is, when `eglTerminate` is called, `radeonsi_dri.so` gets unloaded, but not `libLLVM-9svn.so`. This means that the next time we all `eglInitialize`, LLVM's `ManagedStatic`s will be preserved, but not our static var `ac_init_llvm_target_once_flag`.

We can fix this by calling `LLVMShutdown` before unloading `radeonsi_dri.so`, that way LLVM's `ManagedStatic`s are also reset.

Alas, I'm not familiar enough with the mesa codebase, so I got no clue where the appropriate place to plop this function is. Any aid would be well appreciated.
Comment 1 Hal Gentz 2019-02-28 06:55:06 UTC
s/an investigation//
s/in an `eglInitialize` call/when we call `eglInitialize`/
s/happens once./initializes stuff once./
s/we all/we call/
Comment 2 GitLab Migration User 2019-09-25 18:49:04 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/mesa/mesa/issues/1377.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.