Bug 110227 - [ILK] crash with ryzom open source game client
Summary: [ILK] crash with ryzom open source game client
Status: RESOLVED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Drivers/DRI/i965 (show other bugs)
Version: 19.0
Hardware: x86-64 (AMD64) Linux (All)
: medium major
Assignee: José JORGE
QA Contact: Intel 3D Bugs Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-03-23 08:59 UTC by José Jorge
Modified: 2019-04-02 07:30 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description José Jorge 2019-03-23 08:59:01 UTC
Intel HD Arrandale (i5-450m)
Xorg log : [    36.724] (II) intel(0): SNA initialized with Ironlake (gen5) backend

While RC version of Mesa 19 worked with this client, the final release crashes with this report :

ryzom_client: ../src/intel/compiler/brw_fs_visitor.cpp:146: fs_reg fs_visitor::interp_reg(int, int): Assertion `prog_data->urb_setup[location] != -1' failed.

I suppose this is something in Intel HD driver.
Comment 1 Thierry Vignaud 2019-03-23 09:39:32 UTC
Technically this is final release + fixes from staging/19.0 branch
Comment 2 Mark Janes 2019-03-25 18:04:03 UTC
Do you know if this is a regression vs previous mesa releases?
Comment 3 José Jorge 2019-03-25 18:07:28 UTC
(In reply to Mark Janes from comment #2)
> Do you know if this is a regression vs previous mesa releases?

Yes, I can use Mesa 17.3.9 on the same system (Mageia 6 instead of Cauldron)
Comment 4 Mark Janes 2019-03-25 18:13:26 UTC
If you can bisect mesa, that will give us a lot of information and lead to a resolution.

Otherwise, please attach an apitrace and I'll bisect it.  The apitrace will be useful to the author of the bisected commit as well.
Comment 5 José Jorge 2019-03-26 12:42:27 UTC
(In reply to Mark Janes from comment #4)
> If you can bisect mesa, that will give us a lot of information and lead to a
> resolution.

Ok, I have found how to bisect. Seems this commit is the culprit.

[4bfa2ac2eab7551b1d89309fa8da44a487542f72] intel/fs: Rename a local variable so it doesn't shadow component()
Comment 6 Mark Janes 2019-03-26 17:17:37 UTC
Thanks for the bisect, it is really helpul.

Curro, you authored the patch...  Can you take a look?
Comment 7 Tapani Pälli 2019-03-27 14:03:09 UTC
FYI I've tested Ryzom on KBL and made apitrace out of it, shared this internally.
Comment 8 José Jorge 2019-03-27 15:34:20 UTC
(In reply to Tapani Pälli from comment #7)
> FYI I've tested Ryzom on KBL and made apitrace out of it, shared this
> internally.

Just to understand, you had the same bug, or is it only in older hardware?
Comment 9 Francisco Jerez 2019-03-27 22:50:14 UTC
It seems to affect older hardware only.  It doesn't fail on SKL but I can reproduce the crash by overriding the PCI ID to ILK's.

Bisect result seems bogus.  The commit mentioned above simply changes the name of a variable and shouldn't lead to any functional changes.  I can reproduce the crash with or without the commit above applied to my working tree.

Would you mind bisecting further?

Thanks!
Comment 10 Mark Janes 2019-03-28 19:31:51 UTC
I tried to reproduce this, and struck out.  Everything crashes on every version of mesa.  Some questions I have:

Curro:  Would we expect device id override to work, since it will result in sending ILK commands to the KBL gpu that we are using to spoof ILK?  I couldn't get *any* version of mesa to run the trace in this way.

Tapani:  I couldn't replay your trace on real ILK hardware, even with 17.3 (reported to work by José).  I imagine that the game queries features and produces a trace on KBL that can't work on older hardware.

José:  Based on Curro's feedback, I need to repeat your bisect.  I can't do it without an apitrace of the workload taken on ILK.  Can you create one for me?  Sorry about the back-and-forth.
Comment 11 Francisco Jerez 2019-03-28 20:16:32 UTC
(In reply to Mark Janes from comment #10)
> I tried to reproduce this, and struck out.  Everything crashes on every
> version of mesa.

That's what I've observed too with the few releases I tried to replay Tapani's trace on.

> Some questions I have:
> 
> Curro:  Would we expect device id override to work, since it will result in
> sending ILK commands to the KBL gpu that we are using to spoof ILK?  I
> couldn't get *any* version of mesa to run the trace in this way.
> 

It won't send any actual commands to the hardware while doing PCI ID override, but it shouldn't crash either while compiling shaders assuming you've found a version that doesn't have the bug.
Comment 12 José Jorge 2019-03-28 20:22:28 UTC
(In reply to Mark Janes from comment #10)
> I tried to reproduce this, and struck out.  Everything crashes on every
> version of mesa.  Some questions I have:
>... 
> José:  Based on Curro's feedback, I need to repeat your bisect.  I can't do
> it without an apitrace of the workload taken on ILK.  Can you create one for
> me?  Sorry about the back-and-forth.

Well, looks like this crash was fixed in last commits : Mesa 19.0.1 does not crash anymore here. I suppose we can close this bug?
Comment 13 Tapani Pälli 2019-04-02 07:30:07 UTC
(In reply to Mark Janes from comment #10)
> I tried to reproduce this, and struck out.  Everything crashes on every
> version of mesa.  Some questions I have:

That is strange, trace works for me on HSW machine but I don't have ILK to test with. Note that sometimes different apitrace versions also conflict so some of this crashing might be simply because of that.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.