Bug 110310 - glXQueryServerString is weirdly restrictive
Summary: glXQueryServerString is weirdly restrictive
Status: RESOLVED MOVED
Alias: None
Product: Mesa
Classification: Unclassified
Component: GLX (show other bugs)
Version: unspecified
Hardware: Other All
: medium enhancement
Assignee: mesa-dev
QA Contact: mesa-dev
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-04-02 20:00 UTC by Adam Jackson
Modified: 2019-09-18 17:46 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description Adam Jackson 2019-04-02 20:00:29 UTC
(This is with reference to src/glx/glxcmds.c; other implementations in the tree might have similar issues, I haven't checked)

In principle you might want to query GLX_VENDOR_NAMES_EXT if you're trying to do something clever with glvnd; other strings are imaginable for other possible extensions. But at the moment the call to __glXQueryServerString is unreachable, because of the 'default: return NULL;' in the switch statement. Part of the reason for this is that the `priv->serverXXX` strings are saved in the GLX display state and are manually freed at shutdown. If we returned arbitrary strings too, we'd need to track them in a hash table; and once you're doing that, why not do that for _all_ server strings.

This probably also requires making __glXQueryServerString robust against getting errors instead of replies.
Comment 1 GitLab Migration User 2019-09-18 17:46:08 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/mesa/mesa/issues/117.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.