No Man Sky hangs with mesa-git, it works fine with Mesa 19.0.1 or 19.0.2.
Created attachment 144046 [details] [review]
This fixes the GPU hang.
The split_alu_of_phi NIR pass seems correct to me. The generated NIR and LLVM IR (for the shader that hangs) also seem correct to me, so this likely triggers a bug in LLVM.
Created attachment 144047 [details]
For me the game hangs as well (Radeon VII, Mesa 19.0.3), but it's not a GPU hang as I can tab out and clsoe the game. Will try that fix and report back
oh, this may be a different thing - I am trying the Vulkan branch - doh!
Sorry about the confusion
That workaround works for me but has huge graphical artifacts. Like blue triangles all over the screen. Basically unplayable.
This is issue of ACO and not mesa in general. But UI is still unusable. Like 5 fps UI.
Since the last update of No Man Sky, the game no longer hangs with RADV. The old issue probably still remains in LLVM but it got "fixed" by the game itself.
As for the other issues, we are working on.
Closing this ticket as it refers to an old GPU hang.