No Man Sky hangs with mesa-git, it works fine with Mesa 19.0.1 or 19.0.2.
Created attachment 144046 [details] [review]
This fixes the GPU hang.
The split_alu_of_phi NIR pass seems correct to me. The generated NIR and LLVM IR (for the shader that hangs) also seem correct to me, so this likely triggers a bug in LLVM.
Created attachment 144047 [details]
For me the game hangs as well (Radeon VII, Mesa 19.0.3), but it's not a GPU hang as I can tab out and clsoe the game. Will try that fix and report back
oh, this may be a different thing - I am trying the Vulkan branch - doh!
Sorry about the confusion