Bug 110545 - [CI][DRMTIP] igt@kms_universal_plane@universal-plane-pipe-[abc]-sanity - fail - Failed assertion: igt_display_try_commit2(&data->display, COMMIT_UNIVERSAL) == expect
Summary: [CI][DRMTIP] igt@kms_universal_plane@universal-plane-pipe-[abc]-sanity - fail...
Status: NEW
Alias: None
Product: DRI
Classification: Unclassified
Component: DRM/Intel (show other bugs)
Version: DRI git
Hardware: Other All
: low minor
Assignee: Intel GFX Bugs mailing list
QA Contact: Intel GFX Bugs mailing list
URL:
Whiteboard: ReadyForDev
Keywords:
Depends on:
Blocks:
 
Reported: 2019-04-29 07:46 UTC by Lakshmi
Modified: 2019-10-10 23:37 UTC (History)
2 users (show)

See Also:
i915 platform: BSW/CHT, G33, I915G, PNV
i915 features: display/Other


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Lakshmi 2019-04-29 07:46:13 UTC
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_266/fi-cml-u/igt@kms_universal_plane@universal-plane-pipe-b-sanity.html
Starting subtest: universal-plane-pipe-B-sanity
(kms_universal_plane:1159) CRITICAL: Test assertion failure function sanity_test_pipe, file ../tests/kms_universal_plane.c:387:
(kms_universal_plane:1159) CRITICAL: Failed assertion: igt_display_try_commit2(&data->display, COMMIT_UNIVERSAL) == expect
Subtest universal-plane-pipe-B-sanity failed.
**** DEBUG ****
Comment 1 Lakshmi 2019-04-29 07:46:56 UTC
	
Starting subtest: universal-plane-pipe-B-sanity
(kms_universal_plane:1159) CRITICAL: Test assertion failure function sanity_test_pipe, file ../tests/kms_universal_plane.c:387:
(kms_universal_plane:1159) CRITICAL: Failed assertion: igt_display_try_commit2(&data->display, COMMIT_UNIVERSAL) == expect
Subtest universal-plane-pipe-B-sanity failed.
**** DEBUG ****
(kms_universal_plane:1159) DEBUG: Test requirement passed: !(pipe >= data->display.n_pipes)
(kms_universal_plane:1159) igt_kms-DEBUG: display: eDP-1: set_pipe(B)
(kms_universal_plane:1159) igt_kms-DEBUG: display: eDP-1: Selecting pipe B
(kms_universal_plane:1159) igt_kms-DEBUG: display: eDP-1: set_pipe(B)
(kms_universal_plane:1159) igt_kms-DEBUG: display: eDP-1: Selecting pipe B
(kms_universal_plane:1159) igt_fb-DEBUG: igt_create_fb_with_bo_size(width=3840, height=2160, format=XR24(0x34325258), modifier=0x0, size=0)
(kms_universal_plane:1159) igt_fb-DEBUG: igt_create_fb_with_bo_size(handle=1, pitch=15360)
(kms_universal_plane:1159) ioctl_wrappers-DEBUG: Test requirement passed: igt_has_fb_modifiers(fd)
(kms_universal_plane:1159) igt_fb-DEBUG: Test requirement passed: cairo_surface_status(fb->cairo_surface) == CAIRO_STATUS_SUCCESS
(kms_universal_plane:1159) igt_fb-DEBUG: igt_create_fb_with_bo_size(width=3940, height=2260, format=XR24(0x34325258), modifier=0x0, size=0)
(kms_universal_plane:1159) igt_fb-DEBUG: igt_create_fb_with_bo_size(handle=2, pitch=15808)
(kms_universal_plane:1159) ioctl_wrappers-DEBUG: Test requirement passed: igt_has_fb_modifiers(fd)
(kms_universal_plane:1159) igt_fb-DEBUG: Test requirement passed: cairo_surface_status(fb->cairo_surface) == CAIRO_STATUS_SUCCESS
(kms_universal_plane:1159) igt_fb-DEBUG: igt_create_fb_with_bo_size(width=3740, height=2060, format=XR24(0x34325258), modifier=0x0, size=0)
(kms_universal_plane:1159) igt_fb-DEBUG: igt_create_fb_with_bo_size(handle=3, pitch=14976)
(kms_universal_plane:1159) ioctl_wrappers-DEBUG: Test requirement passed: igt_has_fb_modifiers(fd)
(kms_universal_plane:1159) igt_fb-DEBUG: Test requirement passed: cairo_surface_status(fb->cairo_surface) == CAIRO_STATUS_SUCCESS
(kms_universal_plane:1159) igt_kms-DEBUG: Test requirement passed: plane_idx >= 0 && plane_idx < pipe->n_planes
(kms_universal_plane:1159) igt_kms-DEBUG: display: B.0: plane_set_fb(114)
(kms_universal_plane:1159) igt_kms-DEBUG: display: B.0: plane_set_size (3840x2160)
(kms_universal_plane:1159) igt_kms-DEBUG: display: B.0: fb_set_position(0,0)
(kms_universal_plane:1159) igt_kms-DEBUG: display: B.0: fb_set_size(3840x2160)
(kms_universal_plane:1159) igt_kms-DEBUG: display: commit {
(kms_universal_plane:1159) igt_kms-DEBUG: display:     Fixing up initial rotation pipe A, plane 0
(kms_universal_plane:1159) igt_kms-DEBUG: display:     SetCrtc pipe A, disabling
(kms_universal_plane:1159) igt_kms-DEBUG: display:     Fixing up initial rotation pipe A, plane 1
(kms_universal_plane:1159) igt_kms-DEBUG: display:     SetPlane pipe A, plane 1, disabling
(kms_universal_plane:1159) igt_kms-DEBUG: display:     SetProp plane A.1 "rotation" to 0x1/1
(kms_universal_plane:1159) igt_kms-DEBUG: display:     SetProp plane A.1 "COLOR_ENCODING" to 0x0/0
(kms_universal_plane:1159) igt_kms-DEBUG: display:     SetProp plane A.1 "COLOR_RANGE" to 0x0/0
(kms_universal_plane:1159) igt_kms-DEBUG: display:     SetProp plane A.1 "pixel blend mode" to 0x0/0
(kms_universal_plane:1159) igt_kms-DEBUG: display:     SetProp plane A.1 "alpha" to 0xffff/65535
(kms_universal_plane:1159) igt_kms-DEBUG: display:     Fixing up initial rotation pipe A, plane 2
(kms_universal_plane:1159) igt_kms-DEBUG: display:     SetCursor pipe A, disabling
(kms_universal_plane:1159) igt_kms-DEBUG: display:     MoveCursor pipe A, (0, 0)
(kms_universal_plane:1159) igt_kms-DEBUG: display:     Fixing up initial rotation pipe B, plane 0
(kms_universal_plane:1159) igt_kms-DEBUG: display:     eDP-1: SetCrtc pipe B, fb 114, src (0, 0), mode 3840x2160
(kms_universal_plane:1159) igt_kms-DEBUG: display:     Fixing up initial rotation pipe B, plane 1
(kms_universal_plane:1159) igt_kms-DEBUG: display:     SetPlane pipe B, plane 1, disabling
(kms_universal_plane:1159) igt_kms-DEBUG: display:     SetProp plane B.1 "rotation" to 0x1/1
(kms_universal_plane:1159) igt_kms-DEBUG: display:     SetProp plane B.1 "COLOR_ENCODING" to 0x0/0
(kms_universal_plane:1159) igt_kms-DEBUG: display:     SetProp plane B.1 "COLOR_RANGE" to 0x0/0
(kms_universal_plane:1159) igt_kms-DEBUG: display:     SetProp plane B.1 "pixel blend mode" to 0x0/0
(kms_universal_plane:1159) igt_kms-DEBUG: display:     SetProp plane B.1 "alpha" to 0xffff/65535
(kms_universal_plane:1159) igt_kms-DEBUG: display:     Fixing up initial rotation pipe B, plane 2
(kms_universal_plane:1159) igt_kms-DEBUG: display:     SetCursor pipe B, disabling
(kms_universal_plane:1159) igt_kms-DEBUG: display:     MoveCursor pipe B, (0, 0)
(kms_universal_plane:1159) igt_kms-DEBUG: display:     Fixing up initial rotation pipe C, plane 0
(kms_universal_plane:1159) igt_kms-DEBUG: display:     SetCrtc pipe C, disabling
(kms_universal_plane:1159) igt_kms-DEBUG: display:     Fixing up initial rotation pipe C, plane 1
(kms_universal_plane:1159) igt_kms-DEBUG: display:     SetPlane pipe C, plane 1, disabling
(kms_universal_plane:1159) igt_kms-DEBUG: display:     SetProp plane C.1 "rotation" to 0x1/1
(kms_universal_plane:1159) igt_kms-DEBUG: display:     SetProp plane C.1 "COLOR_ENCODING" to 0x0/0
(kms_universal_plane:1159) igt_kms-DEBUG: display:     SetProp plane C.1 "COLOR_RANGE" to 0x0/0
(kms_universal_plane:1159) igt_kms-DEBUG: display:     SetProp plane C.1 "pixel blend mode" to 0x0/0
(kms_universal_plane:1159) igt_kms-DEBUG: display:     SetProp plane C.1 "alpha" to 0xffff/65535
(kms_universal_plane:1159) igt_kms-DEBUG: display:     Fixing up initial rotation pipe C, plane 2
(kms_universal_plane:1159) igt_kms-DEBUG: display:     SetCursor pipe C, disabling
(kms_universal_plane:1159) igt_kms-DEBUG: display:     MoveCursor pipe C, (0, 0)
(kms_universal_plane:1159) igt_kms-DEBUG: display: }
(kms_universal_plane:1159) igt_debugfs-DEBUG: Opening debugfs directory '/sys/kernel/debug/dri/0'
(kms_universal_plane:1159) igt_kms-DEBUG: display: B.0: plane_set_fb(116)
(kms_universal_plane:1159) igt_kms-DEBUG: display: B.0: plane_set_size (3740x2060)
(kms_universal_plane:1159) igt_kms-DEBUG: display: B.0: fb_set_position(0,0)
(kms_universal_plane:1159) igt_kms-DEBUG: display: B.0: fb_set_size(3740x2060)
(kms_universal_plane:1159) igt_kms-DEBUG: display: commit {
(kms_universal_plane:1159) igt_kms-DEBUG: display:     SetProp plane A.0 "COLOR_ENCODING" to 0x0/0
(kms_universal_plane:1159) igt_kms-DEBUG: display:     SetProp plane A.0 "COLOR_RANGE" to 0x0/0
(kms_universal_plane:1159) igt_kms-DEBUG: display:     SetProp plane A.0 "pixel blend mode" to 0x0/0
(kms_universal_plane:1159) igt_kms-DEBUG: display:     SetProp plane A.0 "alpha" to 0xffff/65535
(kms_universal_plane:1159) igt_kms-DEBUG: display:     SetPlane B.0, fb 116, src = (0, 0) 3740x2060 dst = (0, 0) 3740x2060
(kms_universal_plane:1159) igt_kms-DEBUG: display:     SetProp plane B.0 "COLOR_ENCODING" to 0x1/1
(kms_universal_plane:1159) igt_kms-DEBUG: display:     SetProp plane B.0 "COLOR_RANGE" to 0x0/0
(kms_universal_plane:1159) igt_kms-DEBUG: display:     SetProp plane B.0 "pixel blend mode" to 0x0/0
(kms_universal_plane:1159) igt_kms-DEBUG: display:     SetProp plane B.0 "alpha" to 0xffff/65535
(kms_universal_plane:1159) igt_kms-DEBUG: display:     SetProp plane C.0 "COLOR_ENCODING" to 0x0/0
(kms_universal_plane:1159) igt_kms-DEBUG: display:     SetProp plane C.0 "COLOR_RANGE" to 0x0/0
(kms_universal_plane:1159) igt_kms-DEBUG: display:     SetProp plane C.0 "pixel blend mode" to 0x0/0
(kms_universal_plane:1159) igt_kms-DEBUG: display:     SetProp plane C.0 "alpha" to 0xffff/65535
(kms_universal_plane:1159) igt_kms-DEBUG: display: }
(kms_universal_plane:1159) CRITICAL: Test assertion failure function sanity_test_pipe, file ../tests/kms_universal_plane.c:387:
(kms_universal_plane:1159) CRITICAL: Failed assertion: igt_display_try_commit2(&data->display, COMMIT_UNIVERSAL) == expect
(kms_universal_plane:1159) igt_core-INFO: Stack trace:
(kms_universal_plane:1159) igt_core-INFO:   #0 ../lib/igt_core.c:1476 __igt_fail_assert()
(kms_universal_plane:1159) igt_core-INFO:   #1 ../tests/kms_universal_plane.c:390 sanity_test_pipe()
(kms_universal_plane:1159) igt_core-INFO:   #2 ../tests/kms_universal_plane.c:768 run_tests_for_pipe()
(kms_universal_plane:1159) igt_core-INFO:   #3 ../tests/kms_universal_plane.c:807 __real_main789()
(kms_universal_plane:1159) igt_core-INFO:   #4 ../tests/kms_universal_plane.c:789 main()
(kms_universal_plane:1159) igt_core-INFO:   #5 ../csu/libc-start.c:344 __libc_start_main()
(kms_universal_plane:1159) igt_core-INFO:   #6 [_start+0x2a]
****  END  ****
Comment 3 CI Bug Log 2019-07-16 08:55:57 UTC
A CI Bug Log filter associated to this bug has been updated:

{- CML: igt@kms_universal_plane@universal-plane-pipe-[abc]-sanity - fail - Failed assertion: igt_display_try_commit2(&amp;data-&gt;display, COMMIT_UNIVERSAL) == expect -}
{+ GDG G33 PNV BSW CML: igt@kms_universal_plane@universal-plane-pipe-[abc]-sanity - fail - Failed assertion: igt_display_try_commit2(&amp;data-&gt;display, COMMIT_UNIVERSAL) == expect +}

New failures caught by the filter:

  * https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_322/fi-blb-e6850/igt@kms_universal_plane@universal-plane-pipe-b-sanity.html
  * https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_322/fi-bsw-kefka/igt@kms_universal_plane@universal-plane-pipe-b-sanity.html
  * https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_322/fi-gdg-551/igt@kms_universal_plane@universal-plane-pipe-b-sanity.html
  * https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_322/fi-pnv-d510/igt@kms_universal_plane@universal-plane-pipe-b-sanity.html
Comment 4 Matt Roper 2019-10-10 23:33:57 UTC
The test is written to assume that only gen9+ can "window" their primary plane (i.e., plane dimensions do not exactly match pipe dimensions).  That was true until very recently when

    commit 26443a4bc44850ff28329ae97a3cc9349d7dd87b
    Author: Ville Syrjälä <ville.syrjala@linux.intel.com>
    Date:   Wed Jul 3 23:08:19 2019 +0300

        drm/i915: Add windowing for primary planes on gen2/3 and chv

allowed gen2/3 and chv to also window their primary planes.  The test will need to be updated to account for this behavior change and avoid failures on these older platforms.

Note:  there were also a couple CML failures 5 months ago, but that seems to have been an unrelated problem and has been fixed since it hasn't happened since.  Dropping the 'CFL' tag from this bug since all recent failures have been gen2/gen3.
Comment 5 Matt Roper 2019-10-10 23:37:48 UTC
This does raise the question of whether we should even test this in IGT anymore.  These days we generally try to trust the kernel's direction on what the hardware can/can't do and avoid putting a bunch of platform-specific knowledge into KMS tests that are supposed to be platform-agnostic (and not even Intel-specific).

Anyway, since the kernel is behaving as expected and the test is just outdated here, marking this as low importance since this won't impact end users (and the CI failures that happen will happen 100% of the time).


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.