Bug 110823 - [Intel-GFX-CI][BAT] igt@amdgpu/amd_basic@userptr - fail - Failed assertion: r == 0
Summary: [Intel-GFX-CI][BAT] igt@amdgpu/amd_basic@userptr - fail - Failed assertion: r...
Status: RESOLVED FIXED
Alias: None
Product: DRI
Classification: Unclassified
Component: IGT (show other bugs)
Version: XOrg git
Hardware: Other All
: medium normal
Assignee: Default DRI bug account
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-06-03 10:11 UTC by Martin Peres
Modified: 2019-11-07 12:06 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Peres 2019-06-03 10:11:29 UTC
Hi, it looks like amdgpu's userptrs are now broken:

https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6179/fi-kbl-8809g/igt@amdgpu_amd_basic@userptr.html
	
Starting subtest: userptr
(amd_basic:3888) CRITICAL: Test assertion failure function amdgpu_userptr_test, file ../tests/amdgpu/amd_basic.c:1331:
(amd_basic:3888) CRITICAL: Failed assertion: r == 0
(amd_basic:3888) CRITICAL: Last errno: 19, No such device
(amd_basic:3888) CRITICAL: error: -19 != 0


Please also fix the test to make the assertion easier to read. I had to go to the source code to find out it was due to this:

r = amdgpu_create_bo_from_user_mem(device, ptr, BUFFER_SIZE, &buf_handle);
igt_assert_eq(r, 0);

Please use igt_assert_f() in order to provide reasons (there are tons of igt_assert_eq(r, 0)).
Comment 1 CI Bug Log 2019-06-03 10:12:00 UTC
The CI Bug Log issue associated to this bug has been updated.

### New filters associated

* VEGA M: igt@amdgpu/amd_basic@userptr - fail - Failed assertion: r == 0
  - https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13156/fi-kbl-8809g/igt@amdgpu/amd_basic@userptr.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_4368/fi-kbl-8809g/igt@amdgpu/amd_basic@userptr.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5027/fi-kbl-8809g/igt@amdgpu/amd_basic@userptr.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6172/fi-kbl-8809g/igt@amdgpu/amd_basic@userptr.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6173/fi-kbl-8809g/igt@amdgpu/amd_basic@userptr.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3085/fi-kbl-8809g/igt@amdgpu/amd_basic@userptr.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13143/fi-kbl-8809g/igt@amdgpu/amd_basic@userptr.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3086/fi-kbl-8809g/igt@amdgpu/amd_basic@userptr.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6174/fi-kbl-8809g/igt@amdgpu/amd_basic@userptr.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3089/fi-kbl-8809g/igt@amdgpu/amd_basic@userptr.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3090/fi-kbl-8809g/igt@amdgpu/amd_basic@userptr.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6176/fi-kbl-8809g/igt@amdgpu/amd_basic@userptr.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13148/fi-kbl-8809g/igt@amdgpu/amd_basic@userptr.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3091/fi-kbl-8809g/igt@amdgpu/amd_basic@userptr.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13149/fi-kbl-8809g/igt@amdgpu/amd_basic@userptr.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3087/fi-kbl-8809g/igt@amdgpu/amd_basic@userptr.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13145/fi-kbl-8809g/igt@amdgpu/amd_basic@userptr.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13147/fi-kbl-8809g/igt@amdgpu/amd_basic@userptr.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_4356/fi-kbl-8809g/igt@amdgpu/amd_basic@userptr.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13153/fi-kbl-8809g/igt@amdgpu/amd_basic@userptr.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6178/fi-kbl-8809g/igt@amdgpu/amd_basic@userptr.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_4358/fi-kbl-8809g/igt@amdgpu/amd_basic@userptr.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13154/fi-kbl-8809g/igt@amdgpu/amd_basic@userptr.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6175/fi-kbl-8809g/igt@amdgpu/amd_basic@userptr.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13146/fi-kbl-8809g/igt@amdgpu/amd_basic@userptr.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_4357/fi-kbl-8809g/igt@amdgpu/amd_basic@userptr.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3088/fi-kbl-8809g/igt@amdgpu/amd_basic@userptr.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_4359/fi-kbl-8809g/igt@amdgpu/amd_basic@userptr.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_4361/fi-kbl-8809g/igt@amdgpu/amd_basic@userptr.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_4362/fi-kbl-8809g/igt@amdgpu/amd_basic@userptr.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_4363/fi-kbl-8809g/igt@amdgpu/amd_basic@userptr.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_4365/fi-kbl-8809g/igt@amdgpu/amd_basic@userptr.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_4366/fi-kbl-8809g/igt@amdgpu/amd_basic@userptr.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6179/fi-kbl-8809g/igt@amdgpu/amd_basic@userptr.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_4360/fi-kbl-8809g/igt@amdgpu/amd_basic@userptr.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_4364/fi-kbl-8809g/igt@amdgpu/amd_basic@userptr.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_4367/fi-kbl-8809g/igt@amdgpu/amd_basic@userptr.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13155/fi-kbl-8809g/igt@amdgpu/amd_basic@userptr.html
Comment 2 Chris Wilson 2019-06-03 13:30:47 UTC
CI config error.
Comment 3 Chris Wilson 2019-06-03 13:32:28 UTC
(In reply to Martin Peres from comment #0)
> Hi, it looks like amdgpu's userptrs are now broken:
> 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6179/fi-kbl-8809g/
> igt@amdgpu_amd_basic@userptr.html
> 	
> Starting subtest: userptr
> (amd_basic:3888) CRITICAL: Test assertion failure function
> amdgpu_userptr_test, file ../tests/amdgpu/amd_basic.c:1331:
> (amd_basic:3888) CRITICAL: Failed assertion: r == 0
> (amd_basic:3888) CRITICAL: Last errno: 19, No such device
> (amd_basic:3888) CRITICAL: error: -19 != 0

Is quite clear for a change.

Now one might argue that amdgpu changing the userptr ABI behind a non-default config option from a default option is a bit mean...
Comment 4 Chris Wilson 2019-11-07 12:06:35 UTC
Kernel config update to enable HMM_MIRROR.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.