Bug 110902 - mesa-19.1.0/src/broadcom/compiler/vir_opt_redundant_flags.c:104]: (style) Same expression
Summary: mesa-19.1.0/src/broadcom/compiler/vir_opt_redundant_flags.c:104]: (style) Sam...
Status: RESOLVED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Mesa core (show other bugs)
Version: 19.1
Hardware: Other All
: medium normal
Assignee: mesa-dev
QA Contact: mesa-dev
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-06-12 09:06 UTC by dcb314
Modified: 2019-06-15 15:41 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description dcb314 2019-06-12 09:06:23 UTC
mesa-19.1.0/src/broadcom/compiler/vir_opt_redundant_flags.c:104]: (style) Same expression on both sides of '||'.

Source code is

                if (inst->qpu.type != V3D_QPU_INSTR_TYPE_ALU ||
                    inst->qpu.flags.auf != V3D_QPU_UF_NONE ||
                    inst->qpu.flags.auf != V3D_QPU_UF_NONE) {
Comment 1 Alejandro Piñeiro (freenode IRC: apinheiro) 2019-06-12 12:23:01 UTC
Will take a look to this one.
Comment 2 Alejandro Piñeiro (freenode IRC: apinheiro) 2019-06-12 12:59:15 UTC
Following MR includes a patch that should fix this:

https://gitlab.freedesktop.org/mesa/mesa/merge_requests/1082
Comment 3 Alejandro Piñeiro (freenode IRC: apinheiro) 2019-06-15 15:41:21 UTC
> https://gitlab.freedesktop.org/mesa/mesa/merge_requests/1082

That MR got merged. Closing bug.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.