Bug 111199 - Bug in dither.depth property set: Value compared to dither.mode instead of dither.depth
Summary: Bug in dither.depth property set: Value compared to dither.mode instead of di...
Status: NEW
Alias: None
Product: xorg
Classification: Unclassified
Component: Driver/nouveau (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Nouveau Project
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords: janitor
Depends on:
Blocks:
 
Reported: 2019-07-23 09:38 UTC by Max
Modified: 2019-07-23 10:22 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Max 2019-07-23 09:38:33 UTC
There is probably a bug in dither.depth property set cause its value compared with dither.mode:

//nouveau_connector.c
 
if (property == disp->dithering_mode) {
    if (asyc->dither.mode != val) {
        asyc->dither.mode = val;
        asyc->set.dither = true;
    }
} else
if (property == disp->dithering_depth) {
    if (asyc->dither.mode != val) { //Should be dither.depth
        asyc->dither.depth = val;
        asyc->set.dither = true; //triggers dithering regardless of dither.mode set above. Copy/Paste from above? Should be removed?
    }
}


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.