Bug 111289 - Meson build does not build intel-ui tools with -Dtools=all
Summary: Meson build does not build intel-ui tools with -Dtools=all
Status: RESOLVED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Drivers/DRI/i965 (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Dylan Baker
QA Contact: Intel 3D Bugs Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-08-02 22:42 UTC by Mark Janes
Modified: 2019-08-07 07:38 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description Mark Janes 2019-08-02 22:42:58 UTC
Intel tools are compiled with "-Dtools=intel-ui", eg:

  build/src/intel/tools/aubinator-viewer

The tools are not compiled with "all" or when "all" is added to the list of tools to build.  "-Dtools=intel-ui,all" will not compile aubinator-viewer

gitlab CI uses -Dtools=all, and will not fail when aubinator-viewer is broken by a commit.
Comment 2 Eric Engestrom 2019-08-07 07:38:19 UTC
Fixed with:

commit 991137144a20aea14b1886a28e069685257abbd2
Author: Eric Engestrom <eric.engestrom@intel.com>
Date:   Sat Aug 3 02:33:42 2019 +0100

    meson: build intel-ui tools as part of `all` tools
    
    Reported-by: Mark Janes <mark.a.janes@intel.com>
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=111289
    Cc: Dylan Baker <dylan@pnwbakers.com>
    Signed-off-by: Eric Engestrom <eric.engestrom@intel.com>
    Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.