Bug 11132 - Xming, Cygwin/X: Tidy warnings, headers and unused variables
Summary: Xming, Cygwin/X: Tidy warnings, headers and unused variables
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Server/DDX/Xwin (show other bugs)
Version: unspecified
Hardware: Other Windows (All)
: medium normal
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 18093
  Show dependency tree / graph
 
Reported: 2007-06-03 15:50 UTC by Colin Harrison
Modified: 2009-01-15 13:59 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments
Patch to fix (5.16 KB, patch)
2007-06-03 15:51 UTC, Colin Harrison 		no flags Details | Splinter Review
Patch to consolidate definition of MOUSE_POLLING_INTERVAL and reduce value (2.96 KB, patch)
2009-01-07 15:18 UTC, Jon Turney 		no flags Details | Splinter Review
View All

Description Colin Harrison 2007-06-03 15:50:55 UTC 
Tidy warnings.
Tidy some '#include' header file preprocessor directives.
Remove some unused variables (some defined via macros!).
Reduce mouse polling interval to 10 mS.
Comment 1 Colin Harrison 2007-06-03 15:51:48 UTC 
Created attachment 10169 [details] [review]
Patch to fix
Comment 2 Jon Turney 2008-12-18 04:44:30 UTC 
Applied as commit b0ed1567c1782041cf3d14ec6dd4d622915c7d0c. Thanks.

I dropped the part of the patch which changes the mouse polling interval, because I don't understand it.
Comment 3 Colin Harrison 2008-12-18 09:30:21 UTC 
Wiz the cursor around an xeyes in -multiwindow mode, and you will what this timing does effect.
Comment 4 Jon Turney 2009-01-07 15:18:02 UTC 
Created attachment 21771 [details] [review]
Patch to consolidate definition of MOUSE_POLLING_INTERVAL and reduce value

Indeed, I see.  How about the attached patch?
Comment 5 Colin Harrison 2009-01-11 12:44:08 UTC 
That should do it. One definition is always best :)
Comment 6 Colin Harrison 2009-01-12 03:14:51 UTC 
PS Works for me. OK to commit. Thanks.
Comment 7 Jon Turney 2009-01-15 13:59:23 UTC 
Commited as 6f065a26db62aaf1d7aab9f9a3d0e6cd09d1c1dd

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.