Bug 111327 - [CI][SHARDS] igt@gem_ctx_shared@exec-single-timeline-bsd2 - fail - Failed assertion: nop_sync(i915, ctx, engine, (1000*(1000*(1000)))) == 0
Summary: [CI][SHARDS] igt@gem_ctx_shared@exec-single-timeline-bsd2 - fail - Failed ass...
Status: RESOLVED FIXED
Alias: None
Product: DRI
Classification: Unclassified
Component: DRM/Intel (show other bugs)
Version: DRI git
Hardware: Other All
: high normal
Assignee: Intel GFX Bugs mailing list
QA Contact: Intel GFX Bugs mailing list
URL:
Whiteboard: ReadyForDev
Keywords:
Depends on:
Blocks:
 
Reported: 2019-08-08 08:04 UTC by Lakshmi
Modified: 2019-08-10 16:28 UTC (History)
1 user (show)

See Also:
i915 platform: ICL
i915 features: GEM/Other


Attachments

Description Lakshmi 2019-08-08 08:04:21 UTC
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6647/shard-iclb4/igt@gem_ctx_shared@exec-single-timeline-bsd2.html
Starting subtest: exec-single-timeline-bsd2
(gem_ctx_shared:1260) CRITICAL: Test assertion failure function exec_single_timeline, file ../tests/i915/gem_ctx_shared.c:394:
(gem_ctx_shared:1260) CRITICAL: Failed assertion: nop_sync(i915, ctx, engine, (1000*(1000*(1000)))) == 0
(gem_ctx_shared:1260) CRITICAL: error: -62 != 0
Subtest exec-single-timeline-bsd2 failed.
**** DEBUG ****
(gem_ctx_shared:1260) DEBUG: Test requirement passed: gem_ring_has_physical_engine(i915, engine)
(gem_ctx_shared:1260) DEBUG: Test requirement passed: has_single_timeline(i915)
(gem_ctx_shared:1260) igt_dummyload-DEBUG: Test requirement passed: nengine
(gem_ctx_shared:1260) DEBUG: Test requirement passed: spin
(gem_ctx_shared:1260) CRITICAL: Test assertion failure function exec_single_timeline, file ../tests/i915/gem_ctx_shared.c:394:
(gem_ctx_shared:1260) CRITICAL: Failed assertion: nop_sync(i915, ctx, engine, (1000*(1000*(1000)))) == 0
(gem_ctx_shared:1260) CRITICAL: error: -62 != 0
(gem_ctx_shared:1260) igt_core-INFO: Stack trace:
(gem_ctx_shared:1260) igt_core-INFO:   #0 ../lib/igt_core.c:1674 __igt_fail_assert()
(gem_ctx_shared:1260) igt_core-INFO:   #1 ../tests/i915/gem_ctx_shared.c:382 __real_main787()
(gem_ctx_shared:1260) igt_core-INFO:   #2 [<unknown>+0x0]
****  END  ****
Subtest exec-single-timeline-bsd2: FAIL (1.056s)
Comment 2 Chris Wilson 2019-08-08 15:14:11 UTC
I think the issue here is related to

commit f1c4d157ab9b13c1228f3b8ad7747126785460d0 (HEAD -> drm-intel-next-queued, drm-intel/for-linux-next, drm-intel/drm-intel-next-queued)
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Thu Aug 8 12:06:12 2019 +0100

    drm/i915: Fix up the inverse mapping for default ctx->engines[]
    
    The order in which we store the engines inside default_engines() for the
    legacy ctx->engines[] has to match the legacy I915_EXEC_RING selector
    mapping in execbuf::user_map. If we present VCS2 as being the second
    instance of the video engine, legacy userspace calls that I915_EXEC_BSD2
    and so we need to insert it into the second video slot.
    
    v2: Record the legacy mapping (hopefully we can remove this need in the
    future)
    
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=111328
    Fixes: 2edda80db3d0 ("drm/i915: Rename engines to match their user interface")
    Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
    Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
    Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com> #v1
    Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
    Link: https://patchwork.freedesktop.org/patch/msgid/20190808110612.23539-2-chris@chris-wilson.co.uk

but I'm not sure, as my understanding for the bug is that we oversubscribed to an engine and blocked ourselves.
Comment 4 Chris Wilson 2019-08-10 16:28:23 UTC
commit d5b2a3a4f85ad135123db8fc97ccdbf893546330
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Fri Aug 9 13:31:53 2019 +0100

    drm/i915: Check for a second VCS engine more carefully


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.