Bug 111335 - [CI][DRMTIP] igt@kms_ccs@pipe-b-bad-aux-stride - skip - Test requirement: !(width <= 1024), FB already has the smallest possible stride, SKIP
Summary: [CI][DRMTIP] igt@kms_ccs@pipe-b-bad-aux-stride - skip - Test requirement: !(w...
Status: RESOLVED WORKSFORME
Alias: None
Product: DRI
Classification: Unclassified
Component: DRM/Intel (show other bugs)
Version: DRI git
Hardware: Other All
: medium normal
Assignee: Intel GFX Bugs mailing list
QA Contact: Intel GFX Bugs mailing list
URL:
Whiteboard: ReadyForDev
Keywords:
Depends on:
Blocks:
 
Reported: 2019-08-09 07:26 UTC by Lakshmi
Modified: 2019-10-10 06:55 UTC (History)
1 user (show)

See Also:
i915 platform: ICL
i915 features: display/Other


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Lakshmi 2019-08-09 07:26:46 UTC
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_338/fi-icl-u4/igt@kms_ccs@pipe-b-bad-aux-stride.html

Starting subtest: pipe-B-bad-aux-stride
Test requirement not met in function generate_fb, file ../tests/kms_ccs.c:139:
Test requirement: !(width <= 1024)
FB already has the smallest possible stride
Subtest pipe-B-bad-aux-stride: SKIP (0.000s)
Comment 1 CI Bug Log 2019-08-09 07:27:33 UTC
The CI Bug Log issue associated to this bug has been updated.

### New filters associated

* fi-icl-u4: igt@kms_ccs@pipe-b-bad-aux-stride - skip - Test requirement: !(width &lt;= 1024),  FB already has the smallest possible stride, SKIP
  - https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_338/fi-icl-u4/igt@kms_ccs@pipe-b-bad-aux-stride.html
Comment 2 Jyoti Yadav 2019-08-20 09:40:37 UTC
Looks like DP-3 is connected to Pipe B and while listing the supported modes of DP-3, we found:
Modeline "1024x768": 60 65000 1024 1048 1184 1344 768 771 777 806 0x40 0xa
Modeline "800x600": 60 40000 800 840 968 1056 600 601 605 628 0x40 0x5
Modeline "800x600": 56 36000 800 824 896 1024 600 601 603 625 0x40 0x5
Modeline "848x480": 60 33750 848 864 976 1088 480 486 494 517 0x40 0x5
Modeline "640x480": 60 25175 640 656 752 800 480 490 492 525 0x40 0xa

Here the width <= 1024 for the above listed modes and inside IGT there is skip asserted for this condition.

so it might be valid skip according to the developer.
Comment 3 CI Bug Log 2019-08-22 10:11:42 UTC
A CI Bug Log filter associated to this bug has been updated:

{- fi-icl-u4: igt@kms_ccs@pipe-b-bad-aux-stride - skip - Test requirement: !(width &lt;= 1024),  FB already has the smallest possible stride, SKIP -}
{+ fi-icl-u2 fi-icl-u4: igt@kms_ccs@pipe-[ab]-bad-aux-stride - skip - Test requirement: !(width &lt;= 1024),  FB already has the smallest possible stride, SKIP +}


  No new failures caught with the new filter
Comment 4 CI Bug Log 2019-08-22 10:12:52 UTC
A CI Bug Log filter associated to this bug has been updated:

{- fi-icl-u2 fi-icl-u4: igt@kms_ccs@pipe-[ab]-bad-aux-stride - skip - Test requirement: !(width &lt;= 1024),  FB already has the smallest possible stride, SKIP -}
{+ fi-icl-u2 fi-icl-u4: igt@kms_ccs@pipe-[ab]-bad-aux-stride - skip - Test requirement: !(width &lt;= 1024),  FB already has the smallest possible stride, SKIP +}

New failures caught by the filter:

  * https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_348/fi-icl-u2/igt@kms_ccs@pipe-c-bad-aux-stride.html
Comment 5 Mika Kahola 2019-09-30 11:01:39 UTC
In a test for a width, we select the minimum of

min(MAX_SPRITE_PLANE_WIDTH, drm_mode->hdisplay)

and we have defined the MAX_SPRITE_WIDTH 

"
/*
 * Limit maximum used sprite plane width so this test will not mistakenly
 * fail on hardware limitations which are not interesting to this test.
 * On this test too wide sprite plane may fail during creation with dmesg
 * comment saying:
 * "Requested display configuration exceeds system watermark limitations"
 */
#define MAX_SPRITE_PLANE_WIDTH 2000
"

As Jyoti mentioned earlier, the test has selected MAX_SPRITE_PLANE_WIDTH is limited to 2000 on purpose in order to avoid possible hw limitations.

Maybe we could try to set the limit to 512 to avoid skips?
Comment 6 Mika Kahola 2019-09-30 11:26:09 UTC
(In reply to Mika Kahola from comment #5)
> In a test for a width, we select the minimum of
> 
> min(MAX_SPRITE_PLANE_WIDTH, drm_mode->hdisplay)
> 
> and we have defined the MAX_SPRITE_WIDTH 
> 
> "
> /*
>  * Limit maximum used sprite plane width so this test will not mistakenly
>  * fail on hardware limitations which are not interesting to this test.
>  * On this test too wide sprite plane may fail during creation with dmesg
>  * comment saying:
>  * "Requested display configuration exceeds system watermark limitations"
>  */
> #define MAX_SPRITE_PLANE_WIDTH 2000
> "
> 
> As Jyoti mentioned earlier, the test has selected MAX_SPRITE_PLANE_WIDTH is
> limited to 2000 on purpose in order to avoid possible hw limitations.
> 
> Maybe we could try to set the limit to 512 to avoid skips?

I sent a patch to test with lower MAX_SPRITE_PLANE_WIDTH

https://patchwork.freedesktop.org/series/67396/
Comment 7 Jani Saarinen 2019-10-10 06:55:15 UTC
This now poassing on ICL systems. Resolving.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.