According to Danylo's investigations, he found out that shadows flickering in the game are related to the same issue with shadows, reported here https://bugs.freedesktop.org/show_bug.cgi?id=110395
But now there is impossible to reproduce that problem in Supertuxcart. I re-checked Tropico and found out, that flickering is still actual for the game. More over - patch, maiden for tuxcart - fixes it => https://gitlab.freedesktop.org/mesa/mesa/merge_requests/660
Attaching apitace for the game => https://drive.google.com/open?id=1sYaMbbZLrIsB4GItKdty6wzYmJ0BDN1i
(pay attention to the shadows under the trees, all other "flickers" not relate to current discussion)
I've checked the issue on the BSW (Fedora 29, kernel 5.1.6) with mesa 18.3.6 and the latest master version - no flickers in the trace for both versions.
I'll check the issue on the BDW and post results here.
I've finally rechecked the issue on the BDW (Intel® HD Graphics 5500) with system mesa 19.0.6 and the latest master version - didn't see any flickers.
Also, the patch fixes flickers of trees in Tropico 6 on the HSW (Intel® HD Graphics 4600).
Sorry for the my useless comment higher.
Also, the issue from https://bugs.freedesktop.org/show_bug.cgi?id=110395 is actual for HSW.
And it also fixes via Danylo's patch.
Could anybody can make these checks on HSW also? Trace for the tropico - https://drive.google.com/open?id=1sYaMbbZLrIsB4GItKdty6wzYmJ0BDN1i.
Trace for tuxcart - https://drive.google.com/open?id=1hTRS3tgBuSOSNiFGoy7JaLVKkVeNmwb0
With patch and without patch
This is a user-visible (bad) bug, but it hasn't been shown to be a regression. Per the mesa release policies, we are not going to block the release based on it.
Denis/Danylo: I believe there is some review feedback on MR 660 that you can use to get the WIP tag off of that fix. If you are unsure of what needs to be done, can you follow up with the reviewers?
Sure, Mark. We will check it
-- GitLab Migration Automatic Message --
This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.
You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/mesa/mesa/issues/1834.