Bug 11201 - Race condition while manipulating our own vCard
Summary: Race condition while manipulating our own vCard
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: gabble (show other bugs)
Version: unspecified
Hardware: All All
: medium normal
Assignee: Simon McVittie
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-06-08 04:57 UTC by Simon McVittie
Modified: 2007-08-06 09:15 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description Simon McVittie 2007-06-08 04:57:44 UTC
There is some race condition in vCard lookups - if we fetch our own vCard (as we do on connection to get the avatar), set our own alias and set our own avatar, at the same time, then we can accidentally clobber our own changes. Someone needs to examine the relevant code and fix this.

Suggested fix: if there is a request "in flight" to fetch our own vCard, and we get a request to change our own vCard, don't send off a new request to fetch our own vCard. Instead, remember what changes need to be made to our own vCard (possibly coalescing them), and when it arrives, make the changes and send it back out.
Comment 1 Simon McVittie 2007-07-12 09:11:10 UTC
I believe this is causing <http://dev.laptop.org/ticket/1967>.
Comment 2 Simon McVittie 2007-08-06 09:15:48 UTC
Fixed in darcs, will be in Gabble 0.5.13.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.