Bug 112230 - [CI][RESUME]igt@kms_plane_lowres@pipe-* - skip - Current mode not tall enough; plane would still be onscreen after switch to 10x7, SKIP
Summary: [CI][RESUME]igt@kms_plane_lowres@pipe-* - skip - Current mode not tall enough...
Status: RESOLVED NOTABUG
Alias: None
Product: DRI
Classification: Unclassified
Component: DRM/Intel (show other bugs)
Version: DRI git
Hardware: Other All
: not set not set
Assignee: Intel GFX Bugs mailing list
QA Contact: Intel GFX Bugs mailing list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-11-08 08:22 UTC by Lakshmi
Modified: 2019-11-13 00:24 UTC (History)
2 users (show)

See Also:
i915 platform: TGL
i915 features: display/Other


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Lakshmi 2019-11-08 08:22:05 UTC
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7266/re-tgl-u/igt@kms_plane_lowres@pipe-a-tiling-none.html
IGT-Version: 1.24-g8a5d44dc5 (x86_64) (Linux: 5.4.0-rc6-CI-CI_DRM_7266+ x86_64)
Starting subtest: pipe-A-tiling-none
Testing connector eDP-1 using pipe A
Testing connector DP-2 using pipe A
Test requirement not met in function get_lowres_mode, file ../tests/kms_plane_lowres.c:64:
Test requirement: mode_default->vdisplay - SIZE > 768
Current mode not tall enough; plane would still be onscreen after switch to 10x7.
Subtest pipe-A-tiling-none: SKIP (23.437s)
Comment 1 CI Bug Log 2019-11-08 08:23:16 UTC
The CI Bug Log issue associated to this bug has been updated.

### New filters associated

* TGL: igt@kms_plane_lowres@pipe-* - skip - Current mode not tall enough; plane would still be onscreen after switch to 10x7, SKIP
  - https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7266/re-tgl-u/igt@kms_plane_lowres@pipe-a-tiling-none.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7266/re-tgl-u/igt@kms_plane_lowres@pipe-a-tiling-x.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7266/re-tgl-u/igt@kms_plane_lowres@pipe-a-tiling-y.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7266/re-tgl-u/igt@kms_plane_lowres@pipe-b-tiling-none.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7266/re-tgl-u/igt@kms_plane_lowres@pipe-b-tiling-x.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7266/re-tgl-u/igt@kms_plane_lowres@pipe-b-tiling-y.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7266/re-tgl-u/igt@kms_plane_lowres@pipe-c-tiling-none.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7266/re-tgl-u/igt@kms_plane_lowres@pipe-c-tiling-x.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7266/re-tgl-u/igt@kms_plane_lowres@pipe-c-tiling-y.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7266/re-tgl-u/igt@kms_plane_lowres@pipe-d-tiling-none.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7266/re-tgl-u/igt@kms_plane_lowres@pipe-d-tiling-x.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7266/re-tgl-u/igt@kms_plane_lowres@pipe-d-tiling-y.html
Comment 2 Matt Roper 2019-11-13 00:24:51 UTC
This skip is expected/intentional.  The display you have connected to DP-2 is running at a very small 848x480 resolution when the driver inherits the display configuration from the BIOS:

<7>[   13.983855] [drm:drm_client_firmware_config.isra.8] connector DP-2 on [CRTC:152:pipe B]: 848x480

I think your monitor is larger than this, but this is the mode that the BIOS decided to setup and that we inherited when our driver initialized (it's possible that a flaky connection led to link training failures in the BIOS and caused the BIOS to choose this as the "best" possible mode).

Given that tiny mode, it makes sense for this test to skip since this test relies on the current mode being a "big" mode and that the test can switch to a smaller mode during its testing.  Specifically, this test places a small cursor/sprite plane in the lower left corner of the screen, then switches to a "lowres" mode that is enough smaller that the plane's position will now be completely offscreen and clipped.  When looking for a "lowres" mode, the test walks down the driver's modelist looking for one that's enough smaller than the current mode that it will cause the plane to be offscreen.  If no suitable lowres mode is found on the driver's modelist, the driver will check whether a standard 10x7 mode is good enough to meet this criteria; if it isn't then the test gives up and skips since there's nothing meaningful that can be tested.

Given that your current mode is 848x480, you'd need a mode with a vertical resolution of 480-256=224 or lower.  Ville has some patches that make some changes to this test, including changing the plane size from 256 to 64, but even with those patches, you'd still need a vertical resolution of 480-64=416 or lower.  So I don't think his patches will make a difference for the failures here, even though they're doing other general cleanup to this test.

The test and driver appear to be working as expected here, so marking this as NOTABUG.  Realistically the monitor probably shouldn't be initialized to such a small 848x480 mode by the BIOS, but as I mentioned before, there's a good chance that's just due to a bad connection that causes link training to fail.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.