Bug 11228 - compilation errors when using popler headers in multithreaded applications
Summary: compilation errors when using popler headers in multithreaded applications
Status: RESOLVED FIXED
Alias: None
Product: poppler
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Hardware: Other Linux (All)
: medium minor
Assignee: poppler-bugs
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-06-11 02:50 UTC by Axel Howind
Modified: 2007-06-11 14:14 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
cleanup includes for poppler 0.5.9 (2.03 KB, patch)
2007-06-11 02:55 UTC, Axel Howind 		Details | Splinter Review
View All

Description Axel Howind 2007-06-11 02:50:54 UTC 
headers installed using "--enable-xpdf-headers" mix up use of #include "goo/..." and <goo/...>, wich leads to compilation errors in some circumstances (applies to 0.5.4 and 0.5.9 Release Candidate).

Example (from GlobalParams.h):

  #include "goo/gtypes.h"
  #include "CharTypes.h"
  
  #if MULTITHREADED
  #include <goo/GooMutex.h>
  #endif

This works when compiling w/o MULTITHREADED, but does not when it is defined.

Steps to reproduce: use #include <poppler/GlobalParams.h> in any of your sources and compile with MULTITHREADED defined.

Workaround: Use an additional -I /usr/local/include/poppler in your application's makefile (or wherever your headers are installed).
Comment 1 Axel Howind 2007-06-11 02:55:44 UTC 
Created attachment 10249 [details] [review]
cleanup includes for poppler 0.5.9

This patch changes all remaining #include <goo/...> to "goo/..." in the poppler headers.
Comment 2 Albert Astals Cid 2007-06-11 14:14:39 UTC 
Commited into the cvs. Thanks for the patch.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.