Bug 112376 - ThinkPad X1 Extreme 2nd Generation does not advertise DPCD backlight in vbios
Summary: ThinkPad X1 Extreme 2nd Generation does not advertise DPCD backlight in vbios
Status: RESOLVED MOVED
Alias: None
Product: DRI
Classification: Unclassified
Component: DRM/Intel (show other bugs)
Version: DRI git
Hardware: Other All
: high major
Assignee: Intel GFX Bugs mailing list
QA Contact: Intel GFX Bugs mailing list
URL:
Whiteboard: Triaged, ReadyForDev
Keywords:
Depends on:
Blocks:
 
Reported: 2019-11-22 21:18 UTC by Lyude Paul
Modified: 2019-11-29 19:51 UTC (History)
2 users (show)

See Also:
i915 platform: CFL
i915 features: display/backlight


Attachments
VBIOS (6.00 KB, application/octet-stream)
2019-11-22 21:18 UTC, Lyude Paul
no flags Details
dmesg (drm.debug=0x1e log_buf_len=4M, dpcd aux backlight left disabled + no patches) (158.73 KB, text/x-log)
2019-11-26 22:12 UTC, Lyude Paul
no flags Details
dmesg (drm.debug=0x1e log_buf_len=4M, dpcd aux backlight enabled manually + no patches) (158.87 KB, text/x-log)
2019-11-26 22:14 UTC, Lyude Paul
no flags Details

Description Lyude Paul 2019-11-22 21:18:05 UTC
Created attachment 146015 [details]
VBIOS

Filing this at the request of some of the Intel folks. I recently got my hand on a ThinkPad X1 Extreme 2nd Generation with the optional 4K AMOLED screen, and discovered that backlight controls weren't working. While there seems to be multiple problems here, all of which I've come up with some patches for that I plan to send out after filing this bug, one of the big things I noticed was that despite requiring DPCD backlight control this laptop claims to be using PWM backlight controls in it's vbios. So, I'm filing this bug to upload the vbios along with DPCD and other relevant information here.

As well, here's a dump of some relevant DPCD registers:

[    3.142168] [drm:intel_dp_read_dpcd [i915]] DPCD: 14 14 c4 01 00 00 01 c0 02 14 00 00 00 08 82
[    3.142600] [drm:drm_dp_read_desc [drm_kms_helper]] DP sink: OUI ba-41-59 dev-ID  HW-rev 0.0 SW-rev 0.0 quirks 0x0000
[    3.143012] [drm:intel_dp_init_connector [i915]] eDP DPCD: 05 9d a6

If you need any more information just let me know and I'll be happy to uplaod it
Comment 1 Lakshmi 2019-11-24 18:52:24 UTC
(In reply to Lyude Paul from comment #0)
> Created attachment 146015 [details]
> VBIOS
> 
> Filing this at the request of some of the Intel folks. I recently got my
> hand on a ThinkPad X1 Extreme 2nd Generation with the optional 4K AMOLED
> screen, and discovered that backlight controls weren't working. While there
> seems to be multiple problems here, all of which I've come up with some
> patches for that I plan to send out after filing this bug, one of the big
> things I noticed was that despite requiring DPCD backlight control this
> laptop claims to be using PWM backlight controls in it's vbios. So, I'm
> filing this bug to upload the vbios along with DPCD and other relevant
> information here.
> 
> As well, here's a dump of some relevant DPCD registers:
> 
> [    3.142168] [drm:intel_dp_read_dpcd [i915]] DPCD: 14 14 c4 01 00 00 01 c0
> 02 14 00 00 00 08 82
> [    3.142600] [drm:drm_dp_read_desc [drm_kms_helper]] DP sink: OUI ba-41-59
> dev-ID  HW-rev 0.0 SW-rev 0.0 quirks 0x0000
> [    3.143012] [drm:intel_dp_init_connector [i915]] eDP DPCD: 05 9d a6
> 
> If you need any more information just let me know and I'll be happy to
> uplaod it

How old is the kernel? Can you attach the full dmesg with kernel parameters drm.debug=0x1e log_buf_len=4M to see more information about the issue?
Comment 2 Lyude Paul 2019-11-26 22:10:25 UTC
(In reply to Lakshmi from comment #1)
> (In reply to Lyude Paul from comment #0)
> > Created attachment 146015 [details]
> > VBIOS
> > 
> > Filing this at the request of some of the Intel folks. I recently got my
> > hand on a ThinkPad X1 Extreme 2nd Generation with the optional 4K AMOLED
> > screen, and discovered that backlight controls weren't working. While there
> > seems to be multiple problems here, all of which I've come up with some
> > patches for that I plan to send out after filing this bug, one of the big
> > things I noticed was that despite requiring DPCD backlight control this
> > laptop claims to be using PWM backlight controls in it's vbios. So, I'm
> > filing this bug to upload the vbios along with DPCD and other relevant
> > information here.
> > 
> > As well, here's a dump of some relevant DPCD registers:
> > 
> > [    3.142168] [drm:intel_dp_read_dpcd [i915]] DPCD: 14 14 c4 01 00 00 01 c0
> > 02 14 00 00 00 08 82
> > [    3.142600] [drm:drm_dp_read_desc [drm_kms_helper]] DP sink: OUI ba-41-59
> > dev-ID  HW-rev 0.0 SW-rev 0.0 quirks 0x0000
> > [    3.143012] [drm:intel_dp_init_connector [i915]] eDP DPCD: 05 9d a6
> > 
> > If you need any more information just let me know and I'll be happy to
> > uplaod it
> 
> How old is the kernel? Can you attach the full dmesg with kernel parameters
> drm.debug=0x1e log_buf_len=4M to see more information about the issue?

I'm seeing this with drm-tip, and I just rechecked today and the issue is still present.
I'm about to attach the dmesg you asked for as well
Comment 3 Lyude Paul 2019-11-26 22:12:45 UTC
Created attachment 146027 [details]
dmesg (drm.debug=0x1e log_buf_len=4M, dpcd aux backlight left disabled + no patches)
Comment 4 Lyude Paul 2019-11-26 22:14:50 UTC
Created attachment 146028 [details]
dmesg (drm.debug=0x1e log_buf_len=4M, dpcd aux backlight enabled manually + no patches)
Comment 5 Lakshmi 2019-11-27 13:00:41 UTC
(In reply to Lyude Paul from comment #0)
> Created attachment 146015 [details]
> VBIOS
> 
> Filing this at the request of some of the Intel folks. I recently got my
> hand on a ThinkPad X1 Extreme 2nd Generation with the optional 4K AMOLED
> screen, and discovered that backlight controls weren't working. While there
> seems to be multiple problems here, all of which I've come up with some
> patches for that I plan to send out after filing this bug, one of the big
> things I noticed was that despite requiring DPCD backlight control this
> laptop claims to be using PWM backlight controls in it's vbios. So, I'm
> filing this bug to upload the vbios along with DPCD and other relevant
> information here.
> 
> As well, here's a dump of some relevant DPCD registers:
> 
> [    3.142168] [drm:intel_dp_read_dpcd [i915]] DPCD: 14 14 c4 01 00 00 01 c0
> 02 14 00 00 00 08 82
> [    3.142600] [drm:drm_dp_read_desc [drm_kms_helper]] DP sink: OUI ba-41-59
> dev-ID  HW-rev 0.0 SW-rev 0.0 quirks 0x0000
> [    3.143012] [drm:intel_dp_init_connector [i915]] eDP DPCD: 05 9d a6
> 
> If you need any more information just let me know and I'll be happy to
> uplaod it

@Jani, Any comments? Logs from drmtip is attached in the bug.
Comment 6 Martin Peres 2019-11-29 19:51:55 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/drm/intel/issues/642.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.