Bug 11307 - New Compose file for Ethiopean locale am_ET.UTF-8
Summary: New Compose file for Ethiopean locale am_ET.UTF-8
Status: RESOLVED INVALID
Alias: None
Product: xorg
Classification: Unclassified
Component: Lib/Xlib (data) (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: James Cloos
QA Contact: Xorg Project Team
URL:
Whiteboard: 2011BRB_Reviewed
Keywords: i18n, patch
Depends on:
Blocks:
 
Reported: 2007-06-18 15:45 UTC by Sergey V. Udaltsov
Modified: 2019-10-30 17:29 UTC (History)
3 users (show)

See Also:
i915 platform:
i915 features:


Attachments
Compose file for am_ET.UTF-8 (13.82 KB, text/plain)
2007-06-18 15:46 UTC, Sergey V. Udaltsov
no flags Details

Description Sergey V. Udaltsov 2007-06-18 15:45:50 UTC
Here is new Compose file for the am_ET.UTF-8 locale.
xkeyboard-config has already got an 'et' symbols for the part of the alphabet. The rest is implemented as a Compose file
Comment 1 Sergey V. Udaltsov 2007-06-18 15:46:41 UTC
Created attachment 10369 [details]
Compose file for am_ET.UTF-8
Comment 2 James Cloos 2007-08-18 17:18:21 UTC
Sergey,

I note that this compose table contains entries which start with the key <c>, but that symbol does not exist in xkeyboard-config/symbols/et.

Has this compose table fallen out of sync with the keyboard in xkeyboard-config?
Comment 3 James Cloos 2007-08-18 17:20:24 UTC
And I forgot to ask:

do you also have XI18N_OBJS and XLC_LOCALE.pre files written to go along with the Compose file?
Comment 4 Sergey V. Udaltsov 2007-08-19 05:48:07 UTC
> I note that this compose table contains entries which start with the key <c>,
> but that symbol does not exist in xkeyboard-config/symbols/et.
You're right, I'll add these "dead" symbols ASAP.
Comment 5 Sergey V. Udaltsov 2007-08-19 05:56:50 UTC
No, I do not have these files. I would copy them from, say, en_US.UTF-8. I simply have no information to compose them. I'll ask Jim Gettys - may be, he'd find somebody...
Comment 6 Sergey V. Udaltsov 2007-08-19 06:11:03 UTC
I've committed missing C key, thanks for spotting it.

Comment 7 James Cloos 2007-08-20 12:39:48 UTC
Pushed in commit 4ec1723fff729440cd3349c1f95d87d2a6ba89cf.

That done, should new dead key symbols be added to keysymdef.h and used instead of using ASCII characters as dead keys?

We could (should?) add an XK_ETHIOPIC section modeled after the XK_BRAILLE section.
Comment 8 Sergey V. Udaltsov 2007-08-20 12:56:23 UTC
> Pushed in commit 4ec1723fff729440cd3349c1f95d87d2a6ba89cf.
Thanks!

> That done, should new dead key symbols be added to keysymdef.h and used instead
> of using ASCII characters as dead keys?
It is a very good question. What is the general policy here? I do not mind either way. What's bad about using ordinary ASCII as dead keys (if they are not used as normal keys in that layout)?
Comment 9 James Cloos 2007-08-20 19:46:34 UTC
(In reply to comment #8)
> What's bad about using ordinary ASCII as dead keys
> (if they are not used as normal keys in that layout)?

Yes, I should have continued the thought.  Sorry about that.

The benefits I see are “correctness” — for some definition thereof ☺ —
and the ability to merge the compose table into en_US.UTF-8/Compose.pre.

(Until now am_ET.UTF-8/Compose has been an alias for en_US.UTF-8/Compose.)
Comment 10 Sergey V. Udaltsov 2007-08-21 00:00:46 UTC
OK, it makes sense. If you'd push new deadkeys into keysymdef - at some point later I'd make corresponding changes in xkeyboard-config. But I am not sure merging this very specific Compose into en_US is a good idea in general.
Comment 11 James Cloos 2007-08-24 11:11:35 UTC
(In reply to comment #10)
> OK, it makes sense. If you'd push new deadkeys into keysymdef - at some point
> later I'd make corresponding changes in xkeyboard-config. 

I don't want to push it unilaterally, so we'll see whether anyone comments....

> But I am not sure
> merging this very specific Compose into en_US is a good idea in general.

Presumably someone operation in the am_ET.UTF-8 locale needs to type more than just Ge'ez/Amharic/Tigrigna, and so will probably want to have et and something like us(intl) on separate groups for easy switching, and since the Compose file is chosen based on $LOCALE, it seems beneficial to merge all of the UTF-8 Compose files into one.
Comment 12 Sergey V. Udaltsov 2007-08-24 12:26:44 UTC
> I don't want to push it unilaterally, so we'll see whether anyone comments....
OK.

> is chosen based on $LOCALE, it seems beneficial to merge all of the UTF-8
> Compose files into one.
Yes it makes sense. Anyway, it's up to you, you maintain this package, so you better understand the general policy here. But it is possible only after new dead keysyms are approved (and even after that, different exotic layouts might have different views on how to use dead_c)

Comment 13 Jeremy Huddleston Sequoia 2011-10-03 01:11:58 UTC
It looks like nobody complained.  Did this ever get pushed?  If not, can we 
push it?
Comment 14 Adam Jackson 2018-06-12 19:08:33 UTC
Mass closure: This bug has been untouched for more than six years, and is not
obviously still valid. Please reopen this bug or file a new report if you continue to experience issues with current releases.
Comment 15 Mike FABIAN 2019-10-30 17:29:54 UTC
(In reply to Sergey V. Udaltsov from comment #8)

> > That done, should new dead key symbols be added to keysymdef.h and used instead
> > of using ASCII characters as dead keys?
> It is a very good question. What is the general policy here? I do not mind
> either way. What's bad about using ordinary ASCII as dead keys (if they are
> not used as normal keys in that layout)?

Because you cannot type ASCII anymore then.
Not even switching the keyboard layout helps.

If you run in am_ET.UTF-8 locale, the compose file
/usr/share/X11/locale/am_ET.UTF-8/Compose is used.

And if that file contains something like 

<u> <U1200> : "ሁ" U1201 # key h (base character ሀ)

it becomes impossible to type a normal u.

No matter what keyboard layout you use, switching to US English keyboard layout doesn’t help. One can type an x because no sequence starts with <x> in /usr/share/X11/locale/am_ET.UTF-8/Compose but on cannot type an u.

One would need to switch to another locale to type an u.
And as switching locales on the fly is not really an option,
this does not make sense.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.