Created attachment 10560 [details] [review]
Patch for sr_RS and sr_ME locales

Any feedback or estimates for applying this change?

Would be great to have it in for 7.4 and the spring 2008 round of distros.

Any news on this? Any particular reason the patch is not being applied?

The warning messages that stuff on top of X reports, such as "Qt: Locales not supported on X server", are getting kind of boring.

This bug is reported in Debian as http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=507940 and in Ubuntu as https://bugs.launchpad.net/ubuntu/+source/libx11/+bug/299841

It would be great if this patch can be included in next release. Any progress on this?

I'll get this pushed.

Downstream Gentoo bug : http://bugs.gentoo.org/253145

The patch given in attachment 10560 [details] [review] is broken - it loses some characters
from some other locales:

@@ -1148,7 +1132,7 @@
 american.iso88591:				en_US.ISO8859-1
 arabic.iso88596:				ar_AA.ISO8859-6
 bokmal:						nb_NO.ISO8859-1
-bokm�l:						nb_NO.ISO8859-1
+bokml:						nb_NO.ISO8859-1
 bulgarian:					bg_BG.CP1251
 c-french.iso88591:				fr_CA.ISO8859-1
 catalan:					ca_ES.ISO8859-1
@@ -1167,7 +1151,7 @@
 estonian:					et_EE.ISO8859-1
 finnish:					fi_FI.ISO8859-1
 finnish.iso88591:				fi_FI.ISO8859-1
-fran�ais:					fr_FR.ISO8859-1
+franais:					fr_FR.ISO8859-1
 french:						fr_FR.ISO8859-1
 french.iso88591:				fr_CH.ISO8859-1
 galego:						gl_ES.ISO8859-1

[...]
@@ -1299,7 +1283,7 @@
 Dutch_Belgium.1252:				nl_BE.iso8859-1
 Dutch_Netherlands.1252:				nl_NL.iso8859-1
 Norwegian (Nynorsk)_Norway.1252:		no_NO.iso8859-1
-Norwegian (Bokm�l)_Norway.1252:			no_NO.iso8859-1
+Norwegian (Bokml)_Norway.1252:			no_NO.iso8859-1
 Polish_Poland.1250:				pl_PL.iso8859-2
 Portuguese_Brazil.1252:				pt_BR.iso8859-1
 Portuguese_Portugal.1252:			pt_PT.iso8859-1

Alan, the patch seems to be ISO-8859-1 encoded for some reason, I suggest you use iconv to convert it to UTF-8. Otherwise, let me know and I'll resubmit it.

If it was just the encoding of the patch, it wouldn't show those lines
as being edited - it seems to be an encoding problem in the environment
either the editor or diff was run in to generate the patch.

Created attachment 23937 [details] [review]
Updated patch

Right you are. Patch reattached with problematic hunks removed, they have no relation to our locale anyway.

Thanks - corrected patch pushed to git master for next libX11 release:

commit da95ecbbdcacc483cd0b5fd7db1fb2e2543341bd
Author: Milos Komarcevic <miloskomarcevic@netscape.net>
Date:   Mon Mar 16 17:43:26 2009 -0700

    Bug 11456: Serbian locale updates (sr_RS and sr_ME)
    
    X.Org Bug #11456 <http://bugs.freedesktop.org/show_bug.cgi?id=11456>
    Patch #23937 <http://bugs.freedesktop.org/attachment.cgi?id=23937>
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith@sun.com>

It seems some entries are still missing: when starting LibreOffice in
sr_RS.UTF-8@latin locale, it reports "X Window System doesn't support locale
'sr_RS.UTF-8@latin'" and then there are encoding problems inside. I fixed it
by adding this line to /usr/share/X11/locale/locale.dir:

  en_US.UTF-8/XLC_LOCALE: sr_RS.UTF-8@latin

Maybe the following patch would suffice?

Created attachment 59641 [details] [review]
Additional entries for sr_RS.UTF-8@latin.

Mongolian from Mongolia is also lacking in locale.dir and compose.dir.
See the last comment of
https://bugs.mageia.org/show_bug.cgi?id=7797

Do I need to open a new bug for this, or do we change the bug title?

(In reply to comment #13)
> Created attachment 59641 [details] [review] [review]
> Additional entries for sr_RS.UTF-8@latin.

be_BY.UTF-8@latin is also missing, see:

https://bugs.freedesktop.org/show_bug.cgi?id=75220

-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/xorg/lib/libx11/issues/3.