Now, there is a #error in dbus-internals.h that says "error "This compiler does not support varargs macros and thus verbose mode can't be disabled meaningfully". How about instead having: static void _dbus_verbose(const char x, ...) {;} which should, I hope, be optimized away by most compilers. Index: dbus/dbus-internals.h =================================================================== --- dbus/dbus-internals.h.orig 2006-12-11 19:21:10.000000000 +0000 +++ dbus/dbus-internals.h 2007-07-21 00:33:52.252644787 +0000 @@ -97,7 +97,7 @@ # elif defined (HAVE_GNUC_VARARGS) # define _dbus_verbose(format...) # else -# error "This compiler does not support varargs macros and thus verbose mode can't be disabled meaningfully" +static void _dbus_verbose(const char * x,...) {;} # endif # define _dbus_verbose_reset() # define _dbus_is_verbose() FALSE
Note that, even if the compiler is not as smart as in my dreams, this method allows us to use the same configure options on all plarforms, without the older ones spitting errors.
Makes sense to me, yep.
pushed to git
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.