radeon_mergedfb.c produces compiletime error when building Xorg without Xinerama because of an
undefined reference to noPanoramiXExtension.
patch fixes this problem (this already exists in sis_driver.c)
Created attachment 723 [details] [review]
fix compilation without Xinerama
This might get around the compilation problem, but if Xinerama is not compiled
in, then should the Radeon MergedFB Xinerama support be compiled in? Probably not.
Adding Alex Deucher for comments.
I think we should be ok. the sis and radeon drivers provide their own xinerama
extension by default, but it gets disabled if the real xinerama extension is
active. this fix will probably do it since the "pseudo-xinerama" extension is
self-contained in the driver. Thomas might have more insight as he initially
wrote most of this code.
The SiS and radeon pseudo-Xinerama is, as Alex correctly mentioned, entirely
driver-contained. Hence, it is in fact a driver feature. Without this feature,
MergedFB mode is pretty much useless for the end user.
This feature takes about 10k of the compiled binary, and it can be disabled by
an option. I do not see any reason for skipping compilation if the
server-internal Xinerama (which is much more complicated and therefore
bug-prone) is not being compiled. There is not the slightest connection between
That sounds reasonable.
Patch checked in.