Bug 1179 - ati/radeon_mergedfb.c won't build without Xinerama
Summary: ati/radeon_mergedfb.c won't build without Xinerama
Alias: None
Product: xorg
Classification: Unclassified
Component: Driver/Radeon (show other bugs)
Version: git
Hardware: All All
: high normal
Assignee: Xorg Project Team
QA Contact:
Depends on:
Blocks: 351
  Show dependency treegraph
Reported: 2004-08-25 02:41 UTC by Simon 'corecode' Schubert
Modified: 2004-08-26 02:39 UTC (History)
3 users (show)

See Also:
i915 platform:
i915 features:

fix compilation without Xinerama (758 bytes, patch)
2004-08-25 02:45 UTC, Simon 'corecode' Schubert
no flags Details | Splinter Review

Description Simon 'corecode' Schubert 2004-08-25 02:41:16 UTC
radeon_mergedfb.c produces compiletime error when building Xorg without Xinerama because of an 
undefined reference to noPanoramiXExtension.

patch fixes this problem (this already exists in sis_driver.c)
Comment 1 Simon 'corecode' Schubert 2004-08-25 02:45:29 UTC
Created attachment 723 [details] [review]
fix compilation without Xinerama
Comment 2 Kevin E. Martin 2004-08-25 21:54:54 UTC
This might get around the compilation problem, but if Xinerama is not compiled
in, then should the Radeon MergedFB Xinerama support be compiled in?  Probably not.

Adding Alex Deucher for comments.
Comment 3 Alex Deucher 2004-08-26 05:57:22 UTC
I think we should be ok.  the sis and radeon drivers provide their own xinerama
extension by default, but it gets disabled if the real xinerama extension is
active.  this fix will probably do it since the "pseudo-xinerama" extension is
self-contained in the driver.  Thomas might have more insight as he initially
wrote most of this code.
Comment 4 Thomas Winischhofer 2004-08-26 06:20:45 UTC
The SiS and radeon pseudo-Xinerama is, as Alex correctly mentioned, entirely
driver-contained. Hence, it is in fact a driver feature. Without this feature,
MergedFB mode is pretty much useless for the end user.

This feature takes about 10k of the compiled binary, and it can be disabled by
an option. I do not see any reason for skipping compilation if the
server-internal Xinerama (which is much more complicated and therefore
bug-prone) is not being compiled. There is not the slightest connection between
Comment 5 Kevin E. Martin 2004-08-26 19:39:03 UTC
That sounds reasonable.
Patch checked in.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.